https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/128019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Thank you for your patience!
In general, I think adding a new qualifier to Clang needs to come with
significant justification for the implementation and maintenance costs. In this
specific case, those costs are somewhat amortized because we already have the
`__ptrauth` qua
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) {
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}}
if (errno) {} // no warning
- } else if (Path == NULL) {
@@ -11919,6 +11924,11 @@ bool ArrayExprEvaluator::VisitCXXConstructExpr(const
CXXConstructExpr *E,
if (const ConstantArrayType *CAT = Info.Ctx.getAsConstantArrayType(Type)) {
unsigned FinalSize = CAT->getZExtSize();
+if (!Info.CheckArraySize(E->getExprLoc(),
+
https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/138262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ganenkokb-yandex created
https://github.com/llvm/llvm-project/pull/138838
I've rebased commit from
[Evianaive](https://github.com/Evianaive/llvm-project/commits?author=Evianaive)
and compiled it.
I hope it will speed up fix for #129393.
>From 4f46c654d7efcffc143f73cbc90831
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/138832
>From ba1c2ab6e90e603d3bb0545ff640ab07b524d656 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 7 May 2025 11:03:28 +0200
Subject: [PATCH] [clang][ExprConstant] Bail out on invalid lambda
@@ -5,6 +5,7 @@
// RUN: %clang_cc1 -std=c++17 -verify %s
// RUN: %clang_cc1 -std=c++17 -verify %s -fno-char8_t
// RUN: %clang_cc1 -std=c++20 -verify %s -fno-char8_t
+// RUN: %clang_cc1 -x c -verify %s -fchar8_t
AaronBallman wrote:
CC @jansvoboda11 @MaskRay for
https://github.com/ldionne approved this pull request.
I think this is great and I don't think it impacts libc++ since we moved off of
the builtin a few months ago (in preparation for these kinds of changes).
https://github.com/llvm/llvm-project/pull/138835
_
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/138752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
charan-003 wrote:
@cor3ntin Also, I'm nearly done with this task. Can it be assigned to me?
https://github.com/llvm/llvm-project/pull/117953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Keenuts wrote:
Rebased, tests not pass (HLSL, and locally for the rest). The CI is quite busy
today so the rest is still pending.
Adding more reviewers for the final round
@llvm-beanz for the Microsoft side
@arsenm for the AMDGPU address space bit
https://github.com/llvm/llvm-project/pull/138
arsenm wrote:
* **#138864** https://app.graphite.dev/github/pr/llvm/llvm-project/138864?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/>
* **#138863** https://app.graphite.dev/github/pr/llvm/llvm-p
Author: Alex Voicu
Date: 2025-05-07T14:14:25+01:00
New Revision: 3feb8b42e973f935883bc9e779645ecdae1a586d
URL:
https://github.com/llvm/llvm-project/commit/3feb8b42e973f935883bc9e779645ecdae1a586d
DIFF:
https://github.com/llvm/llvm-project/commit/3feb8b42e973f935883bc9e779645ecdae1a586d.diff
LO
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/138862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138862.diff
2 Files Affected:
- (modified) clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp (+24)
- (modified) clang/test/CodeGenOpen
@@ -236,6 +236,8 @@ enum class OpenMPOffloadMappingFlags : uint64_t {
// dynamic.
// This is an OpenMP extension for the sake of OpenACC support.
OMP_MAP_OMPX_HOLD = 0x2000,
+ /// Self directs mapping without creating a separate device copy.
+ OMP_MAP_SELF = 0x4000,
---
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/134985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
> > > > 3. File has been formatted with clang-format, except for the grammar,
> > > > because clang-format butchers it.
> > >
> > >
> > > Yeah, this problem comes up rather frequently, I wonder if clang-format
> > > can get some additional smarts to make that less of a challeng
https://github.com/AaronBallman approved this pull request.
LGTM, thank you for the fix!
https://github.com/llvm/llvm-project/pull/138872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: Andy Kaylor
Date: 2025-05-07T09:21:01-07:00
New Revision: 8d9f5160b443f431f20f8f88183898503b62a173
URL:
https://github.com/llvm/llvm-project/commit/8d9f5160b443f431f20f8f88183898503b62a173
DIFF:
https://github.com/llvm/llvm-project/commit/8d9f5160b443f431f20f8f88183898503b62a173.diff
L
Author: Mallikarjuna Gouda
Date: 2025-05-07T12:12:06-04:00
New Revision: 55a88cdf53948e7460d9c6892f6c481480faa021
URL:
https://github.com/llvm/llvm-project/commit/55a88cdf53948e7460d9c6892f6c481480faa021
DIFF:
https://github.com/llvm/llvm-project/commit/55a88cdf53948e7460d9c6892f6c481480faa021.
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/138368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Lancern created
https://github.com/llvm/llvm-project/pull/138873
This PR adds LLVMIR lowering support for the `cir.call` operation.
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-famil
@@ -219,6 +219,10 @@ Changes in existing checks
tolerating fix-it breaking compilation when functions is used as pointers
to avoid matching usage of functions within the current compilation unit.
+- Improved :doc:`cppcoreguidelines-missing-std-forward
Euge
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/138673
>From 224ff74f7cd2460414c96e8b528e8f086535da5f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 6 May 2025 12:36:24 +0200
Subject: [PATCH] [clang][ExprConst] Check for array size of initl
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/132242
From e3064b600ea726ab7b3dea054e9f11e1ce028297 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Wed, 19 Mar 2025 16:09:04 +0100
Subject: [PATCH 1/6] [clang-tidy] Add check
bugprone-misle
https://github.com/el-ev approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/138368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kr-sc updated
https://github.com/llvm/llvm-project/pull/137941
>From b720c8d8107dc43eb2fb77e7cd6c0da70224e9d4 Mon Sep 17 00:00:00 2001
From: Kirill Radkin
Date: Sun, 20 Apr 2025 12:35:16 +0300
Subject: [PATCH] [RISCV] Fix generation of DWARF info for vector segmented
types
https://github.com/TheHillBright updated
https://github.com/llvm/llvm-project/pull/93932
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
TheHillBright wrote:
@kadircet @kazutakahirata It has been 9 months since being approved. Can any of
you merge? This is a simple PR that shouldn't be that taking that long...
https://github.com/llvm/llvm-project/pull/93932
___
cfe-commits mailing list
@@ -105,9 +105,6 @@ void errno_getcwd(char *Buf, size_t Sz) {
clang_analyzer_eval(errno != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(Path == NULL); // expected-warning{{TRUE}}
if (errno) {} // no warning
- } else if (Path == NULL) {
bellenot wrote:
Well, sorry, but I'm afraid this particular case is beyond my expertise... Is
there any way I could test this on Windows with different scenarios? AFAICS, we
(ROOT) have an older version of Interpreter.cpp and I have no experience with
clang and clang-repl.
https://github.com/
https://github.com/mstorsjo edited
https://github.com/llvm/llvm-project/pull/138583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mstorsjo approved this pull request.
LGTM. Quite amazing if this is the only change needed, if the existing `#ifdef
__x86_64__` work as needed here (except for the force unwinding tests).
https://github.com/llvm/llvm-project/pull/138583
___
https://github.com/tclin914 created
https://github.com/llvm/llvm-project/pull/138827
The spec can be found at:
https://github.com/andestech/andes-v5-isa/releases/tag/ast-v5_4_0-release.
This patch only supports assembler.
Intrinsics support will be added in a later patch.
>From 034d5c463c8616
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Jim Lin (tclin914)
Changes
The spec can be found at:
https://github.com/andestech/andes-v5-isa/releases/tag/ast-v5_4_0-release.
This patch only supports assembler.
Intrinsics support will be added in a later patch.
---
Full diff
https://github.com/AaronBallman approved this pull request.
LGTM! Assuming we don't get push-back by Friday from downstreams on the
Discourse post or here on the PR, I think it's fine to land. (I think
downstreams need more than ~2 days to determine impacts, but ~5 days is a bit
more reasonabl
mgorny wrote:
Yeah, I think it's a good idea. Thanks for doing that!
https://github.com/llvm/llvm-project/pull/138587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
1 nit, else LGTM.
https://github.com/llvm/llvm-project/pull/138752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12490,6 +12499,17 @@ static void AnalyzeImplicitConversions(
(BO->getOpcode() == BO_And ? "&&" : "||"));
S.Diag(BO->getBeginLoc(), diag::note_cast_operand_to_int);
}
+} else if (BO->isCommaOp() && !S.getLangOpts().CPlusPlus) {
+ ///
https://github.com/AlexVlx closed
https://github.com/llvm/llvm-project/pull/138790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,34 @@
+//===--- UseEnumClassCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/jiefwo created
https://github.com/llvm/llvm-project/pull/138894
Since arrays decay into pointers, no need to check them for arguments. This
commit reverts part of the changes from the commit "[OpenCL] Check for invalid
kernel arguments in array types" 3b238ed6626983beb238b95
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jiefeng Wang (jiefwo)
Changes
Since arrays decay into pointers, no need to check them for arguments. This
commit reverts part of the changes from the commit "[OpenCL] Check for invalid
kernel arguments in array types" 3b238ed6626983beb238
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/138877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielCChen wrote:
> 1. It should be in `$prefix/lib/clang/finclude//*.h`
Just want to make sure: Should it be
`$prefix/lib/clang/${LLVM_VERSION_MAJOR}/finclude//*.mod`
https://github.com/llvm/llvm-project/pull/137828
___
cfe-commits mailing list
cfe
vgvassilev wrote:
> The JIT does not support native TLS on Windows yet.
I thought @sunho has implemented the native tls support in jitlink. Is that
different?
https://github.com/llvm/llvm-project/pull/127468
___
cfe-commits mailing list
cfe-commits@l
@@ -1181,7 +1228,9 @@ DEFINE_LIBUNWIND_FUNCTION(__unw_getcontext)
#endif
+#ifndef __arm64ec__
mstorsjo wrote:
Can you explain why this has to be ifdeffed out here?
https://github.com/llvm/llvm-project/pull/138583
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,58 @@
+//===--- MisleadingSetterOfReferenceCheck.cpp -
clang-tidy-===//
+//
+// Part of the LLVM
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Fixes https://github.com/llvm/llvm-project/issues/138824
---
Full diff: https://github.com/llvm/llvm-project/pull/138832.diff
3 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+4)
- (mod
https://github.com/Sirraide commented:
It would be nice to also have tests to make sure we *do* emit the warning if
the array is too large
https://github.com/llvm/llvm-project/pull/138673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/138862
None
>From a15f7ba2937dad879b42ed924b38caf29e919508 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Wed, 7 May 2025 08:38:49 +0200
Subject: [PATCH] clang/OpenCL: Add baseline test showing broken codegen
---
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/138928
>From a488081edf4c975a63414c6a5ea713403f2d77bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 7 May 2025 11:01:14 -0700
Subject: [PATCH 1/2] [clang][Driver] Handle ROCm installation layout of
lib/llvm/b
https://github.com/fangyi-zhou updated
https://github.com/llvm/llvm-project/pull/137355
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
alejandro-colomar wrote:
> > @AaronBallman This is ready. Still, my patches for GCC had another set of
> > tests that are completely missing here: run-time tests (assert(3)) for
> > non-ICE (so, VLA). Maybe you could add a set of tests that are run (not
> > just compiled).
>
> We don't do end
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jacob Lambert (lamb-j)
Changes
Committing on behalf of @stellaraccident
---
Full diff: https://github.com/llvm/llvm-project/pull/138928.diff
1 Files Affected:
- (modified) clang/lib/Driver/ToolChains/AMDGPU.cpp (+8-1)
``diff
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/138052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -60,6 +60,7 @@ struct CommentInfo {
// the vector.
bool operator<(const CommentInfo &Other) const;
+ // TODO: The Kind field should be an enum, so we can switch on it easily
petrhosek wrote:
```suggestion
// TODO: The Kind field should be an enum, s
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/138594
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
Author: Devon Loehr
Date: 2025-05-07T20:10:25+02:00
New Revision: 8810595068a3f17c444e7f96733a6cd9dc08987e
URL:
https://github.com/llvm/llvm-project/commit/8810595068a3f17c444e7f96733a6cd9dc08987e
DIFF:
https://github.com/llvm/llvm-project/commit/8810595068a3f17c444e7f96733a6cd9dc08987e.diff
L
@@ -715,7 +716,11 @@ void ExprEngine::handleConstructor(const Expr *E,
// actually make things worse. Placement new makes this tricky as well,
// since it's then possible to be initializing one part of a multi-
// dimensional array.
-State = Stat
https://github.com/zmodem closed
https://github.com/llvm/llvm-project/pull/138741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/138052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -181,8 +181,15 @@ RocmInstallationDetector::getInstallationPathCandidates() {
// Some versions of the rocm llvm package install to /opt/rocm/llvm/bin
// Some versions of the aomp package install to /opt/rocm/aomp/bin
-if (ParentName == "llvm" || ParentName.start
@@ -262,8 +262,8 @@ struct Location {
std::tie(Other.StartLineNumber, Other.EndLineNumber,
Other.Filename);
}
- int StartLineNumber = 0; // Line number of this Location.
- int EndLineNumber = 0;
+ int StartLineNumber = 0; // Line number of this Location.
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/138928
Committing on behalf of @stellaraccident
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacS
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/137999
>From d6e88d0ced28861ed0181b2d4aa2269582f768d9 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 30 Apr 2025 17:17:32 +
Subject: [PATCH 1/4] pre-req: add missing lexing keywords
---
clang/include/clan
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/138053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtarditi wrote:
LGTM. @ziqingluo-90 thank you for fixing this problem!
https://github.com/llvm/llvm-project/pull/138594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/t-rasmud approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/138068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xlauko wrote:
> As far as I understood, they will not always return ConstVecAttr and IntAttr
> because if an index or a vector is coming from parameters, or other
> variables, they are not constants in that case, and I am thinking even if the
> vector is constant, we will use load or get_globa
bwendling wrote:
Friendly ping x 2 :)
https://github.com/llvm/llvm-project/pull/137250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bwendling wrote:
This is superseded by https://github.com/llvm/llvm-project/pull/137250.
https://github.com/llvm/llvm-project/pull/136239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/bwendling closed
https://github.com/llvm/llvm-project/pull/136239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -181,8 +181,15 @@ RocmInstallationDetector::getInstallationPathCandidates() {
// Some versions of the rocm llvm package install to /opt/rocm/llvm/bin
arsenm wrote:
Doesn't this end up being the clang resource directory? Why do we need
additional handli
AmrDeveloper wrote:
@bcardosolopes, I think we can finish this PR, and I will continue searching
for a test case for folding without blocking upstreaming other Vector Ops.
Also, I think the same idea can be applied to Arrays, what do you think?
https://github.com/llvm/llvm-project/pull/138413
cor3ntin wrote:
I'll investigate separately if we can detect cases where `memcpy`/ `memmove`
should be replaced by `trivially_relocate`
https://github.com/llvm/llvm-project/pull/138835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/paulwalker-arm closed
https://github.com/llvm/llvm-project/pull/138262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Paul Walker
Date: 2025-05-07T11:05:25+01:00
New Revision: 01813e89295b9229760bc9a62926e04bfbe866c2
URL:
https://github.com/llvm/llvm-project/commit/01813e89295b9229760bc9a62926e04bfbe866c2
DIFF:
https://github.com/llvm/llvm-project/commit/01813e89295b9229760bc9a62926e04bfbe866c2.diff
L
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/132242
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
https://github.com/PeddleSpam updated
https://github.com/llvm/llvm-project/pull/128938
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,san
arsenm wrote:
* **#138840** https://app.graphite.dev/github/pr/llvm/llvm-project/138840?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13884
@@ -1913,7 +1916,7 @@ def type(self):
return self._type
@property
-def canonical(self):
+def canonical(self) -> Cursor | None:
"""Return the canonical Cursor corresponding to this Cursor.
Endilll wrote:
> That said, the input to i
https://github.com/saksham-joshi updated
https://github.com/llvm/llvm-project/pull/138649
>From 8bba07d817d4dd583122d7ed831de276da8801e0 Mon Sep 17 00:00:00 2001
From: SAKSHAM JOSHI
Date: Tue, 6 May 2025 12:43:34 +0530
Subject: [PATCH 1/3] FEAT: one byte for "true" & "false"
In C programming l
@@ -0,0 +1,58 @@
+//===--- MisleadingSetterOfReferenceCheck.cpp -
clang-tidy-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/138840
None
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
https://github.com/saksham-joshi closed
https://github.com/llvm/llvm-project/pull/138649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/138840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1821,45 +1824,45 @@ def mangled_name(self):
return self._mangled_name
@property
-def location(self):
+def location(self) -> SourceLocation:
"""
Return the source location (the starting character) of the entity
pointed at by th
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/138840.diff
2 Files Affected:
- (modified) clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp (+23-5)
- (modified) clang/test/CodeGenCX
@@ -6174,6 +6174,19 @@ void
CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD,
CodeGenFunction(*this).GenerateCode(GD, Fn, FI);
setNonAliasAttributes(GD, Fn);
+
+ bool ShouldAddOptNone = !CodeGenOpts.DisableO0ImplyOptNone &&
+ (CodeGenOpt
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
The C++26 standard relocatable type traits has slightly different semantics, so
we introduced a new ``__builtin_is_cpp_trivially_relocatable`` when
implementing trivial relocation in #127636.
However, having m
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/138835
The C++26 standard relocatable type traits has slightly different semantics, so
we introduced a new ``__builtin_is_cpp_trivially_relocatable`` when
implementing trivial relocation in #127636.
However, having
https://github.com/AaronBallman approved this pull request.
As far as the changes go, this LGTM. We can generalize in another PR (which
will update some parts of this patch but not enough to be worried we're wasting
effort).
https://github.com/llvm/llvm-project/pull/138519
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
tbaederr wrote:
That comment is obsolete, I've added two test cases that work
https://github.com/llvm/llvm-project/pull/138673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
> I have not added the test since I thought it might take too long, but it's
> probably not a problem since we do the check before even touching the array...
Can’t you set the eval steps to like `100` or sth to avoid it taking too long
or am I missing something here?
https://g
erichkeane wrote:
Note per our maintainership rules, we need @andykaylor and @bcardosolopes to
approve this as well to acknowledge the added responsibility.
https://github.com/llvm/llvm-project/pull/138870
___
cfe-commits mailing list
cfe-commits@list
101 - 200 of 437 matches
Mail list logo
