llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/138862.diff 2 Files Affected: - (modified) clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp (+24) - (modified) clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl (+45) ``````````diff diff --git a/clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp b/clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp index c1f9310141000..0f425d78c3332 100644 --- a/clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp +++ b/clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp @@ -133,3 +133,27 @@ void func7() { use(&x); } +#define __private __attribute__((opencl_private)) + +// CHECK-LABEL: @_Z34explicit_private_address_space_ptrv( +// CHECK-NEXT: entry: +// CHECK-NEXT: [[PLONG:%.*]] = alloca i64, align 8, addrspace(5) +// CHECK-NEXT: [[PLONGP:%.*]] = alloca ptr, align 8, addrspace(5) +// CHECK-NEXT: [[PLONGP_B:%.*]] = alloca ptr addrspace(5), align 4, addrspace(5) +// CHECK-NEXT: [[PLONG_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[PLONG]] to ptr +// CHECK-NEXT: [[PLONGP_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[PLONGP]] to ptr +// CHECK-NEXT: [[PLONGP_B_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[PLONGP_B]] to ptr +// CHECK-NEXT: store ptr [[PLONG_ASCAST]], ptr [[PLONGP_ASCAST]], align 8 +// CHECK-NEXT: [[PLONG_ASCAST_ASCAST:%.*]] = addrspacecast ptr [[PLONG_ASCAST]] to ptr addrspace(5) +// CHECK-NEXT: store ptr addrspace(5) [[PLONG_ASCAST_ASCAST]], ptr [[PLONGP_B_ASCAST]], align 4 +// CHECK-NEXT: [[TMP0:%.*]] = load ptr, ptr [[PLONGP_ASCAST]], align 8 +// CHECK-NEXT: store i64 8, ptr [[TMP0]], align 8 +// CHECK-NEXT: ret void +// +void explicit_private_address_space_ptr() { + long plong; + long *plongp = &plong; + + __private long *plongp_b = (__private long *)&plong; + *plongp = 8; +} diff --git a/clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl b/clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl index dba6519966eb5..b252f1041d68c 100644 --- a/clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl +++ b/clang/test/CodeGenOpenCL/amdgcn-automatic-variable.cl @@ -109,3 +109,48 @@ void func2(void) { void func3(void) { float a[16][1] = {{0.}}; } + +// CL12-LABEL: define dso_local void @wrong_store_type_private_pointer_alloca( +// CL12-SAME: ) #[[ATTR0]] { +// CL12-NEXT: [[ENTRY:.*:]] +// CL12-NEXT: [[PLONG:%.*]] = alloca i64, align 8, addrspace(5) +// CL12-NEXT: [[PLONGP:%.*]] = alloca ptr addrspace(5), align 4, addrspace(5) +// CL12-NEXT: [[GLONGP:%.*]] = alloca ptr addrspace(5), align 4, addrspace(5) +// CL12-NEXT: store i64 5, ptr addrspace(5) [[PLONG]], align 8 +// CL12-NEXT: store ptr addrspace(5) [[PLONG]], ptr addrspace(5) [[PLONGP]], align 4 +// CL12-NEXT: [[TMP0:%.*]] = load ptr addrspace(5), ptr addrspace(5) [[PLONGP]], align 4 +// CL12-NEXT: store i64 8, ptr addrspace(5) [[TMP0]], align 8 +// CL12-NEXT: store ptr addrspace(5) [[PLONG]], ptr addrspace(5) [[GLONGP]], align 4 +// CL12-NEXT: [[TMP1:%.*]] = load ptr addrspace(5), ptr addrspace(5) [[GLONGP]], align 4 +// CL12-NEXT: store i64 9, ptr addrspace(5) [[TMP1]], align 8 +// CL12-NEXT: ret void +// +// CL20-LABEL: define dso_local void @wrong_store_type_private_pointer_alloca( +// CL20-SAME: ) #[[ATTR0]] { +// CL20-NEXT: [[ENTRY:.*:]] +// CL20-NEXT: [[PLONG:%.*]] = alloca i64, align 8, addrspace(5) +// CL20-NEXT: [[PLONGP:%.*]] = alloca ptr addrspace(5), align 4, addrspace(5) +// CL20-NEXT: [[GLONGP:%.*]] = alloca ptr, align 8, addrspace(5) +// CL20-NEXT: [[PLONG_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[PLONG]] to ptr +// CL20-NEXT: [[PLONGP_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[PLONGP]] to ptr +// CL20-NEXT: [[GLONGP_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[GLONGP]] to ptr +// CL20-NEXT: store i64 5, ptr [[PLONG_ASCAST]], align 8 +// CL20-NEXT: store ptr [[PLONG_ASCAST]], ptr [[PLONGP_ASCAST]], align 4 +// CL20-NEXT: [[TMP0:%.*]] = load ptr addrspace(5), ptr [[PLONGP_ASCAST]], align 4 +// CL20-NEXT: store i64 8, ptr addrspace(5) [[TMP0]], align 8 +// CL20-NEXT: store ptr [[PLONG_ASCAST]], ptr [[GLONGP_ASCAST]], align 8 +// CL20-NEXT: [[TMP1:%.*]] = load ptr, ptr [[GLONGP_ASCAST]], align 8 +// CL20-NEXT: store i64 9, ptr [[TMP1]], align 8 +// CL20-NEXT: ret void +// +void wrong_store_type_private_pointer_alloca() { + long plong = 5; + + // This needs to write an addrspace(5) pointer to the temporary alloca + __private long *plongp = &plong; + *plongp = 8; + + // This needs to write an addrspace(0) pointer to the temporary alloca in CL2.0 + long *glongp = &plong; + *glongp = 9; +} `````````` </details> https://github.com/llvm/llvm-project/pull/138862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
