[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Henrich Lauko via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [llvm] [RISCV] Add Andes XAndesperf (Andes Performance) extension. (PR #135110)

2025-04-21 Thread Jim Lin via cfe-commits
@@ -0,0 +1,56 @@ +# XAndesPerf - Andes Performance Extension +# RUN: not llvm-mc -triple riscv32 -mattr=+xandesperf < %s 2>&1 \ +# RUN: | FileCheck %s +# RUN: not llvm-mc -triple riscv64 -mattr=+xandesperf < %s 2>&1 \ +# RUN: | FileCheck %s -check-prefix=CHECK-64 + +# Out

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Henrich Lauko via cfe-commits
@@ -1419,6 +1419,50 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [HLSL] Reland; Make it possible to assign an array from a cbuffer (PR #136580)

2025-04-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/136580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][counted_by] Support casting the array to a different type (PR #136239)

2025-04-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/136239 >From b656baa1efb1de934121e19539a4e3a5d4305eb5 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Thu, 17 Apr 2025 18:18:37 -0700 Subject: [PATCH 1/2] [Clang][counted_by] Support casting the array to a differ

[clang] f02b285 - [HLSL] Reland; Make it possible to assign an array from a cbuffer (#136580)

2025-04-21 Thread via cfe-commits
Author: Sarah Spall Date: 2025-04-21T10:33:06-07:00 New Revision: f02b285dbd284057d5f1dd5fb599d1c2155670f5 URL: https://github.com/llvm/llvm-project/commit/f02b285dbd284057d5f1dd5fb599d1c2155670f5 DIFF: https://github.com/llvm/llvm-project/commit/f02b285dbd284057d5f1dd5fb599d1c2155670f5.diff L

[clang] [HLSL] Reland; Make it possible to assign an array from a cbuffer (PR #136580)

2025-04-21 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/136580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] enhance loop analysis to handle variable changes inside lambdas (PR #135573)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman Should this issue ideally be resolved by CFG rather than the > current AST matcher fix? I think so. CC @gribozavr @ymand @sgatev for additional opinions https://github.com/llvm/llvm-project/pull/135573 ___ cfe-comm

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2025-04-21 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This crash looks linked to this PR: https://github.com/llvm/llvm-project/issues/136432 https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Minor nit, but LGTM otherwise https://github.com/llvm/llvm-project/pull/136578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/136578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -136,6 +154,51 @@ class OpenACCClauseCIREmitter final if (!clause.getArchitectures().empty()) operation.setDeviceType( decodeDeviceType(clause.getArchitectures()[0].getIdentifierInfo())); +} else if constexpr (isOneOfTypes) { + // Nothing

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
https://github.com/YexuanXiao updated https://github.com/llvm/llvm-project/pull/136542 >From b9cc91971469dcf19bb926f6f53ae5a57d1109c3 Mon Sep 17 00:00:00 2001 From: YexuanXiao Date: Mon, 21 Apr 2025 14:28:33 +0800 Subject: [PATCH 1/4] [Clang] Make the result type of sizeof/pointer subtraction/

[clang] [llvm] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Liao Chunyu via cfe-commits
https://github.com/ChunyuLiao created https://github.com/llvm/llvm-project/pull/136556 spec: https://github.com/riscvarchive/riscv-smcntrpmf >From 21d3c26b4ad2d4d21af7c6269845b4e3a7b30b73 Mon Sep 17 00:00:00 2001 From: Liao Chunyu Date: Mon, 21 Apr 2025 04:18:56 -0400 Subject: [PATCH] Add smcn

[clang] [llvm] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-mc Author: Liao Chunyu (ChunyuLiao) Changes spec: https://github.com/riscvarchive/riscv-smcntrpmf --- Full diff: https://github.com/llvm/llvm-project/pull/136556.diff 10 Files Affected: - (modified) clang/test/Driver

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Liao Chunyu via cfe-commits
https://github.com/ChunyuLiao edited https://github.com/llvm/llvm-project/pull/136556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > The current patch actually WILL work with it ONLY enabled on the line > > inside of the function, which I think is much more intuitive. > > Ooo whoa this is awesome!! Sorry for the confusion, I've updated the patch summary accordingly https://github.com/llvm/llvm-proje

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-21 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/136323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-21 Thread Aaron Ballman via cfe-commits
@@ -202,6 +202,43 @@ class SemaPPCallbacks : public PPCallbacks { break; } } + void PragmaDiagnostic(SourceLocation Loc, StringRef Namespace, +diag::Severity Mapping, StringRef Str) override { +// If one of the analysis-based diagnostics

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136426 >From 91a6937c7b937daceef426c877703d4d0cfeae76 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 14:22:45 +0200 Subject: [PATCH 1/2] [CIR] Upstream StackSave and StackRestoreOp --- clang/

[clang] Control analysis-based diagnostics with #pragma (PR #136323)

2025-04-21 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/136323 >From 3beecb29772e13c6a1a41877e5e8cbbfb17a88f2 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Fri, 18 Apr 2025 12:26:36 -0400 Subject: [PATCH 1/5] Control analysis-based diagnostics with #pragma Previo

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Putting aside for now the naming issue ([#136038 > (comment)](https://github.com/llvm/llvm-project/pull/136038#discussion_r2049703902)), > is there anything left for the changes proposed in this PR? Based on: > ... but I think "will this end up as an i1" is a fair summar

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `clang` at step 6 "Add check check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/21637 Here is

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/23242

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16372 Here is the relevant piece of the

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang` at step 7 "Add check check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/3846 Here is the re

[clang] [HLSL] Make it possible to assign an array from a cbuffer (PR #134174)

2025-04-21 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/18685 Here is th

[clang] [sanitizer] Fix empty string in unsupported argument error for -fsanitize-trap (PR #136549)

2025-04-21 Thread Sinkevich Artem via cfe-commits
ArtSin wrote: PTAL @vitalybuka https://github.com/llvm/llvm-project/pull/136549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Sam Elliott via cfe-commits
@@ -482,6 +482,14 @@ def : SysReg<"sctrdepth", 0x15f>; def : SysReg<"vsctrctl", 0x24e>; def : SysReg<"mctrctl", 0x34e>; +//===--- +// Cycle and Instret privilege mode filtering (Smcntrpmf) +//===--

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Sam Elliott via cfe-commits
https://github.com/lenary commented: Broadly happy, but I think two of the CSRs need to be 32-bit only, with tests. https://github.com/llvm/llvm-project/pull/136556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Younan Zhang via cfe-commits
@@ -4745,7 +4760,10 @@ Sema::CreateUnaryExprOrTypeTraitExpr(Expr *E, SourceLocation OpLoc, // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t. return new (Context) UnaryExprOrTypeTraitExpr( - ExprKind, E, Context.getSizeType(), OpLoc, E->getSourceRange()

[clang] [llvm] [RISCV] Add smcntrpmf extension (PR #136556)

2025-04-21 Thread Sam Elliott via cfe-commits
https://github.com/lenary edited https://github.com/llvm/llvm-project/pull/136556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
https://github.com/YexuanXiao updated https://github.com/llvm/llvm-project/pull/136542 >From b9cc91971469dcf19bb926f6f53ae5a57d1109c3 Mon Sep 17 00:00:00 2001 From: YexuanXiao Date: Mon, 21 Apr 2025 14:28:33 +0800 Subject: [PATCH 1/5] [Clang] Make the result type of sizeof/pointer subtraction/

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Henrich Lauko via cfe-commits
@@ -1419,6 +1419,48 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang-tools-extra] [include-cleaner] rename enabled flags to `disable-*` (PR #132991)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > If Insert or Remove is true, we should diagnose those as being deprecated > > and recommend using disable-insert or disable-remove instead. > > `Insert` and `Remove` are true by default. Should it not be as false? Oops, I meant "if they're used", so yes. :-) > Also, th

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Amr Hesham via cfe-commits
@@ -307,6 +307,26 @@ def CIR_ArrayType : CIR_Type<"Array", "array", }]; } +//===--===// +// VectorType (fixed size) +//===--===// + +def CI

[clang] [llvm] [RISCV] Add Andes XAndesperf (Andes Performance) extension. (PR #135110)

2025-04-21 Thread Jim Lin via cfe-commits
https://github.com/tclin914 updated https://github.com/llvm/llvm-project/pull/135110 >From b23dec1163f300189f1a2ce28f20c07d3cb9d5fe Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Wed, 9 Apr 2025 09:44:47 +0800 Subject: [PATCH 01/11] [RISCV] Add Andes XAndesperf (Andes Performance) extension. Th

[clang] [CIR] Upstream initial support for fixed size VectorType (PR #136488)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/136488 >From 5d07a639dc6c933f6f171e501e4ec20d731553e3 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 19 Apr 2025 21:03:07 +0200 Subject: [PATCH 1/3] [CIR] Upstream initial support for fixed size VectorType

[clang] [llvm] [RISCV] Add Andes XAndesperf (Andes Performance) extension. (PR #135110)

2025-04-21 Thread Jim Lin via cfe-commits
tclin914 wrote: Rebased https://github.com/llvm/llvm-project/pull/135110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Erich Keane via cfe-commits
erichkeane wrote: > > > Thank you for this! > > > I'd like to better understand the need for the changes because I have a > > > few concerns. One concern is about compile time performance. But also, > > > this means downstream consumers of the AST are going to have to react > > > because they

[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Oleksandr T. via cfe-commits
@@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs, case tok::kw_extern: if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) { + ProhibitAttributes(Attrs); a-tarasyuk wrote: @AaronBallman @erichkeane thanks

[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/136328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Thank you for this! > > I'd like to better understand the need for the changes because I have a few > > concerns. One concern is about compile time performance. But also, this > > means downstream consumers of the AST are going to have to react because > > they used to

[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I think we're ok with this now, LGTM. https://github.com/llvm/llvm-project/pull/136328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [llvm] [DirectX] add Function name to DiagnosticInfoUnsupported Msg in DXILOpLowering (PR #136234)

2025-04-21 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/136234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix addrspace of global constants (PR #134399)

2025-04-21 Thread Nick Sarnie via cfe-commits
sarnex wrote: Investigating now, thanks! https://github.com/llvm/llvm-project/pull/134399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Erich Keane via cfe-commits
erichkeane wrote: TO ADD: see uses of `buildImplicitTypedef` for times we do basically the same thing. https://github.com/llvm/llvm-project/pull/136542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] 111af76 - [DirectX] add Function name to DiagnosticInfoUnsupported Msg in DXILOpLowering (#136234)

2025-04-21 Thread via cfe-commits
Author: Farzon Lotfi Date: 2025-04-21T10:26:27-04:00 New Revision: 111af76bd74708929a048f94ef5c52af646f1c64 URL: https://github.com/llvm/llvm-project/commit/111af76bd74708929a048f94ef5c52af646f1c64 DIFF: https://github.com/llvm/llvm-project/commit/111af76bd74708929a048f94ef5c52af646f1c64.diff

[clang] [llvm] [DirectX] add Function name to DiagnosticInfoUnsupported Msg in DXILOpLowering (PR #136234)

2025-04-21 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/136234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -136,6 +154,51 @@ class OpenACCClauseCIREmitter final if (!clause.getArchitectures().empty()) operation.setDeviceType( decodeDeviceType(clause.getArchitectures()[0].getIdentifierInfo())); +} else if constexpr (isOneOfTypes) { + // Nothing

[clang] Reorganize -Winitializer-overrides and -Wreorder-init-list (PR #136586)

2025-04-21 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/136586 These are both now grouped under -Wc99-designator as they both relate to the C99 feature as it was introduced into C++20. Fixes #47037 >From 49dcc67a3a448a3339c40ffb8b0fe58489e7554a Mon Sep 17 00:00:00 20

[clang] Reorganize -Winitializer-overrides and -Wreorder-init-list (PR #136586)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes These are both now grouped under -Wc99-designator as they both relate to the C99 feature as it was introduced into C++20. Fixes #47037 --- Full diff: https://github.com/llvm/llvm-project/pull/136586.d

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1310,6 +1310,70 @@ def GetGlobalOp : CIR_Op<"get_global", let hasVerifier = 0; } +//===--===// +// GetMemberOp +//===--===// + +def Get

[clang] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels (PR #136578)

2025-04-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/136578 >From e12a5016b203446d68019b4f18c19573b481aef7 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Wed, 16 Apr 2025 08:33:35 -0700 Subject: [PATCH 1/2] [OpenACC][CIR] Lower 'num_workers' for parallel/kernels Thi

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
@@ -309,6 +309,37 @@ RecordType::computeStructAlignment(const mlir::DataLayout &dataLayout) const { return recordAlignment; } +uint64_t RecordType::getElementOffset(const ::mlir::DataLayout &dataLayout, + unsigned idx) const { + assert(

[clang] [CIR] Upstream support for accessing structure members (PR #136383)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM pending discussion/comments https://github.com/llvm/llvm-project/pull/136383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [CIR] Introduce type aliases for records (PR #136387)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: > I question stealing ty as the prefix to this instead of rt (or something more > specific to records), but I'm not sure I feel particularly strongly. Just it > seems that ty is going to be pretty meaningless perhaps? Good point, `rec` or `rt` probably make more sense. I'm

[clang] [CIR] Introduce type aliases for records (PR #136387)

2025-04-21 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM pending `ty_anon` test mentioned by Erich https://github.com/llvm/llvm-project/pull/136387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] Reorganize -Winitializer-overrides and -Wreorder-init-list (PR #136586)

2025-04-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/136586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable making `CompilerInstance` VFS thread-safe (PR #135737)

2025-04-21 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida approved this pull request. https://github.com/llvm/llvm-project/pull/135737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Boolean in a RawBuffer should be i32 and Boolean vector in a RawBuffer should be (PR #135848)

2025-04-21 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/135848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for GCC bound member functions extension (PR #135649)

2025-04-21 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Not sure if anyone has mentioned this elsewhere, but there's a significant problem with the type of the returned function pointer: a normal function pointer doesn't necessarily have the correct calling convention. In practice, this is likely to cause problems on Windows.

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-21 Thread via cfe-commits
https://github.com/apple-fcloutier edited https://github.com/llvm/llvm-project/pull/135864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Suppress gnu-line-marker when saving temps (PR #134621)

2025-04-21 Thread via cfe-commits
macurtis-amd wrote: @MaskRay Any other concerns with this change? https://github.com/llvm/llvm-project/pull/134621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SROA] Vector promote some memsets (PR #133301)

2025-04-21 Thread via cfe-commits
macurtis-amd wrote: @nikic Latest revision only promotes memsets where the region being set is within an existing vector in the underlying alloca (as determined by getTypePartition). It is much more constrained as you can see by the much smaller number of tests that are now affected, while st

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/136604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko ready_for_review https://github.com/llvm/llvm-project/pull/136604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Henrich Lauko (xlauko) Changes This mirrors incubator changes from https://github.com/llvm/clangir/pull/1576 --- Full diff: https://github.com/llvm/llvm-project/pull/136604.diff 3 Files Affected: - (modified) clang/include/clang/CIR/D

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) Changes This mirrors incubator changes from https://github.com/llvm/clangir/pull/1576 --- Full diff: https://github.com/llvm/llvm-project/pull/136604.diff 3 Files Affected: - (modified) clang/include/clang/CIR/Dia

[clang] [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (PR #136133)

2025-04-21 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,35 @@ +// libstdc++ uses the non-constexpr function std::__glibcxx_assert_fail() +// to trigger compilation errors when the __glibcxx_assert(cond) macro +// is used in a constexpr context. +// Compilation fails when using code from the libstdc++ (such as std::array) on

[clang] [Clang][MicrosoftMangle] Implement mangling for ConstantMatrixType (PR #134930)

2025-04-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks, looks good to me! I wanted to add llvm-cxxfilt to the test to confirm these all demnagle to something readable, but I see it doesn't work on Microsoft symbols today, which is unfortunate. The code I want is on github in @nico's https:

[clang-tools-extra] Add bugprone-uninitialized-thread-local to detect when thread-locals might be accessed without initialization (PR #136602)

2025-04-21 Thread via cfe-commits
https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/136602 This is to partially address issue #112782. >From f86372ac92bda26a99bf0b17acd226d677853a47 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 21 Apr 2025 16:09:44 -0400 Subject: [PATCH] Add

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-21 Thread via cfe-commits
@@ -3,6 +3,11 @@ // RUN: %clang_cc1 -fblocks -fsyntax-only -verify -Wformat-nonliteral -isystem %S/Inputs -triple=x86_64-unknown-fuchsia %s // RUN: %clang_cc1 -fblocks -fsyntax-only -verify -Wformat-nonliteral -isystem %S/Inputs -triple=x86_64-linux-android %s +// expected-n

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/136604 None >From 21dc57c1b7d45f1a8ae014ae0360a86fa31562d6 Mon Sep 17 00:00:00 2001 From: xlauko Date: Mon, 21 Apr 2025 21:51:06 +0200 Subject: [PATCH] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext --- clang

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread Henrich Lauko via cfe-commits
xlauko wrote: * **#136606** https://app.graphite.dev/github/pr/llvm/llvm-project/136606?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> * **#136605** https://app.graphite.dev/github/pr/llvm/llvm-p

[clang] [clang] Enable making `CompilerInstance` diagnostics thread-safe (PR #136601)

2025-04-21 Thread Cyndy Ishida via cfe-commits
@@ -861,9 +864,13 @@ class CompilerInstance : public ModuleLoader { /// /// Explicitly-specified \c VFS takes precedence over the VFS of this instance /// when creating the clone and also prevents \c FileManager sharing. - std::unique_ptr cloneForModuleCompile( - S

[clang] [clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms (PR #128222)

2025-04-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks, I think this is a good direction. https://github.com/llvm/llvm-project/pull/128222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms (PR #128222)

2025-04-21 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/128222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/5] [clang] add -fimplicit-constexpr

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes * Report when lookupModuleFile fails and there's an alternate module file to use In an explicit build, the dependency scanner generates invocations with dependencies to module files to use during compila

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-21 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Cyndy Ishida (cyndyishida) Changes * Report when lookupModuleFile fails and there's an alternate module file to use In an explicit build, the dependency scanner generates invocations with dependencies to module files to use during

[clang] [clang][modules] Minor improvements to diagnosing `out of date` errors (PR #136612)

2025-04-21 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/136612 * Report when lookupModuleFile fails and there's an alternate module file to use In an explicit build, the dependency scanner generates invocations with dependencies to module files to use during compilatio

[clang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-04-21 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I don't think it makes sense to have a target-specific "verifier": verification sets the limits of what optimizations are allowed to do. And that determination needs to be target-independent, or else target-independent optimizations can't exist. Target-specific intrinsic

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/5] [clang] add -fimplicit-constexpr

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/4] [clang] add -fimplicit-constexpr

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-21 Thread Artem Belevich via cfe-commits
@@ -25,6 +25,7 @@ enum AddressSpace : unsigned { ADDRESS_SPACE_CONST = 4, ADDRESS_SPACE_LOCAL = 5, ADDRESS_SPACE_TENSOR = 6, + ADDRESS_SPACE_SHARED_CLUSTER = 7, Artem-B wrote: PTX docs say: ``` If no sub-qualifier is specified with the .shared state sp

[clang] [clang] add `-fimplicit-constexpr` flag (PR #136436)

2025-04-21 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/136436 From f37eb75b71d2aa6433bc528b7b4532138ae4e62a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 20 Apr 2025 00:24:46 +0200 Subject: [PATCH 1/5] [clang] add -fimplicit-constexpr

[clang] [clang] Enable making `CompilerInstance` diagnostics thread-safe (PR #136601)

2025-04-21 Thread Jan Svoboda via cfe-commits
@@ -861,9 +864,13 @@ class CompilerInstance : public ModuleLoader { /// /// Explicitly-specified \c VFS takes precedence over the VFS of this instance /// when creating the clone and also prevents \c FileManager sharing. - std::unique_ptr cloneForModuleCompile( - S

[clang] [CIR] Make ZeroAttr use AttrBuilderWithInferredContext (PR #136604)

2025-04-21 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/136604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2025-04-21 Thread Shafik Yaghmour via cfe-commits
@@ -9278,6 +9278,8 @@ def err_cast_pointer_to_non_pointer_int : Error< def err_nullptr_cast : Error< "cannot cast an object of type %select{'nullptr_t' to %1|%1 to 'nullptr_t'}0" >; +def err_invalid_implicit_floating_point_cast : Error< shafik wrote: I don't

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Balazs Benics via cfe-commits
@@ -320,22 +320,6 @@ void test_buf_size_concrete_with_multiplication(void) { // bugpath-warning{{The 1st argument to '__buf_size_arg_constraint_mul' is a buffer with size 6 but should be a buffer with size equal to or greater than the value of the 2nd argument (which is 4) ti

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
@@ -320,22 +320,6 @@ void test_buf_size_concrete_with_multiplication(void) { // bugpath-warning{{The 1st argument to '__buf_size_arg_constraint_mul' is a buffer with size 6 but should be a buffer with size equal to or greater than the value of the 2nd argument (which is 4) ti

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
@@ -4745,7 +4760,10 @@ Sema::CreateUnaryExprOrTypeTraitExpr(Expr *E, SourceLocation OpLoc, // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t. return new (Context) UnaryExprOrTypeTraitExpr( - ExprKind, E, Context.getSizeType(), OpLoc, E->getSourceRange()

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
@@ -4026,10 +4026,20 @@ ExprResult Sema::ActOnNumericConstant(const Token &Tok, Scope *UDLScope) { // Does it fit in size_t? if (ResultVal.isIntN(SizeTSize)) { // Does it fit in ssize_t? - if (!Literal.isUnsigned && ResultVal[SizeTSize - 1] =

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
@@ -1419,6 +1419,48 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { }]>]; } +//===--===// +// StackSave & StackRestoreOp +//===---

[clang] [CIR] Upstream StackSave and StackRestoreOp (PR #136426)

2025-04-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/136426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread via cfe-commits
https://github.com/YexuanXiao updated https://github.com/llvm/llvm-project/pull/136542 >From b9cc91971469dcf19bb926f6f53ae5a57d1109c3 Mon Sep 17 00:00:00 2001 From: YexuanXiao Date: Mon, 21 Apr 2025 14:28:33 +0800 Subject: [PATCH 1/8] [Clang] Make the result type of sizeof/pointer subtraction/

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t lit… (PR #136542)

2025-04-21 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for this! I'd like to better understand the need for the changes because I have a few concerns. One concern is about compile time performance. But also, this means downstream consumers of the AST are going to have to react because they used

[clang] [clang-tools-extra] Reapply 19c708c "FunctionDecl::getFunctionTypeLoc: ignore function type attributes (#118420)" (PR #136484)

2025-04-21 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/136484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow use of attributes before extern template declarations (PR #136328)

2025-04-21 Thread Erich Keane via cfe-commits
@@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs, case tok::kw_extern: if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) { + ProhibitAttributes(Attrs); erichkeane wrote: > I think it's reasonable to reje

<    1   2   3   4   >