https://github.com/AaronBallman commented:

Thank you for this!

I'd like to better understand the need for the changes because I have a few 
concerns. One concern is about compile time performance. But also, this means 
downstream consumers of the AST are going to have to react because they used to 
be able to look for a `size_t` node directly and now they have to resolve a 
qualified type instead. This may be acceptable, but it seems disruptive too.

Also, there should be more test coverage for the changes showing that we 
actually do get the types correct in all the various circumstances.

https://github.com/llvm/llvm-project/pull/136542
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to