[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan , Thanks for letting me know the process and please help me in commiting this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clan

[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

aaron.ballman added a comment. I am wrestling with this one because I think the status quo is unfortunate (we silently drop relevant information in ways the user may not immediately understand) but I think always printing the include stack could be verbose and thus make the diagnostics harder t

[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:135 +} +// For refs to member-like decls, report an implicit ref to the container. +if (au

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. It indeed makes sense to pass these by reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D1585

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552390. victorkingi added a comment. Removed mframe_pointer_eq update in Options.td, not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/

[PATCH] D158348: [clang][X86] Add __cpuidex function to cpuid.h

aaron.ballman added a subscriber: eandrews. aaron.ballman added a comment. @eandrews tested this patch out internally at Intel and it seems to work well for us (didn't break the internal tests that we had troubles with before). I think the changes here look reasonable, but I leave it to the orig

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. In D158522#4607054 , @sdesmalen wrote: > It indeed makes sense to pass these by reference. Thank you @sdesmalen for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Given Richard's comments, it seems that changes are needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372 ___

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * Making a thread out of this: > The relationship between clang's stddef.h and the C Standard Library stdde

[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

kadircet updated this revision to Diff 552391. kadircet added a comment. - Add test for using enums - Drop implicit references from qualified names to their containers, as we should already have explicit references from the spelling of the qualifier. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D158515: [include-cleaner] Make handling of enum constants similar to members

kadircet updated this revision to Diff 552392. kadircet added a comment. - Change to c++20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158515/new/ https://reviews.llvm.org/D158515 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp clan

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

nickdesaulniers added a comment. Drive by code review!!! Comment at: clang/lib/AST/Decl.cpp:4541-4544 +bool FieldDecl::isFlexibleArrayMemberLike( +ASTContext &Ctx, +LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel, +bool IgnoreTemplateOrMacroSubstitution

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Lex/PPDirectives.cpp:494 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); --

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

nickdesaulniers added inline comments. Comment at: clang/lib/AST/Decl.cpp:4541-4544 +bool FieldDecl::isFlexibleArrayMemberLike( +ASTContext &Ctx, +LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel, +bool IgnoreTemplateOrMacroSubstitution) const { --

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 552401. jp4a50 added a comment. Minor refactoring and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/lib/Format/ContinuationIndenter.cpp cl

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a nicer way to suppress the diagnostic instead of using the pre-processor wo

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 552403. jp4a50 added a comment. Minor refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Format/C

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 marked 4 inline comments as done. jp4a50 added a comment. Addressed all comments. Please let me know if there's anything else required before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D15625

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use member's type when printing. This also fixes a bug in warning diagnostic for out of order initialization with design

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 552411. skatrak marked an inline comment as done. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/

[PATCH] D157879: [clang] Report missing designated initializers in C++

aeubanks added a comment. In D157879#4606531 , @aaron.ballman wrote: > In D157879#4604288 , @phosek wrote: > >> Note that there's an ongoing discussion on the GCC bug >> https://gcc.gnu.org/bugzilla/show_bug.cgi

[clang] 08f034f - [clang][ExtractAPI] Add support for namespaces

Author: Erick Velez Date: 2023-08-22T09:56:34-07:00 New Revision: 08f034f952fa67fc379df4caee2904de466a69f9 URL: https://github.com/llvm/llvm-project/commit/08f034f952fa67fc379df4caee2904de466a69f9 DIFF: https://github.com/llvm/llvm-project/commit/08f034f952fa67fc379df4caee2904de466a69f9.diff L

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f034f952fa: [clang][ExtractAPI] Add support for namespaces (authored by evelez7). Changed prior to commit: https://reviews.llvm.org/D158239?vs=5

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

xazax.hun added a comment. In D156658#4606400 , @mboehme wrote: > We only do widening at loop heads, and this means that widening only affects > locations and values that flow into the loop from the outside or from a > previous loop iteration. > > But c

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet updated this revision to Diff 552417. hazohelet added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fixed clangd test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158472/new/ https://reviews.llvm.org/D158472 Files: clang-tools-e

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 552418. capfredf edited the summary of this revision. capfredf added a comment. update the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: cl

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added a comment. > I expected the answer would be "yes", so I said "lgtm" and then phrased my > question very awkwardly. Ah, thanks for the clarification! Any opinion on the name, `-fno-autoimport` vs `-fno-auto-import`, given the existing linker option `--disable-auto-import`? Repo

[PATCH] D155858: Add a concept AST node.

erichkeane added a comment. So I did a quick run through, I think this is a fine idea and an improvement. However, @sammccall has given some very good feedback that I'd like to have him do the final approval. Comment at: clang/include/clang/AST/ASTConcept.h:213 Expr *Imme

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

shafik added a comment. Thank you for this fix, it is a lot cleaner than I was expecting. Comment at: clang/include/clang/AST/Decl.h:3186 + + void printName(raw_ostream &OS, const PrintingPolicy &Policy) const override; }; So it looks like w/o this we would e

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dexonsmith added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

dpaoliello added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:555-557 +def CSR_Win_AArch64_Arm64EC_Thunk : CalleeSavedRegs<(add X19, X20, X21, X22, X23, X24, + X25, X26, X27, X28, FP, LR

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao added a comment. OK, will do it by the end of this week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 552427. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOp

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna updated this revision to Diff 552428. Manna added a comment. Fix build errors. I have updated CodeGenFunction.h as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGen

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: > aeuban

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; ellis wrote: > aeuban

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza created this revision. lukasza added a reviewer: gribozavr2. lukasza added a project: clang. Herald added a subscriber: mstorsjo. Herald added a project: All. lukasza requested review of this revision. Herald added a subscriber: cfe-commits. This is a reland of https://reviews.llvm.org/D15

[PATCH] D158532: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

lukasza added a comment. The delta from https://reviews.llvm.org/D155895 is in `clang/test/SemaCXX/attr-trivial-abi.cpp` where 1) a comment has been added above the non-trivial move constructor of the `Trivial` test helper and 2) test expectations have been tweaked to account for `_WIN64` and `

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * ldionne wrote: > Making a thread out of this: > > > The relationship between clang's stddef.h and t

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

hans added a comment. Given the concerns raised (the PRIuS one in https://godbolt.org/z/v3boc9E6T seems like a good example), and that the fix in D158372 doesn't seem straight-forward, could this be reverted to unbreak things until a revised version is ready?

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + -

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

tahonermann accepted this revision. tahonermann added a comment. Looks fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. In D158522#4607628 , @tahonermann wrote: > Looks fine to me! Thanks @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 _

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:555-557 +def CSR_Win_AArch64_Arm64EC_Thunk : CalleeSavedRegs<(add X19, X20, X21, X22, X23, X24, + X25, X26, X27, X28, FP, LR,

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * aaron.ballman wrote: > ldionne wrote: > > Making a thread out of this: > > > > > The relationship between cl

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

aaron.ballman added a comment. In D153156#4607576 , @hans wrote: > Given the concerns raised (the PRIuS one in https://godbolt.org/z/v3boc9E6T > seems like a good example), and that the fix in D158372 > doesn't seem st

[PATCH] D157497: feat: Migrate isArch16Bit

bulbazord requested changes to this revision. bulbazord added a comment. In D157497#4592330 , @Pivnoy wrote: > At the moment, the TargetParser architecture is extensible. This complicates > the addition of new architectures, operating systems, and so on.

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

hans added a comment. In D153156#4607655 , @aaron.ballman wrote: > I agree this should be reverted from 17.x so we have more time to consider an > appropriate path forward. Supporting evidence that this will likely be > disruptive: > https://sourcegra

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya created this revision. hiraditya added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For fat binaries t

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + -

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

PiotrZSL added a comment. 626849c71e85d546a004cc91866beab610222194 didn't fix this issue already ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158534/new/ https://reviews.llv

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

aaron.ballman added a comment. In D153156#4607671 , @hans wrote: > In D153156#4607655 , @aaron.ballman > wrote: > >> I agree this should be reverted from 17.x so we have more time to consider >> an appropriate p

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

Manna added a comment. This has already been addressed by https://reviews.llvm.org/D157989 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4607027 , @hchilama wrote: > Hi @abhina.sreeskantharajan , Thanks for letting me know the process and > please help me in commiting this patch. I'd like to put your name and email as the commit's autho

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 created this revision. jyu2 added reviewers: rnk, rsmith, majnemer, cfe-commits. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. Currently, for MS, the linkage for the inheriting constructors is set to internal. However, the comdat attribute

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Please use my Intel email Chilamantula, Harini . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list cfe-com

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

HazardyKnusperkeks added a comment. In D158363#4606159 , @d0nc1h0t wrote: > In D158363#4604468 , > @HazardyKnusperkeks wrote: > >> Please upload the patch with the full context. > > I'm creating a patch via 'git

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4561620 , @v.g.vassilev wrote: > So, in that case we should bring back the boolean flag for incremental > processing and keep the `IncrementalExtensions` LanguageOption separate. In > that case `IncrementalExtension

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c8f16fc32c: Fixing the memory leak using split() instead of strtok (authored by hchilama, committed by abhina.sreeskantharajan). Repository: rG

[clang] c3c8f16 - Fixing the memory leak using split() instead of strtok

Author: Harini Chilamantula Date: 2023-08-22T15:26:34-04:00 New Revision: c3c8f16fc32cccf5239a2aedd10c6be9babf2945 URL: https://github.com/llvm/llvm-project/commit/c3c8f16fc32cccf5239a2aedd10c6be9babf2945 DIFF: https://github.com/llvm/llvm-project/commit/c3c8f16fc32cccf5239a2aedd10c6be9babf2945

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 created this revision. NoumanAmir657 added a reviewer: CornedBee. Herald added a project: All. NoumanAmir657 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The changes are for better diagnostic/error-messages. The error messa

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

schittir abandoned this revision. schittir added a comment. In D158488#4607754 , @Manna wrote: > This has already been addressed by https://reviews.llvm.org/D157989 Thank you for letting me know. Abandoning this change. CHANGES SINCE LAST ACTION http

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

MitalAshok updated this revision to Diff 552477. MitalAshok added a comment. Address comments; better implementation for elision (check after considering only initializer list constructors) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156032/new/

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dexonsmith added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

NoQ added a comment. In D157441#4575220 , @ziqingluo-90 wrote: >>> Extend PointerAssignmentGadget and PointerInitGadget to generate fix-its >>> for cases where the left-hand side >>> has won't fix strategy and the right-hand side has std::span strategy

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay added a comment. In D157933#4591627 , @ABataev wrote: > Could you also add the nesting tests for outer scope directive? Currently it > tests only for inner Added. Please take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15793

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Please, update docs/OpenMPSupport.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 ___

[PATCH] D157565: [CodeGen] Add AArch64 behavior to existing MFS tests

dhoekwater marked an inline comment as done. dhoekwater added a comment. Relanded in 90ab85a1b2e72f63039fadf6669b23f52192defd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157565

[clang] f2b150b - Summary:

Author: zhijian Date: 2023-08-22T16:29:22-04:00 New Revision: f2b150b4501ff8978ce19b0727225a6817be1dc7 URL: https://github.com/llvm/llvm-project/commit/f2b150b4501ff8978ce19b0727225a6817be1dc7 DIFF: https://github.com/llvm/llvm-project/commit/f2b150b4501ff8978ce19b0727225a6817be1dc7.diff LOG:

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9512 uint64_t TSize = Info.Ctx.getTypeSizeInChars(T).getQuantity(); +if (TSize == 0) + return false; I think we should issue a diagnostic, we don't have any indication that thi

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

erjin updated this revision to Diff 552498. erjin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 Files: clang/include/clang/Driver/Options.td flang/test/Driver/misc-flags.f90

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

evelez7 updated this revision to Diff 552504. evelez7 added a comment. Use clang instead of clang_cc1 like other C tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158474/new/ https://reviews.llvm.org/D158474 Files: clang/include/clang/Extra

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146 +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { + PROF_ERR("%s\n", "Missing profile data section."); + return 1; aeubanks wrote: > ell

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, davide, rsmith. Herald added a project: All. shafik requested review of this revision. The implementation of `__builtin_strncmp` and other related builtins function use `getExtValue()` to evaluate the size argument.

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane added a comment. Are there any Sema tests we can add to show that we warn/diagnose/SOMETHING on these? If someone passes a negative size, we should probably at least do the warning that it was converted/truncated. Comment at: clang/lib/AST/ExprConstant.cpp:9357

[clang] 9b6b6bb - Revert "[Profile] Allow online merging with debug info correlation."

Author: Arthur Eubanks Date: 2023-08-22T14:34:46-07:00 New Revision: 9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd URL: https://github.com/llvm/llvm-project/commit/9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd DIFF: https://github.com/llvm/llvm-project/commit/9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd.diff

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a side effect, introduce AtomicExpr::getOpAsString

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. reverted in 9b6b6bbc9127d604881cdc9dcea0e7c74ef821fd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

hiraditya abandoned this revision. hiraditya added a comment. In D158534#4607719 , @PiotrZSL wrote: > 626849c71e85d546a004cc91866beab610222194 > didn't > fix this issue already ? ah

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

dblaikie added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TN

[PATCH] D157385: [clang][CFG] Cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1480 +public: + ~F() {} +}; tbaeder wrote: > aaronpuchert wrote: > > As with the cleanup function, a definition shouldn't be necessary. > Is there a way to test whether the

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 created this revision. ivanrodriguez3753 added a reviewer: OpenMP. Herald added subscribers: pengfei, guansong, tpr, yaxunl. Herald added a project: All. ivanrodriguez3753 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits,

[clang] e817445 - [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

Author: Erick Velez Date: 2023-08-22T15:00:14-07:00 New Revision: e81744563a53b1ed0aaa2cefda885287974a9e21 URL: https://github.com/llvm/llvm-project/commit/e81744563a53b1ed0aaa2cefda885287974a9e21 DIFF: https://github.com/llvm/llvm-project/commit/e81744563a53b1ed0aaa2cefda885287974a9e21.diff L

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81744563a53: [clang][ExtractAPI] Fix bool spelling coming from the macro definition. (authored by evelez7). Repository: rG LLVM Github Monorepo

[clang] 0d592c8 - [Driver][PS5] Simplify a condition

Author: Paul Robinson Date: 2023-08-22T15:01:55-07:00 New Revision: 0d592c8d49bc734e3807bd7093f61e634e8194cf URL: https://github.com/llvm/llvm-project/commit/0d592c8d49bc734e3807bd7093f61e634e8194cf DIFF: https://github.com/llvm/llvm-project/commit/0d592c8d49bc734e3807bd7093f61e634e8194cf.diff

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 552516. shafik added a comment. - Diff w/ context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-string.cpp Index: clang/test/SemaCX

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik updated this revision to Diff 552518. shafik added a comment. -Updated values used in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-string.cpp Index: clang/

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

shafik added a comment. In D158557#4608262 , @erichkeane wrote: > Are there any Sema tests we can add to show that we warn/diagnose/SOMETHING > on these? If someone passes a negative size, we should probably at least do > the warning that it was conve

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ABataev added a comment. 1. Always provide full context in the patch. 2. It looks like we're counting the pointer size (or the size of just the first element of the array), because we do not account array section here, either just the pointer or the first element only (most probably second opti

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. In D158559#4608388 , @ABataev wrote: > 1. Always provide full context in the patch. Sure, would you mind mentioning what's missing? Or do you mean the stuff from debug output being shortened, as well as LLVM IR being o

[PATCH] D158559: [OpenMP] WIP: Attempt to fix clang frontend codegen issue

ivanrodriguez3753 added a comment. Also, should the underlying issue and test case be filed as an issue on Github? I wasn't sure since this revision includes the bug and a description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158559/new/ https

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The debug note for an unclaimed DRE highlight

[PATCH] D158476: [driver] Search for compatible Android runtime directories

thakis added a comment. I think this is a useful feature, for the reasons mentioned on the thread. Since this is a superset of D115049 (... right?), this should probably revert the changes over there? Maybe we should dump searched paths in `-v` mode? Reposit

<    1   2   3   >