aaron.ballman added a comment. In D153156#4607671 <https://reviews.llvm.org/D153156#4607671>, @hans wrote:
> In D153156#4607655 <https://reviews.llvm.org/D153156#4607655>, @aaron.ballman > wrote: > >> I agree this should be reverted from 17.x so we have more time to consider >> an appropriate path forward. Supporting evidence that this will likely be >> disruptive: >> https://sourcegraph.com/search?q=context:global+%5E%28%22%5B%5E%22%5D%2B%22PRI.*%29%24+lang:C%2B%2B+-file:.*test.*&patternType=regexp&case=yes&sm=0&groupBy=repo > > I don't believe this is on 17.x. I'm suggesting reverting to green on trunk. Heh, review fatigue caught me; I even mentioned on this review that it should not go into 17.x so we get more bake time with it! Sorry for that. I think it is beneficial for us to get more feedback on problems caused by the changes, in case they help us decide how we want to move forward solving them. However, if the changes on trunk are sufficiently disruptive that we probably won't get more (novel) feedback anyway, then I think a revert is reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/ https://reviews.llvm.org/D153156 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
