aeubanks added inline comments.
================
Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:146
+ if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) {
+ PROF_ERR("%s\n", "Missing profile data section.");
+ return 1;
----------------
ellis wrote:
> aeubanks wrote:
> > aeubanks wrote:
> > > we're running into this error message even though we don't have debug
> > > info correlation turned on, is that expected in some configurations? I'm
> > > still trying to understand how we could end up in this code path without
> > > debug info correlation
> > >
> > > https://crbug.com/1473935
> > also it seems like this code path isn't tested?
> It's very strange that you are hitting this code path because I didn't think
> it was possible. Were you ever able to reproduce locally?
no, it's only showed up on some bots (both mac and linux), I'm still trying to
understand what's going on
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157632/new/
https://reviews.llvm.org/D157632
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
