[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 529515. kushanam added a comment. updating the bf16 resigter types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.d

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 529517. Sedeniono added a comment. Reformatted comment as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/Unwrapp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDirective && Line.Level < IndentForLevel.size()) +I

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// e

[PATCH] D149548: [IR] Update to use new shufflevector semantics

qiucf added subscribers: jonpa, uweigand. qiucf added a comment. Why this changes IR output of following case? // RUN: clang vecpromote.c -S -o - -O0 -target s390x-linux-gnu -fzvector -emit-llvm #include vector int si; int g; int i; void foo() { si = vec_promote(g, i); }

[PATCH] D142932: Multilib YAML parsing

phosek accepted this revision. phosek added a comment. In D142932#4402981 , @michaelplatings wrote: > @phosek thanks for your suggestion, that's now implemented. In practise for > LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I

[clang] d3d5cdb - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-06-08T10:01:28+02:00 New Revision: d3d5cdbfa8a9f2838531466d321feb82f3c08b9d URL: https://github.com/llvm/llvm-project/commit/d3d5cdbfa8a9f2838531466d321feb82f3c08b9d DIFF: https://github.com/llvm/llvm-project/commit/d3d5cdbfa8a9f2838531466d321feb82f3c08b9d.diff

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks! Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Negate defines whether the flag is negated and therefore disallowed. + MultilibBuilder &fl

[PATCH] D143075: BareMetal ToolChain multilib layering

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:236-240 + if (!SelectedMultilibs.empty()) { +return llvm::iterator_range< +llvm::SmallVector::const_reverse_iterator>( +SelectedMultilibs.rbegi

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal added a comment. Okay. I think we are aligned. I'm still uncomfortable sacrificing reports for fast pace development. IMO if that is the goal, then a brand new alpha checker is the way forward. You can be sure that no external users depend on it as its brand new. Unlike with this V2 ch

[clang] a1e5430 - [clang] Fix consteval operators in template contexts

Author: Mariya Podchishchaeva Date: 2023-06-08T04:26:45-04:00 New Revision: a1e5430b6adfe0fe19d831ab719fbec05b2cf5b7 URL: https://github.com/llvm/llvm-project/commit/a1e5430b6adfe0fe19d831ab719fbec05b2cf5b7 DIFF: https://github.com/llvm/llvm-project/commit/a1e5430b6adfe0fe19d831ab719fbec05b2cf5

[PATCH] D151553: [clang] Fix consteval operators in template contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1e5430b6adf: [clang] Fix consteval operators in template contexts (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https:

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings updated this revision to Diff 529530. michaelplatings marked an inline comment as done. michaelplatings added a comment. Negate->Disallow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152353/new/ https://reviews.llvm.org/D152353 Fi

[PATCH] D152429: [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

eopXD created this revision. eopXD added reviewers: craig.topper, aaron.ballman, erichkeane. Herald added a project: All. eopXD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Recent expansion D152070 exce

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 529532. koops added a comment. 1. Taken care of Alexy's comments. 2. Reverting back changes to StmtPrinter.cpp because state of AST needs to be shown as is to the developer of clang when -ast-print/-ast-dump is used. This also meant some changes to the test ca

[clang] b4507dc - [NFC][Driver] Change MultilibBuilder flags argument order

Author: Michael Platings Date: 2023-06-08T10:02:52+01:00 New Revision: b4507dcaeafcbd24ce793084d22d8189af685058 URL: https://github.com/llvm/llvm-project/commit/b4507dcaeafcbd24ce793084d22d8189af685058 DIFF: https://github.com/llvm/llvm-project/commit/b4507dcaeafcbd24ce793084d22d8189af685058.di

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4507dcaeafc: [NFC][Driver] Change MultilibBuilder flags argument order (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152418: [clang] set python3 as required build dependency

Avimitin added a comment. I can't commit this change myself, please help me commit this, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/ https://reviews.llvm.org/D152418 ___ cfe-comm

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

simon_tatham created this revision. simon_tatham added reviewers: nickdesaulniers, peter.smith, kristof.beyls, t.p.northover, rengolin. Herald added a subscriber: hiraditya. Herald added a project: All. simon_tatham requested review of this revision. Herald added subscribers: llvm-commits, cfe-com

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529551. vikramRH added a comment. Reafactored non string arg handling into a seperate function with additional asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D15042

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

rengolin added a comment. The only minor visible difference is the removal of `read-tp-hard` option from the LLVM side, which could be used by other downstream implementations. I personally don't think this is a big deal. First, we don't promise stability on that layer, and second, it would be

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

simon_tatham added a comment. In D152433#4405428 , @rengolin wrote: > The only minor visible difference is the removal of `read-tp-hard` option > from the LLVM side, which could be used by other downstream implementations. Yes. I wasn't sure how much th

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 updated this revision to Diff 529556. MineGame159 added a comment. Implemented requested changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150910/new/ https://reviews.llvm.org/D150910 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h clang/include/c

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 updated this revision to Diff 529557. jhuber6 added a comment. Add a better test to show that attributes are replaced and default attributes are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// equal or lower levels. This is used to ali

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

aaron.ballman added subscribers: jansvoboda11, MaskRay. aaron.ballman added a comment. Herald added a subscriber: bd1976llvm. These changes LGTM, thank you! @MaskRay, @jansvoboda11 -- I think we need to figure out a better strategy for documenting compiler options. We have documentation that li

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie created this revision. OikawaKirie added reviewers: pgousseau, NoQ, steakhal, balazske, xazax.hun. OikawaKirie added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529563. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h cl

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

michaelplatings updated this revision to Diff 529564. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529565. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529566. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 added a comment. I kinda thought the undefined reference error is just something I broke on my machine but guess not. Don't really know what can cause it since it can link to other functions from there and the function exists. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529567. michaelplatings added a comment. Simplify code as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolC

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529569. michaelplatings added a comment. Update docs to reflect recent changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rs

[PATCH] D152415: [RISCV] Add test cases to show that rvv_vector_bits attribute is not accepted for vbool or LMUL!=1 RVV types. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM. thank you for the extra test coverage! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152415/new/ https://reviews.llvm.org/D1

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. I could test the checker on these projects (CTU analysis was not used): memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,tinyxml2,libwebm,xerces,bitcoin,protobuf,qtbase,contour,acid These are reports that could be improved: link

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:589 + ``hostcall`` - printing happens during kernel execution via series of hostcalls, + The scheme requires the system to support pcie atomics.(default) + ``buffered`` - Scheme uses a debug buffer to popul

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaType.cpp:8338 // The attribute vector size must match -mrvv-vector-bits. - if (VecSize != VScale->first * MinElts * EltS

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

vedgy added a comment. In D150910#4405536 , @MineGame159 wrote: > I kinda thought the undefined reference error is just something I broke on my > machine but guess not. Don't really know what can cause it since it can link > to other functions from the

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. One deficiency is that some filenames of test files contain the old **std-c-library-functions-arg** name that is not used any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152436/new/ https://reviews.llvm.org/D15243

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. Another question is if default value of `ModelPOSIX` can be changed to true? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152436/new/ https://reviews.llvm.org/D152436 ___ cfe-c

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. Hmm, I agree that a new checker might be better for the situation when we'd sacrifice a significant amount of TPs, but after reconsidering the situation I think that my concerns are mostly theoretical: if the current code reports an issue, then it's probably not too

[PATCH] D152433: [ARM,AArch64] Add a full set of -mtp= options.

rengolin added a subscriber: olista01. rengolin added inline comments. Comment at: clang/include/clang/Driver/Options.td:3525 + "For AArch32: 'soft' uses a function call, or 'tpidrurw', 'tpidruro' or 'tpidrprw' use the three CP15 registers. 'cp15' is an alias for 'tpi

[PATCH] D152303: [ExprConstant] fix ICE from Evaluate on _Atomic structs

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152303/new/ https://reviews.llvm.org/D152303 ___

[PATCH] D152303: [ExprConstant] fix ICE from Evaluate on _Atomic structs

aaron.ballman accepted this revision. aaron.ballman added a comment. Please add a release note for the fix, but otherwise LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152303/new/ https://reviews.llvm.org/D152303 _

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

kito-cheng added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:819 - // LMUL x NF must be less than or equal to 8. - if ((Log2LMUL >= 1) && (1 << Log2LMUL) * NF > 8) -return std::nullopt; Keep as assert? Repository: rG LLVM Git

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

steakhal added a comment. T In D152269#4403491 , @tripleCC wrote: > In D152269#4403404 , @steakhal > wrote: > >> In D152269#4403282 , @tripleCC >> wrote: >> >>> Yes, yo

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

aaron.ballman added subscribers: majnemer, rnk. aaron.ballman added a comment. I seem to recall this came up in the past and there were issues, so I did some digging around our mail archives and figured I'd share what I found: https://discourse.llvm.org/t/big-clang-dll-plug-in-mechanism-revision

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I chatted with @compnerd on Discord, and I'm going to try to update D109192 and get that committed and then come back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152051/

[PATCH] D152442: [LinkerWrapper] Support linking vendor bitcode late

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, tianshilei1992, jdoerfert, gregrodgers, saiislam. Herald added a subscriber: tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. H

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex created this revision. KitsuneAlex added reviewers: lattner, craig.topper, RKSimon, respindola. KitsuneAlex added a project: clang-format. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperD

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet added a comment. @aaron.ballman I would like to hear what's your take on this approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151720/new/ https://reviews.llvm.org/D151720 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:240 + return printf(s, 10); +} Test _BitInt for small and odd types, plus i128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex added a comment. I made a stupid mistake and messed up the formatting of the anonymous parameter in the unit test code. Fixing this right now, don't know why it slipped through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152443/new/

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC updated this revision to Diff 529583. tripleCC added a comment. taking steakhal's advice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152269/new/ https://reviews.llvm.org/D152269 Files: clang/lib/StaticAnalyzer/Checkers/BasicObjCFounda

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

tripleCC updated this revision to Diff 529584. tripleCC added a comment. clang-format BasicObjCFoundationChecks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152269/new/ https://reviews.llvm.org/D152269 Files: clang/lib/StaticAnalyzer/Checkers/B

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529587. KitsuneAlex added a comment. I removed the redundant anonymous parameter in the unit test source string. Locally all formatting tests passed fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15244

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529588. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

fdeazeve added a comment. I believe this is breaking the LLDB tests: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56106/changes https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/buildTimeTrend Build 56105 was passing, and the only relevant change seems to come from this rev

[clang] 32791f1 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-06-08T16:39:57+02:00 New Revision: 32791f19fd354f58aea9114b6c56301966bdd802 URL: https://github.com/llvm/llvm-project/commit/32791f19fd354f58aea9114b6c56301966bdd802 DIFF: https://github.com/llvm/llvm-project/commit/32791f19fd354f58aea9114b6c56301966bdd802.diff

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

aaron.ballman added a comment. > I think ideally we would get all possible values at this point and analyze > them all(?), but I'm not sure how to implement this. Err, if we don't know the callee, there's not a whole lot we can do. I don't think we'd want to make guesses at what potentially cou

[clang] 15f15ab - [x86][MC] Fix movdir64b addressing

Author: Akshay Khadse Date: 2023-06-08T22:41:00+08:00 New Revision: 15f15ab2c895545da70c14a72289fa7c00ed3f94 URL: https://github.com/llvm/llvm-project/commit/15f15ab2c895545da70c14a72289fa7c00ed3f94 DIFF: https://github.com/llvm/llvm-project/commit/15f15ab2c895545da70c14a72289fa7c00ed3f94.diff

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f15ab2c895: [x86][MC] Fix movdir64b addressing (authored by akshaykhadse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.

[clang] fa6b7dd - [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

Author: tripleCC Date: 2023-06-08T16:48:24+02:00 New Revision: fa6b7dd520fc175a246c943a7c9802e4808118b1 URL: https://github.com/llvm/llvm-project/commit/fa6b7dd520fc175a246c943a7c9802e4808118b1 DIFF: https://github.com/llvm/llvm-project/commit/fa6b7dd520fc175a246c943a7c9802e4808118b1.diff LOG:

[PATCH] D152269: [StaticAnalyzer] Fix false negative on NilArgChecker when creating literal object

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa6b7dd520fc: [StaticAnalyzer] Fix false negative on NilArgChecker

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

steakhal added a comment. I think this patch broke two build bots, and now the CI is red. https://lab.llvm.org/buildbot/#/builders/16/builds/49282 https://lab.llvm.org/buildbot/#/builders/109/builds/65904 Could you please have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4405793 , @fdeazeve wrote: > I believe this is breaking the LLDB tests: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56106/changes > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/buildTimeTre

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 529601. qianzhen added a comment. More examples have been identified for the adaptation of IBM XL compiler's -qstatsym option for the hot patch use case, which was mentioned previously. Therefore, this option is extended to cover the following cases. 1. Fu

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

asb added a comment. One of the key things we've been discussing on this at the LLVM call is that we probably want to keep the small data limit for embedded targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152279/new/ https://reviews.llvm.or

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. P.S: https://reviews.llvm.org/D152449 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D151730: [RISCV] Support target attribute for function

MaskRay added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-func-attr-target.c:2 +// REQUIRES: riscv-registered-target +// RUN: %clang -target riscv64 -march=rv64g -S %s -o - | FileCheck %s --check-prefix=CHECK-ASM +// RUN: %clang -target riscv64 -march=rv64g -emit

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen added a comment. @erichkeane Thanks for the comments! > How does this work with function-local statics? This is a valid case. The function-local statics should be kept; the missing implementation is added now. > What does the behavior look like in C? The C behavior should be the same

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:819 - // LMUL x NF must be less than or equal to 8. - if ((Log2LMUL >= 1) && (1 << Log2LMUL) * NF > 8) -return std::nullopt; kito-cheng wrote: > Keep as assert? `computeType

[PATCH] D152429: [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks, this generally looks good but I did spot a small change to make (can make it when landing). Comment at: clang/include/clang/AST/Type.h:1542 +static c

[clang] 7815166 - Revert "[DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-08T17:36:30+02:00 New Revision: 7815166b476b4184a1171ef56eed35726c1ab132 URL: https://github.com/llvm/llvm-project/commit/7815166b476b4184a1171ef56eed35726c1ab132 DIFF: https://github.com/llvm/llvm-project/commit/7815166b476b4184a1171ef56eed35726c1ab13

[clang] 0f0623a - [Clang] Remove some explicit -opaque-pointers options in tests (NFC)

Author: Nikita Popov Date: 2023-06-08T17:41:27+02:00 New Revision: 0f0623ab87e9041fe0df1e788958330a2787a494 URL: https://github.com/llvm/llvm-project/commit/0f0623ab87e9041fe0df1e788958330a2787a494 DIFF: https://github.com/llvm/llvm-project/commit/0f0623ab87e9041fe0df1e788958330a2787a494.diff

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4405875 , @steakhal wrote: > I think this patch broke two build bots, and now the CI is red. > https://lab.llvm.org/buildbot/#/builders/16/builds/49282 > https://lab.llvm.org/buildbot/#/builders/109/builds/65904 > >

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1113-1114 + +const BinaryOperator *LHS = dyn_cast(LHSExpr); +const BinaryOperator *RHS = dyn_cast(RHSExpr); if (!LHS || !RHS) Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 edited the summary of this revision. durin42 updated this revision to Diff 529614. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152400/new/ https://reviews.llvm.org/D152400 Files: clang/test/CodeGen/catch-alignment-assumption-attribute-a

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529613. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGen/pr53127.cpp clang/test/CodeGenCXX/cxx1y-sized-de

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529616. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c clang/test/CodeGen/alloc-fns-ali

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529615. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 edited the summary of this revision. durin42 updated this revision to Diff 529617. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152401/new/ https://reviews.llvm.org/D152401 Files: clang/lib/CodeGen/CGExprCXX.cpp clang/test/CodeGenCXX/cx

[clang] e4c1fa7 - [RISCV] Add test cases to show that rvv_vector_bits attribute is not accepted for vbool or LMUL!=1 RVV types. NFC

Author: Craig Topper Date: 2023-06-08T08:47:59-07:00 New Revision: e4c1fa734ea7cd8f76f221e99cc727c18858183e URL: https://github.com/llvm/llvm-project/commit/e4c1fa734ea7cd8f76f221e99cc727c18858183e DIFF: https://github.com/llvm/llvm-project/commit/e4c1fa734ea7cd8f76f221e99cc727c18858183e.diff

[PATCH] D152415: [RISCV] Add test cases to show that rvv_vector_bits attribute is not accepted for vbool or LMUL!=1 RVV types. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4c1fa734ea7: [RISCV] Add test cases to show that rvv_vector_bits attribute is not accepted… (authored by craig.topper). Repository: rG LLVM Githu

[clang] 066fb7a - [Clang] Remove -no-opaque-pointers cc1 flag

Author: Nikita Popov Date: 2023-06-08T17:52:20+02:00 New Revision: 066fb7a58c5a0dd518d0841ed8f32f86d9f798ec URL: https://github.com/llvm/llvm-project/commit/066fb7a58c5a0dd518d0841ed8f32f86d9f798ec DIFF: https://github.com/llvm/llvm-project/commit/066fb7a58c5a0dd518d0841ed8f32f86d9f798ec.diff

[PATCH] D152447: [Clang] Remove -no-opaque-pointers cc1 flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG066fb7a58c5a: [Clang] Remove -no-opaque-pointers cc1 flag (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

steakhal added a comment. In D143984#4405961 , @dzhidzhoev wrote: > In D143984#4405875 , @steakhal > wrote: > >> I think this patch broke two build bots, and now the CI is red. >> https://lab.llvm.org/buildbot/#

[clang] cd18efb - [Driver] Make -G TargetSpecific

Author: Fangrui Song Date: 2023-06-08T09:02:12-07:00 New Revision: cd18efb61d759405956dbd30e4b5f2720d8e1783 URL: https://github.com/llvm/llvm-project/commit/cd18efb61d759405956dbd30e4b5f2720d8e1783 DIFF: https://github.com/llvm/llvm-project/commit/cd18efb61d759405956dbd30e4b5f2720d8e1783.diff

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added a comment. In D152321#4403719 , @JOE1994 wrote: > Some tests that run with `-no-opaque-pointers` began failing after I updated > the revision to get rid of bitcasts. > The bitcasts are still needed if running Clang with `-no-opaque-pointers`.

[clang] e12aee2 - [RISCV] Update documentation for -mvscale-min/max options to mention RISC-V. NFC

Author: Craig Topper Date: 2023-06-08T09:16:01-07:00 New Revision: e12aee2afeabdba3fa2229b616c3aab48e6f2a54 URL: https://github.com/llvm/llvm-project/commit/e12aee2afeabdba3fa2229b616c3aab48e6f2a54 DIFF: https://github.com/llvm/llvm-project/commit/e12aee2afeabdba3fa2229b616c3aab48e6f2a54.diff

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 529630. Sedeniono added a comment. Reformatted comment, and submitting it via `arc diff --update` now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 Files: clan

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono updated this revision to Diff 529631. Sedeniono added a comment. Next try at getting all changes to phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 Files: clang/lib/Format/Unwrapp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// e

[PATCH] D152429: [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

eopXD updated this revision to Diff 529634. eopXD added a comment. Address comment from Aaron. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152429/new/ https://reviews.llvm.org/D152429 Files: clang/include/clang/AST/Type.h Index: clang/includ

[PATCH] D152443: Add SpaceAfterOperatorKeyword style option for clang-format

KitsuneAlex updated this revision to Diff 529635. KitsuneAlex added a comment. I took the liberty and extended the unit tests for SpaceAfterTemplateKeyword and SpaceAfterOperator keyword to cover both possible cases, which lead to me discovering that my code was not quite right because of an ear

  1   2   >