phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land.
LGTM thanks! ================ Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Negate defines whether the flag is negated and therefore disallowed. + MultilibBuilder &flag(StringRef Flag, bool Negate = false); ---------------- After seeing the change and specifically the comment on this fuinction, I think that `Disallow` might be a better name than `Negate` if it's not too much hassle to change it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152353/new/ https://reviews.llvm.org/D152353 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
