phosek accepted this revision. phosek added a comment. In D142932#4402981 <https://reviews.llvm.org/D142932#4402981>, @michaelplatings wrote:
> @phosek thanks for your suggestion, that's now implemented. In practise for > LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I've > removed that feature. Great, that simplifies things even further. The only other suggestion I have is to maybe rename `FlagMap` to `Mappings` for a better consistency with `Variants`, otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
