[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 515227. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra

[clang-tools-extra] 9e9b1ef - [clangd] Implement cross reference request for #include lines.

Author: Viktoriia Bakalova Date: 2023-04-20T07:11:48Z New Revision: 9e9b1effac34b75d22483955187b94418c12ebce URL: https://github.com/llvm/llvm-project/commit/9e9b1effac34b75d22483955187b94418c12ebce DIFF: https://github.com/llvm/llvm-project/commit/9e9b1effac34b75d22483955187b94418c12ebce.diff

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e9b1effac34: [clangd] Implement cross reference request for #include lines. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is an initial patch to add

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1722 [&](clangd::Diagnostic Diag, llvm::ArrayRef Fixes) { + if (DiagOpts.EmbedFixesInDiagnostics && !Fixes.empty()) { + Diag.codeActions.emplac

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

hokein updated this revision to Diff 515230. hokein added a comment. add missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148783/new/ https://reviews.llvm.org/D148783 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-e

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. In D143675#4281673 , @rsundahl wrote: > @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality > is under the added flag so not expecting any surprises. I don't have reasons to block this. ===

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

mstorsjo added a comment. FYI, I'm seeing occasional spurious build breakage from this change. The issue is that even if we've got `add_dependencies(clangAnalysisFlowSensitive clangAnalysisFlowSensitiveResources)`, it looks like `clangAnalysisFlowSensitiveResources` only is considered a depend

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

tbaeder marked 5 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1337 if (S->isClassScope()) -if (CXXRecordDecl *Record = -dyn_cast_or_null(S->getEntity())) +if (auto *Record = dyn_cast_if_pr

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:21 #include "llvm/Support/Debug.h" +#include What is this? Comment at: clang/lib/Format/TokenAnnotator.cpp:5023-5026 + // string Foo + // {

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay created this revision. MaskRay added reviewers: Sanitizers, pcc, peter.smith, sberg, samitolvanen. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: ll

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 515242. tbaeder added a comment. Fix all existing tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOption

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

chapuni added a comment. It comes from handling of objlib. 1. Use add_clang_library's DEPENDS It adds deps on both libs. 2. Don't create a custom target. Just add to sources. add_library(HTMLLogger.inc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 515243. MaskRay added a comment. Herald added a subscriber: pengfei. update llvm/test/CodeGen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Unde

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4281825 , @paulkirth wrote: > Here are reduced cases. I didn't bother bisecting flags, but the test case is > quite small > F27199288: clang-crashreports.zip > > struct a {}; >

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon updated this revision to Diff 515256. Fznamznon added a comment. Rebase, mention C++23, add a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712 Files: clang/lib/Sema/SemaLambda.cpp c

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1381 +if (Capture.Id == TP->getIdentifier()) { + Diag(Capture.Loc, diag::err_template_param_shadow) << Capture.Id; + Diag(TP->getLocati

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon updated this revision to Diff 515257. Fznamznon added a comment. Modify comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712 Files: clang/lib/Sema/SemaLambda.cpp clang/test/CXX/expr/expr.

[PATCH] D147321: [Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada updated this revision to Diff 515259. domada added a comment. Herald added a subscriber: bviyer. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147321/new/ https://reviews.llvm.org/D147321 Files: clang/lib/CodeGen/CodeGenFunction.cpp llvm/include/llvm/Frontend/O

[PATCH] D148596: [KMSAN] Enable on SystemZ

glider added a comment. LGTM with a nit. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:750 + ArgsTy... Args) { + if (TargetTriple.getArch() == Triple::systemz) { +return M.getOrInsertFunction(Name, Type:

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added a comment. In D148723#4280916 , @efriedma wrote: > This seems like a weird way to fix this. I agree, not a big fan either. But wanting to start the bike shedding in some way. > The point of an "inline builtin" is that the inline

[clang] 30aea03 - [clang][Sema][NFC] Use existing TargetInfo local variable

Author: Timm Bäder Date: 2023-04-20T11:25:46+02:00 New Revision: 30aea0320271502796b0afeed43c1ba2e8059e15 URL: https://github.com/llvm/llvm-project/commit/30aea0320271502796b0afeed43c1ba2e8059e15 DIFF: https://github.com/llvm/llvm-project/commit/30aea0320271502796b0afeed43c1ba2e8059e15.diff LO

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

hokein added a comment. Friendly ping in case you missed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147034/new/ https://reviews.llvm.org/D147034 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/ https://reviews.llvm.org/D148777 ___ cfe-commits mailing list cfe-com

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

JiruiWu marked an inline comment as done. JiruiWu added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2118 + if (Packed) +UnadjustedAlignment = std::max(UnadjustedAlignment, UnpackedFieldAlign); UpdateAlignment(FieldAlign, UnpackedFieldAlign, Preferre

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added a comment. In D147395#4253753 , @zhangyi1357 wrote: > I dont have commit access. Could you help committing the change for me? > @hokein sure, I will land it for you (sorry for the late response). Comment at: clang-tools

[clang] 9bbe25e - [clang][Lex][NFC] Use a range for loop in StringLiteralParser

Author: Timm Bäder Date: 2023-04-20T11:51:05+02:00 New Revision: 9bbe25eca534b0627e03749437713183452ec8c5 URL: https://github.com/llvm/llvm-project/commit/9bbe25eca534b0627e03749437713183452ec8c5 DIFF: https://github.com/llvm/llvm-project/commit/9bbe25eca534b0627e03749437713183452ec8c5.diff LO

[PATCH] D148596: [KMSAN] Enable on SystemZ

iii updated this revision to Diff 515266. iii added a comment. - Add a comment to getOrInsertMsanMetadataFunction(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148596/new/ https://reviews.llvm.org/D148596 Files: clang/lib/Driver/ToolChains/Li

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added a comment. CCing @njames93 since I have no idea how to properly fix the clang-tidy test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commi

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

kiranchandramohan added a comment. Please update the summary to convey all the changes introduced in the patch. From the tests, it looks like there is a substantial change in the IR. I was hoping this to be an NFC change. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBui

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG80fda7a34663: [clang][Sema][NFC] Make a bunch of things const if possible (authored by tbaeder). Changed p

[clang] 80fda7a - [clang][Sema][NFC] Make a bunch of things const if possible

Author: Timm Bäder Date: 2023-04-20T12:23:51+02:00 New Revision: 80fda7a346630e490e8bc3a9cc0d5e0d35526ecb URL: https://github.com/llvm/llvm-project/commit/80fda7a346630e490e8bc3a9cc0d5e0d35526ecb DIFF: https://github.com/llvm/llvm-project/commit/80fda7a346630e490e8bc3a9cc0d5e0d35526ecb.diff LO

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

kadircet added a comment. can you also have a version of the clang-tools-extra/clangd/test/fixits-command.test with `documentChanges` support? it's unlikely to have clients in that configuration but i believe the deserialization issue i mentioned above would be discoverable by such a test. =

[clang] 51f6a16 - [clang-format] Hanlde leading whitespaces for JSON files

Author: Owen Pan Date: 2023-04-20T04:31:55-07:00 New Revision: 51f6a16646b76152d1b91ed68d018d306f7ab2fc URL: https://github.com/llvm/llvm-project/commit/51f6a16646b76152d1b91ed68d018d306f7ab2fc DIFF: https://github.com/llvm/llvm-project/commit/51f6a16646b76152d1b91ed68d018d306f7ab2fc.diff LOG:

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51f6a16646b7: [clang-format] Hanlde leading whitespaces for JSON files (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy added a comment. @steakhal Then I'll clean up my own solution, which will be completely independent of the patch of Tomasz (except for the obviously identical changes in the test code). The de-duplication that I'm planning is not pure NFC, because it'll probably affect some mostly-t

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo created this revision. Herald added subscribers: PiotrZSL, ChuanqiXu, kadircet, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-com

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 515283. AMS21 marked 12 inline comments as done. AMS21 added a comment. Implement suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tool

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp:48-51 +const CharSourceRange TokenRange = +CharSourceRange::getTokenRange(Expression->getSourceRange()); +const StringRef SourceText = Lexer::getSourceText( +

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

kadircet added a comment. thanks! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:143 + std::vector Macros; + for (const auto &MAndRefs : AST.getMacros().MacroRefs) { +for (const auto &Ref : MAndRefs.second) { nit: `const auto &[SID, Refs]`

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. More or less looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 ___

[clang] 2e275e2 - [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

Author: Aaron Ballman Date: 2023-04-20T08:02:40-04:00 New Revision: 2e275e24355cb224981f9beb2b026a3169fc7232 URL: https://github.com/llvm/llvm-project/commit/2e275e24355cb224981f9beb2b026a3169fc7232 DIFF: https://github.com/llvm/llvm-project/commit/2e275e24355cb224981f9beb2b026a3169fc7232.diff

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e275e24355c: [C11] Allow initialization of an atomic-qualified pointer from a null pointer… (authored by aaron.ballman). Repository: rG LLVM Gith

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon updated this revision to Diff 515287. Fznamznon added a comment. Reject flexible array members in unions in C++ as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 Files: clang/docs/Relea

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4283149 , @kiranchandramohan wrote: > Please update the summary to convey all the changes introduced in the patch. > > From the tests, it looks like there is a substantial change in the IR. I was > hoping this to be a

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

mariusz-sikora-at-amd created this revision. Herald added subscribers: kosarev, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. mariusz-sikora-at-amd requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald add

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

mariusz-sikora-at-amd added reviewers: arsenm, rampitec, gandhi21299, foad. mariusz-sikora-at-amd added a comment. Herald added a subscriber: StephenFan. This is a proposal how we could extend global fadd atomic builtins support for gfx908 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

arsenm added a comment. I thought we had separate _rtn* builtins for this? Comment at: clang/lib/Sema/SemaChecking.cpp:4484 +auto TargetID = Context.getTargetInfo().getTargetID(); +if (!TargetID || TargetID->find("gfx908") == std::string::npos) + return false;

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515298. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Address review comment, add convenience functions to simplify conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/ https://reviews.llvm.

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina abandoned this revision. eklepilkina added a comment. Herald added a subscriber: jobnoorman. Another implementation was merged to upsteam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 __

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon updated this revision to Diff 515305. agozillon added a comment. - Resolve some of the reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148038/new/ https://reviews.llvm.org/D148038 Files: clang/include/clang/Driver/Optio

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

tianshilei1992 added a comment. Herald added subscribers: ekilmer, jplehr, StephenFan. This patch breaks the assumption that some projects are supposed to support to be built as a standalone project. For example, we do have a standalone release for OpenMP (https://github.com/llvm/llvm-project/r

[clang-tools-extra] 2ae1aa9 - [Clangd] Make the type hint length limit configurable

Author: zhangyi1357 Date: 2023-04-20T15:21:48+02:00 New Revision: 2ae1aa9da7882f9a0707c4cea8d76bced44dd7fb URL: https://github.com/llvm/llvm-project/commit/2ae1aa9da7882f9a0707c4cea8d76bced44dd7fb DIFF: https://github.com/llvm/llvm-project/commit/2ae1aa9da7882f9a0707c4cea8d76bced44dd7fb.diff L

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae1aa9da788: [Clangd] Make the type hint length limit configurable (authored by zhangyi1357, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon marked 4 inline comments as done. agozillon added a comment. Addressed 4/5 of your comments in the latest patch @awarzynski, I've replied to the final one to give a little more information to add to the final decision you make! Comment at: flang/lib/Frontend/Compile

[PATCH] D148799: [clang] Return `StringRef` from `TargetInfo::getClobbers()`

Stoorx created this revision. Stoorx added a reviewer: klimek. Stoorx added a project: clang. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

mariusz-sikora-at-amd added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4491 +// the builtin. +TheCall->setType(Context.VoidTy); +return false; arsenm wrote: > I'm assuming mutating the AST is very not OK I based my changes on how __s

[PATCH] D148800: [C2x] Update 'nullptr' implementation based on CD comments

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, clang-language-wg, efriedma, rjmccall, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We filed some CD ballot comments which WG14 considered during

[PATCH] D148799: [clang] Return `StringRef` from `TargetInfo::getClobbers()`

Stoorx updated this revision to Diff 515312. Stoorx added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148799/new/ https://reviews.llvm.org/D148799 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov created this revision. ilya-biryukov added reviewers: aaron.ballman, erichkeane. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit implements [temp.deduct]p9. Test updates i

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

erichkeane added a comment. My one concern is that this is going to expose our incorrect instantiation of lambdas further and more painfully (see https://github.com/llvm/llvm-project/issues/58872). Else, I don't see anything to be concerned about here. I think the FIXME of adding a note diagn

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

kiranchandramohan added inline comments. Comment at: mlir/test/Target/LLVMIR/omptarget-llvm.mlir:4-5 -llvm.func @_QPopenmp_target_data() { - %0 = llvm.mlir.constant(1 : i64) : i64 - %1 = llvm.alloca %0 x i32 {bindc_name = "i", in_type = i32, operand_segment_sizes = array, uniq

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

steakhal added a comment. Sounds good. Thanks for clarifying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148355/new/ https://reviews.llvm.org/D148355 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] b74aeac - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-20T15:08:01+01:00 New Revision: b74aeaccbae876ca348aa87a3db05d444052ae65 URL: https://github.com/llvm/llvm-project/commit/b74aeaccbae876ca348aa87a3db05d444052ae65 DIFF: https://github.com/llvm/llvm-project/commit/b74aeaccbae876ca348aa87a3db05d444052ae65.diff LOG:

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna updated this revision to Diff 515318. Manna added a comment. Thank you everyone for reviews and feedbacks. I misunderstood some of the False positive Coverity cases. Thanks for the explanation and suggestions. I will keep this in mind while investigating static analysis in future. This pat

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

kiranchandramohan added a comment. Would it be possible to break this into a few patches like suggested below or similar? 1. Changed to using inlineConvertOmpRegions to generate target data associated region code inline in same block if possible. 2. Changed to calculating map_operand size from

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 515322. VitaNuo added a comment. Add a pragma example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-to

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 515323. VitaNuo added a comment. Remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-e

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna marked 7 inline comments as done. Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9426 } else { for (auto IvarPair : DuplicateIvars) { Diag(IvarPair.first->getLocation(), tahonermann wrote: > aaron.b

[clang] 63a82dd - [C11] Allow casting to an _Atomic-qualified type

Author: Aaron Ballman Date: 2023-04-20T10:24:22-04:00 New Revision: 63a82dd4eb0c23dbd4277a5ce2d5bfeda836aa64 URL: https://github.com/llvm/llvm-project/commit/63a82dd4eb0c23dbd4277a5ce2d5bfeda836aa64 DIFF: https://github.com/llvm/llvm-project/commit/63a82dd4eb0c23dbd4277a5ce2d5bfeda836aa64.diff

[PATCH] D146987: [Assignment Tracking] Enable by default

jmorse added a comment. Seeing how this has been in and out quite a bit, I figure it's worth explaning my understanding of what's failing and why. Just so it doesn't look like we're needlessly fuzzing other peoples CI. Three kinds of failures so far: - The usual edge cases for things we hadn't

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

Eugene.Zelenko added a comment. Is there real advantage in Clang-tidy check versus standalone tool? Comment at: clang-tools-extra/docs/ReleaseNotes.rst:144 + + FIXME: add release notes. + Please add one sentence description. Comment at: cla

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. This looks good to me now, nice work. Let's wait a few days for others' input to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1479

[PATCH] D148805: [Clang][OpenMP] Avoid emitting a __kmpc_alloc_shared for implicit casts which do not have their address taken

doru1004 created this revision. doru1004 added reviewers: ronl, jdoerfert, jhuber6, carlo.bertolli, JonChesterfield, dhruvachak, gregrodgers, ABataev. doru1004 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. doru1004 requested review of

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy updated this revision to Diff 515326. donat.nagy edited the summary of this revision. donat.nagy added a comment. I'm publishing the extended variant of this commit (which I mentioned in earlier comments). This generalizes the first version of the commit to check for the unsigned-vs-

[PATCH] D148805: [Clang][OpenMP] Avoid emitting a __kmpc_alloc_shared for implicit casts which do not have their address taken

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:448 return; -if (E->getCastKind() == CK_ArrayToPointerDecay) { - const bool SavedAllEscaped = AllEscaped; I think you need to check that the array is allocated in

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

enh accepted this revision. enh added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148779/new/ https://reviews.llvm.org/D148779 ___ cf

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:965 +case CodeSynthesisContext::LambdaExpressionSubstitution: + // FIXME: add a note for lambdas. break; erichkeane wrote: > Would really like this note he

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

carlosgalvezp added a comment. I believe this should be discussed in an RFC. We already have the standalone `include-cleaner` tool, why is that not sufficient? Can it be extended instead? There's also the include-what-you-use tool o

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

Eugene.Zelenko added a comment. In D148793#4283733 , @carlosgalvezp wrote: > I believe this should be discussed in an RFC. We already have the standalone > `include-cleaner` tool, why is that not sufficient? Can it be extended > instead? There's also t

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

kadircet added a comment. Hi folks, the rationale for a clang-tidy check is enabling include-cleaner findings to be applied at scale and integrations into existing workflows (e.g. a lot of people run cleanups using clang-tidy findings hence there's somewhat existing infra for that). current in

[PATCH] D148802: [Sema] Lambdas are not part of immediate context for deduction

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:965 +case CodeSynthesisContext::LambdaExpressionSubstitution: + // FIXME: add a note for lambdas. break; ilya-biryukov wrote: > erichkeane wrote: > > Would re

[PATCH] D148805: [Clang][OpenMP] Avoid emitting a __kmpc_alloc_shared for implicit casts which do not have their address taken

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:448 return; -if (E->getCastKind() == CK_ArrayToPointerDecay) { - const bool SavedAllEscaped = AllEscaped; ABataev wrote: > I think you need to check that the arra

[clang] 8a39465 - [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

Author: Zarko Todorovski Date: 2023-04-20T11:08:12-04:00 New Revision: 8a39465d0015cb6147ea3e96adeb8b560765eea2 URL: https://github.com/llvm/llvm-project/commit/8a39465d0015cb6147ea3e96adeb8b560765eea2 DIFF: https://github.com/llvm/llvm-project/commit/8a39465d0015cb6147ea3e96adeb8b560765eea2.di

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. There is another case I need to cover Style.BraceWrapping.AfterCSharpProperty = false; Style.AllowShortCSharpPropertiesOnASingleLine = false; Style.AlwaysBreakBetweenShortCSharpProperties = false; Style.Brace

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

aaron.ballman accepted this revision. aaron.ballman added a comment. Thanks for the fix! LGTM, but please add a release note for the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148779/new/ https://reviews.llvm.org/D148779

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

benlangmuir added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148176/new/ https://reviews.llvm.org/D148176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD) { - if (!FD->isExternallyVisible()) + if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration()) return GV

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 marked 3 inline comments as done. ipriyanshi1708 added a comment. In D147989#4283666 , @samtebbs wrote: > This looks good to me now, nice work. Let's wait a few days for others' input > to be safe. okay! Thank You Sir.

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5192 - if (const auto *FD = D->getAsFunction()) + if (const auto *FD = D->getAsFunction()) { if (FD->isMultiVersion() && Linkage == GVA_AvailableExternally) erichkea

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD) { - if (!FD->isExternallyVisible()) + if (!FD->isExternallyVisible() || FD->isInlineBuiltinDeclaration()) return GVA_Inter

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. I think something like #ifdef RINZOCORE_SHARED #define RINZO_LIB __declspec(dllexport) #else #define RINZO_LIB __declspec(dllimport) #endif RINZO_LIB inline func() {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/

[clang] 3b06779 - Headers: use C++ inline semantics in C++ mode

Author: Saleem Abdulrasool Date: 2023-04-20T09:02:52-07:00 New Revision: 3b0677964c46f2d98499eb6b177bcbfca704b109 URL: https://github.com/llvm/llvm-project/commit/3b0677964c46f2d98499eb6b177bcbfca704b109 DIFF: https://github.com/llvm/llvm-project/commit/3b0677964c46f2d98499eb6b177bcbfca704b109.

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0677964c46: Headers: use C++ inline semantics in C++ mode (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D139749?vs=4

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

jansvoboda11 added a comment. Can you explain why we need to keep separate `PendingImportedModulesSema` now? In what situation will it end up aggregating more than one `PendingImportedModules`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148176/

[PATCH] D148779: [Sema] -Wformat: recognize %lb for the ``printf``/``scanf`` family of functions

MaskRay updated this revision to Diff 515357. MaskRay retitled this revision from "[Sema] Fix spurious warning for printf("%lb", (long)10)" to "[Sema] -Wformat: recognize %lb for the ``printf``/``scanf`` family of functions". MaskRay edited the summary of this revision. MaskRay added a comment.

[clang] 5cf37d8 - [Sema] -Wformat: recognize %lb for the printf/scanf family of functions

Author: Fangrui Song Date: 2023-04-20T09:34:34-07:00 New Revision: 5cf37d8bd5c05ef84fba6d6fd9d4ac8b9905c7cb URL: https://github.com/llvm/llvm-project/commit/5cf37d8bd5c05ef84fba6d6fd9d4ac8b9905c7cb DIFF: https://github.com/llvm/llvm-project/commit/5cf37d8bd5c05ef84fba6d6fd9d4ac8b9905c7cb.diff

[PATCH] D148779: [Sema] -Wformat: recognize %lb for the printf/scanf family of functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cf37d8bd5c0: [Sema] -Wformat: recognize %lb for the printf/scanf family of functions (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D148176: [clang][modules] Avoid re-exporting PCH imports on every later module import

benlangmuir added a comment. In D148176#4283942 , @jansvoboda11 wrote: > Can you explain why we need to keep separate `PendingImportedModulesSema` > now? In what situation will it end up aggregating more than one > `PendingImportedModules`? I don't kn

  1   2   3   >