donat.nagy added a comment. @steakhal Then I'll clean up my own solution, which will be completely independent of the patch of Tomasz (except for the obviously identical changes in the test code).
The de-duplication that I'm planning is not pure NFC, because it'll probably affect some mostly-theoretical corner cases: e.g. the current implementation skips the upper bound check if lowerBound (the result of the first evalBinOpNN) is not a NonLoc, while after the refactor this won't trigger an early return. As it's not a very big change (limited to one function), I'll probably do it in the same commit as the fix of the unsigned-vs-negative bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148355/new/ https://reviews.llvm.org/D148355 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
