kiranchandramohan added a comment.
Please update the summary to convey all the changes introduced in the patch.
From the tests, it looks like there is a substantial change in the IR. I was
hoping this to be an NFC change.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1383
struct MapperAllocas &MapperAllocas, int64_t DeviceID,
- unsigned NumOperands);
+ unsigned NumOperands, Value *MapsizesArg = nullptr);
----------------
Please add the new argument to the documentation above.
================
Comment at: mlir/test/Target/LLVMIR/omptarget-llvm.mlir:4-5
-llvm.func @_QPopenmp_target_data() {
- %0 = llvm.mlir.constant(1 : i64) : i64
- %1 = llvm.alloca %0 x i32 {bindc_name = "i", in_type = i32,
operand_segment_sizes = array<i32: 0, 0>, uniq_name =
"_QFopenmp_target_dataEi"} : (i64) -> !llvm.ptr<i32>
omp.target_data map((tofrom -> %1 : !llvm.ptr<i32>)) {
----------------
Why is the test changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146557/new/
https://reviews.llvm.org/D146557
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
