glider added a comment.
LGTM with a nit.
================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:750
+ ArgsTy... Args) {
+ if (TargetTriple.getArch() == Triple::systemz) {
+ return M.getOrInsertFunction(Name, Type::getVoidTy(*C),
----------------
I think people unfamiliar with the s390 ABI will still stumble upon this code.
Can you please add some comment along the lines of "On SystemZ, metadata hooks
return the shadow/origin pair via an extra *MsanMetadata parameter"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148596/new/
https://reviews.llvm.org/D148596
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
