[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:502 ArrayRef LocalParameters, + SourceLocation RParenLoc, ArrayRef Requirements, erichkeane wrote: > Is this an unrelated change? Are p

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

gregrodgers created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. gregrodgers requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang.

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147546/new/ https://reviews.llvm.org/D147546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

craig.topper accepted this revision. craig.topper added a comment. LGTM other than that one comment. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:86 InstrInfo(*this), RegInfo(getHwMode()), TLInfo(TM, *this) { - if (RISCV::isX18ReservedByDefault(TT)) -UserRes

cfe-commits@lists.llvm.org

ziqingluo-90 added a comment. In D143128#4245112 , @DavidSpickett wrote: > I've reverted this, please try to fix the test then reland. > > The full test output can be downloaded from the buildbot page, if you need > any more information let me know. Th

[clang] 3242934 - Lazily deserialize default member initializers.

Author: Richard Smith Date: 2023-04-05T15:46:13-07:00 New Revision: 32429341910d0a48336215be13c7c9140dd26da4 URL: https://github.com/llvm/llvm-project/commit/32429341910d0a48336215be13c7c9140dd26da4 DIFF: https://github.com/llvm/llvm-project/commit/32429341910d0a48336215be13c7c9140dd26da4.diff

[clang] bfee6f1 - [Clang][NFC] Refactor "Designators" to be more similar

Author: Bill Wendling Date: 2023-04-05T15:46:40-07:00 New Revision: bfee6f1142368e522d09551930ef90f4e6be1f42 URL: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42 DIFF: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42.diff

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfee6f114236: [Clang][NFC] Refactor "Designators" to be more similar (authored by void). Changed prior to commit: https://reviews.llvm.org/D147580

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

MyDeveloperDay added inline comments. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Comment at: clang/lib/Format/FormatToken.h:615 tok::kw__Null_unspecified, tok::kw___ptr32, tok::kw___ptr64,

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

mcgrathr added a comment. I don't see changes here to make the Fuchsia & Android targets stop doing implicit `-ffixed-x18` and to make them start doing implicit `-msmall-data-limit=0` for non-PIC modes. Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & Sani

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm.org/D147612 ___ cfe-commits mailing list c

[clang] 5f91c74 - [Driver] Fix rpath for compiler-rt

Author: Yaxun (Sam) Liu Date: 2023-04-05T20:14:53-04:00 New Revision: 5f91c747763c20a63f3d6156fced03b474f842a1 URL: https://github.com/llvm/llvm-project/commit/5f91c747763c20a63f3d6156fced03b474f842a1 DIFF: https://github.com/llvm/llvm-project/commit/5f91c747763c20a63f3d6156fced03b474f842a1.dif

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG5f91c747763c: [Driver] Fix rpath for compiler-rt (authored by yaxunl). Herald added a project: clang. Chang

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void created this revision. void added a reviewer: rsmith. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A "null" designator won't have a valid location. Try to approximate this location as best we can in

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org/D147611 ___ cfe-commits mailing list c

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

jhuber6 added a comment. Using `-rpath` by default with OpenMP was removed after a long conversation in https://reviews.llvm.org/D143306. The way forward is most likely to have AOMP provide this in a resource file configuration. I think @ronlieb has a working version of that. Repository: rG

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. whe Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & SanitizerKind::ShadowCallStack) && - ((TC.getTriple().isAArch64() && -!llvm::AArch64::isX18ReservedByDefault(TC.getTriple())) || - (TC.getTriple().isRISCV() &&

[PATCH] D147590: [clang] Add test for CWG607

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you for working on these DRs, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147590/new/ https://reviews.llvm.org/D147590 ___

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

shafik added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:962 + // Save the token name used for static assertion. + const char *TokName = Tok.getName(); It looks like this comes from a static array so it should be fine but let's see what Aar

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions + if

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. In D143479#4243143 , @erichkeane wrote: > Based on GCC's behavior: https://godbolt.org/z/fxWzPTT9P I suspect our > behavior is consistent/correct now, and the 'regressions' are to be expected, > since GCC diagnoses the same thin

[clang] 5bbadec - Recommit [C++20] [Modules] Don't load declaration eagerly for named modules

Author: Chuanqi Xu Date: 2023-04-06T11:01:58+08:00 New Revision: 5bbadec2d1e0d5d0d25295759d49f6cd420d0968 URL: https://github.com/llvm/llvm-project/commit/5bbadec2d1e0d5d0d25295759d49f6cd420d0968 DIFF: https://github.com/llvm/llvm-project/commit/5bbadec2d1e0d5d0d25295759d49f6cd420d0968.diff LO

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpned_p, "iiV2LLiV2LLi", "", "altivec") + maryammo wrote: > am

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. Shouldn't the Nvidia version also be undefined? Not sure why

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Thanks for fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147657/new/ https://reviews.llvm.org/D147657

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

jrtc27 added a comment. From an ABI/codegen perspective the small data limit doesn’t matter here, all it does is govern whether things go in .sdata or not. The linker is what chooses whether to use GP, which happens regardless of whether something is in .sdata, just things in .sdata are more li

[clang] 847abdd - [X86] Add AMX_COMPLEX to Graniterapids

Author: Freddy Ye Date: 2023-04-06T13:19:44+08:00 New Revision: 847abddedca9ed2934e0c2386662ccb04ba4d298 URL: https://github.com/llvm/llvm-project/commit/847abddedca9ed2934e0c2386662ccb04ba4d298 DIFF: https://github.com/llvm/llvm-project/commit/847abddedca9ed2934e0c2386662ccb04ba4d298.diff LOG

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

This revision was automatically updated to reflect the committed changes. Closed by commit rG847abddedca9: [X86] Add AMX_COMPLEX to Graniterapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

asb added a comment. In D146463#4247050 , @paulkirth wrote: > @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us > here? From the discussions in psABI and sig-toolchain, I think we have a > consensus that this is the approach we

[PATCH] D147601: [clang][dataflow] Eliminate code duplication in Environment::createValueUnlessSelfReferential().

mboehme added a comment. Failing premerge check in CodeGen looks unrelated (this patch doesn't affect CodeGen in any way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147601/new/ https://reviews.llvm.org/D147601

<    1   2