[PATCH] D143522: [AMDGPU] Set a data layout entry for buffer descriptors (addrspace 7)

nhaehnle added a comment. This really needs to be a 160-bit type, not a 128-bit type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143522/new/ https://reviews.llvm.org/D143522 ___ cfe-commits mailing li

[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences

barannikov88 updated this revision to Diff 497915. barannikov88 added a comment. Update the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144100/new/ https://reviews.llvm.org/D144100 Files: clang/lib/Lex/LiteralSupport.cpp clang/test/L

[clang] f8d5f0e - [NFC] Add two tests for C++ modules

Author: Chuanqi Xu Date: 2023-02-16T17:02:04+08:00 New Revision: f8d5f0e53b04040cebbba639530133b261a4432f URL: https://github.com/llvm/llvm-project/commit/f8d5f0e53b04040cebbba639530133b261a4432f DIFF: https://github.com/llvm/llvm-project/commit/f8d5f0e53b04040cebbba639530133b261a4432f.diff LO

[clang] 37b7a60 - [NFC] Add a test for C++20 Modules

Author: Chuanqi Xu Date: 2023-02-16T17:14:16+08:00 New Revision: 37b7a60cd74b7a1754583b7eb63a6339158fd398 URL: https://github.com/llvm/llvm-project/commit/37b7a60cd74b7a1754583b7eb63a6339158fd398 DIFF: https://github.com/llvm/llvm-project/commit/37b7a60cd74b7a1754583b7eb63a6339158fd398.diff LO

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

junparser created this revision. Herald added subscribers: pmatos, asb, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. junparser requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. According to gith

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek created this revision. klimek added a reviewer: sammccall. Herald added a project: All. klimek requested review of this revision. Herald added a project: clang. Add configuration to specify macros. Macros will be expanded, and the code will be parsed and annotated in the expanded state. In

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497928. madanial added a comment. Bug Fix for failing test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp fl

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. You still have style mismatch in `flang/include/flang/Tools/CLOptions.inc`. This file is likely not run through clang-format so that's why. Comment at: flang/include/flang/Tools/CLOptions.inc:214 +llvm::OptimizationLevel optLevel = defaultOptLev

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497931. madanial added a comment. addressing style mismatch in > flang/include/flang/Tools/CLOptions.inc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

junparser updated this revision to Diff 497935. junparser added a comment. Replace rem with bitmask operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https://reviews.llvm.org/D144169 Files: clang/lib/Headers/wasm_simd128.h cl

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 497937. cor3ntin added a comment. Reopen/Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCX

[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I wonder if a better fix would be change ResultChar to be a 64 bits integer, although I think it might be over killed (ie, i'm not aware of a good use case for wanting to store values that

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen created this revision. jolanta.jensen added reviewers: mgabka, huntergr, david-arm. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Also added functionality to set the name

[clang] 574e417 - [clang] Fix a bug that allowed some overflowing octal escape sequences

Author: Sergei Barannikov Date: 2023-02-16T15:19:24+03:00 New Revision: 574e417460cdfebb8157fbe61b6a015e44856f64 URL: https://github.com/llvm/llvm-project/commit/574e417460cdfebb8157fbe61b6a015e44856f64 DIFF: https://github.com/llvm/llvm-project/commit/574e417460cdfebb8157fbe61b6a015e44856f64.d

[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG574e417460cd: [clang] Fix a bug that allowed some overflowing octal escape sequences (authored by barannikov88). Repository: rG LLVM Github Monore

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval accepted this revision. clementval added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ c

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** After this patch, any `AbiTagAttr` attribute on a construc

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 497983. Michael137 added a comment. - Remove leftover comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/l

[PATCH] D144136: Add a "remark" to report on array accesses

aaron.ballman added a comment. I'd like to understand what the overhead is for this. How much overhead does this add when the remark is disabled? How much overhead does this add when the remark is enabled? > This will report a ton of information. It's basically only good for piping to > a file

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 497986. Michael137 added a comment. - Remove leftover comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/l

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. Left is without patch. Right is with patch. file: bin/lldb.dSYM/Contents/Resources/DWARF/lldb file: bin

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. It's happening! Comment at: clang/lib/Format/ContinuationIndenter.cpp:743 + // Align following lines within parenthesis / brackets if configured. + // For a line of macro parents, the commas that follow the opening parenthesis ni

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 497994. cor3ntin added a comment. Fix GH60518 by not trying to capture parameters declared in the current context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 F

[PATCH] D143704: [Flang] Part one of Feature List action

schweitz added a comment. In D143704#4130124 , @jdoerfert wrote: > In D143704#4130062 , @clementval > wrote: > >> Where is this coming from? Did I miss where this was discussed. > > It's discussed here, for now.

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:548 + EXPECT_EQ("#include \"a.h\"\n" +"#include \"llvm/a.h\"\n" +"#include \"b.h\"\n" HazardyKnusperkeks wrote: > While I may accept there are more than

[PATCH] D143704: [Flang] Part one of Feature List action

schweitz added a comment. I should've mentioned in my comment that the TODO macros are meant to be deleted. Some day, there will be no more TODOs and there should be a huge celebration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ ht

[PATCH] D144188: Tighten up a modules test

probinson created this revision. probinson added a reviewer: ChuanqiXu. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D144188 Files: clang/test/CXX/module/basic/basic.def.odr/p4.cppm Index: clang/test/CXX/module/basic/basic.def.odr/p4.cppm

[PATCH] D144188: Tighten up a modules test

probinson added a comment. I looked at this test only because it caused a merge conflict downstream. While it does work, it will not catch some kinds of mistakes; by being less specific in the "not" checks, it will catch more potential problems. Comment at: clang/test/CXX/mod

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 created this revision. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, kbarton, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This patch adds clang options `-mroptr` and `-mno-rop

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 498019. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CG

[PATCH] D143704: [Flang] Part one of Feature List action

kiranchandramohan added a comment. FWIW, We have a plugin (https://github.com/llvm/llvm-project/tree/main/flang/examples/FlangOmpReport) that goes over the parse-tree and reports all the OpenMP constructs and clauses seen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Hey, bump on this. Still waiting on the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 ___ cfe-commits mailing list cfe-co

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https://reviews.llvm.org/D144169

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. As reported in GH60642, we asserted when there was a lambda defined in a template arguments inside of a concept, which caused us to not prope

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added a comment. I don't really need reviewers here, I'm more putting this on phab to get the libcxx testing, once that succeeds, i intend to do this as Review-after-commit if there are no concerns (and also ask for this to go to 16.0, as it is a regression). CHANGES SINCE LAST ACT

[clang] 081815b - [Clang] Regenerate check lines (NFC)

Author: Nikita Popov Date: 2023-02-16T17:05:25+01:00 New Revision: 081815b4e32cc57debe974ff89d61436f3bcec83 URL: https://github.com/llvm/llvm-project/commit/081815b4e32cc57debe974ff89d61436f3bcec83 DIFF: https://github.com/llvm/llvm-project/commit/081815b4e32cc57debe974ff89d61436f3bcec83.diff

[clang] eb3dfa0 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-16T17:05:26+01:00 New Revision: eb3dfa0a248794cc51912705540f1ab1f4dde619 URL: https://github.com/llvm/llvm-project/commit/eb3dfa0a248794cc51912705540f1ab1f4dde619 DIFF: https://github.com/llvm/llvm-project/commit/eb3dfa0a248794cc51912705540f1ab1f4dde619.diff

[PATCH] D143704: [Flang] Part one of Feature List action

jdoerfert added a comment. > However, it should be considered harmful to make the TODO macro always > associate with some syntactic source artifact. It would also be unwise to > redefine TODO from a halt semantics to a "just keep going and see what > happens" semantics. @schweitz Why? What's t

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth abandoned this revision. paulkirth added a comment. Based on discussion at the LLVM RISC-V community call, we're going to support emulated TLS in RISC-V, so we can abandon this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/n

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

nigelp-xmos created this revision. Herald added a project: All. nigelp-xmos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144195 Files: clang/test/CodeGen/xcore-abi.c c

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144195/new/ https://reviews.llvm.org/D144195 ___ c

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, jyknight, libc++. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements WG14 N2886 (https://www.ope

[clang] 0871337 - [XCore] Adapt Clang tests to opaque pointers.

Author: Nigel Perks Date: 2023-02-16T16:32:29Z New Revision: 0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c URL: https://github.com/llvm/llvm-project/commit/0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c DIFF: https://github.com/llvm/llvm-project/commit/0871337d97f71cac2dbc9cce33c0ecca3c5e5f9c.diff LOG: [

[PATCH] D144195: [XCore] Adapt Clang tests to opaque pointers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0871337d97f7: [XCore] Adapt Clang tests to opaque pointers. (authored by nigelp-xmos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498038. DmitryPolukhin added a comment. Move standard adaptors to CommandMangler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/cla

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + // Spelling should include brackets or quotes, e.g. . + llvm::SmallVector + mainFileIncludesWithSpelling(llvm::StringRef Spelling) const { we're still returning just the `Head

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. Not entirely sure where the best place to effect this (I think somewhere in the clang driver code?), but on further reflection, it feels like strict fp-model in clang should set the denormal mode to dynamic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

nridge added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFiles(Cmd, Command.Directory, Tokenizer, *FS); + tooling::addTargetAndModeForProgramName(Cmd, Cmd.front()); auto &OptTable = clang::driver::getDriverOptTa

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. With this fix the `std::__va_list` is created at initialization of Sema, previously it was not there. Function `CreateAArch64ABIBuiltinVaListDecl` (ASTContext.cpp) makes the namespace `std` and `__va_list` record. This change fixes the problem with `ASTImporter` probab

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4132318 , @jcranmer-intel wrote: > Not entirely sure where the best place to effect this (I think somewhere in > the clang driver code?), but on further reflection, it feels like strict > fp-model in clang should set

[PATCH] D144120: [HLSL] add log library functions

bob80905 updated this revision to Diff 498051. bob80905 added a comment. - add newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144120/new/ https://reviews.llvm.org/D144120 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeGe

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

aprantl added a comment. Size-wise this looks like an acceptable increase. If we created a new DW_AT_LLVM_abi_tag, we could save an extra 4 bytes (assuming DW_FORM_strp) per DIE. That might be worth it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] f842b7a - [HLSL] add log library functions

Author: Joshua Batista Date: 2023-02-16T09:50:12-08:00 New Revision: f842b7a6b8f40d817d6d43143e09521bd586a756 URL: https://github.com/llvm/llvm-project/commit/f842b7a6b8f40d817d6d43143e09521bd586a756 DIFF: https://github.com/llvm/llvm-project/commit/f842b7a6b8f40d817d6d43143e09521bd586a756.diff

[PATCH] D144120: [HLSL] add log library functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf842b7a6b8f4: [HLSL] add log library functions (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

raghavendhra accepted this revision. raghavendhra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 ___

[PATCH] D141307: [WIP] Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 498065. Leporacanthicus added a comment. Rebased and updated help-message Also using different type of template for the option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

kpn added a comment. What's the plan for tying this to strictfp? Because I don't it should be tied to cases where we use the constrained intrinsics but the exceptions are ignored and the default rounding is in stated. Those instructions are supposed to behave the same as the non-constrained ins

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D143670#4116858 , @erichkeane wrote: > The guidance from EWG this week and in the past was that we are always > required to 'parse and diagnose appertainment' of standard

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. This was discussed at today's RISCV sync-up call. We have a large conversion pending on the topic of isa compatibility checking, but there was a consensus that this was reasonable and could move forward. I'm going to be landing this change in the near future. CHANGES

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. I did kernel builds of x86_64 and aarch64 defconfigs. This found new instance: https://github.com/ClangBuiltLinux/linux/issues/1806 which looks like something we can fix in the kernel sources. Our CI will probably find more instances once this lands, but I'm happ

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:235 MockFS FS; - auto TU = TestTU::withCode(Modified); + auto &TU = PreambleTU; + TU.Code = M

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

MaskRay added a comment. Behaviors due to a new environment variable should be very careful. Why is this useful? If you want this, you can add a wrapper around `clang` to specify `--config=` by yourself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. In D142907#4132543 , @kpn wrote: > What's the plan for tying this to strictfp? Because I don't it should be tied > to cases where we use the constrained intrinsics but the exceptions are > ignored and the default rounding is in s

[libunwind] 372820b - [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems

Author: Nemanja Ivanovic Date: 2023-02-16T13:37:58-05:00 New Revision: 372820bf571c8d32c8165cfc74b0439c7bb397f9 URL: https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9 DIFF: https://github.com/llvm/llvm-project/commit/372820bf571c8d32c8165cfc74b0439c7bb397f9.di

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e199e6afb1: [RISCV] Accept zicsr and zifencei command line options (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 22e199e - [RISCV] Accept zicsr and zifencei command line options

Author: Philip Reames Date: 2023-02-16T10:41:41-08:00 New Revision: 22e199e6afb1263c943c0c0d4498694e15bf8a16 URL: https://github.com/llvm/llvm-project/commit/22e199e6afb1263c943c0c0d4498694e15bf8a16 DIFF: https://github.com/llvm/llvm-project/commit/22e199e6afb1263c943c0c0d4498694e15bf8a16.diff

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. LGTM, and the summary of the discussion in the sync-up call matches my understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 ___

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. Hmm...looking at some of the commits to the related code, it might be very intentional that we don't warn symmetrically: 938533db602b32ab435078e723b656ac6e779a1b e54ff6cc3e479523b71e4c7eb4bd13707d84de0f Comment at: clang/test/SemaCXX/expressio

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added inline comments. Comment at: clang/test/SemaCXX/expressions.cpp:146-148 #define Y2 2 bool r2 = X || Y2; // expected-warning {{use of logical '||' with constant operand}} \ // expected-note {{use '|' for a bitwise operation}}

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:625 +// same spelling. +static std::vector patchDiags(llvm::ArrayRef BaselineDiags, +const ScannedPreamble &BaselineScan, I think this function

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:548 + EXPECT_EQ("#include \"a.h\"\n" +"#include \"llvm/a.h\"\n" +"#include \"b.h\"\n" Febbe wrote: > HazardyKnusperkeks wrote: > > While I m

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. In D142907#4132430 , @arsenm wrote: > I was thinking of changing the default in general to dynamic. I was going to > at least change the strictfp default in a follow up I had the same thought too, but I reflected a little

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 498118. qiongsiwu1 added a comment. Rebase to resolve clang release note conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes

[PATCH] D144136: Add a "remark" to report on array accesses

void added a comment. In D144136#4131825 , @aaron.ballman wrote: > I'd like to understand what the overhead is for this. How much overhead does > this add when the remark is disabled? How much overhead does this add when > the remark is enabled? > >> T

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL published this revision for review. PiotrZSL added a comment. Herald added a project: clang-tools-extra. Herald ad

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

dblaikie added a comment. Ah, accidentally posted to the lldb part of this stack... instead: Any chance we can make these work more like member functions (could the ctors include their mangled names, for instance)? Or is it the innate nature of ctors having the various C1

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. In D144181#4133025 , @dblaikie wrote: > Ah, accidentally posted to the lldb part of this stack... instead: > > Any chance we can make these work more like member functions (could the ctors > include their mangled names, for in

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

mikecrowe created this revision. mikecrowe added a reviewer: njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In preparation for using the imp

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe updated this revision to Diff 498136. mikecrowe edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp clang-tools-extra/doc

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe marked 2 inline comments as done. mikecrowe added a comment. I ended up splitting out the std::format and std::print tests to their own file which meant that I didn't need to modify the existing `redundant-string-cstr.cpp` file in this commit. (Though of course I had to extract the h

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498138. DmitryPolukhin added a comment. Add test for expanded response files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. @nridge I'm sorry, I pushed version without all tests. Now I added test case for response files, it seems that clangd hasn't had it before this patch. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:222 + tooling::addExpandedResponseFi

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath created this revision. mysterymath added reviewers: aaron.ballman, aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For AVR, the definit

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

shafik added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4572 : Sema::ExpressionEvaluationContext::ConstantEvaluated, -/*LambdaContextDecl=*/nullptr, /*ExprContext=*/ +Sema::ReuseLambdaContextDecl, /*ExprContext=*/ Sema::Ex

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:548 + EXPECT_EQ("#include \"a.h\"\n" +"#include \"llvm/a.h\"\n" +"#include \"b.h\"\n" HazardyKnusperkeks wrote: > Febbe wrote: > > HazardyKnusperkeks wro

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 498140. DmitryPolukhin added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp cla

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4572 : Sema::ExpressionEvaluationContext::ConstantEvaluated, -/*LambdaContextDecl=*/nullptr, /*ExprContext=*/ +Sema::ReuseLambdaContextDecl, /*ExprContext=*/ Sema

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

shafik added a comment. So we are only checking global constructors b/c it is valid in a constant expression context to initialize a record and not initialize all their fields as long as we don't use any of those fields. Note, cases that stem from this has been discussed as part of https://git

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140723/new/ https://reviews.llvm.org/D140723 ___

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao updated this revision to Diff 498145. shangwuyao added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGenC

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 498156. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/li

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 498157. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst clang/doc

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 498158. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp

[PATCH] D143205: [clang] add __has_extension(gnu_asm_goto_with_outputs_full)

nickdesaulniers updated this revision to Diff 498159. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143205/new/ https://reviews.llvm.org/D143205 Files: clang/docs/LanguageExtensions.rst clang/inc

[PATCH] D143670: Stop claiming we support [[carries_dependency]]

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:51 // FIXME(201806L) CHECK: assert: 0 -// CHECK: carries_dependency: 200809L +// CHECK: carries_dependency: 0 // CHECK: deprecated: 201309L aaron.ballman wrote:

[PATCH] D143301: [flang] Handle unsupported warning flags

elmcdonough updated this revision to Diff 498164. elmcdonough added a comment. Change multiclass name for the sake of clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143301/new/ https://reviews.llvm.org/D143301 Files: clang/include/clang/

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

pkubaj created this revision. pkubaj added reviewers: dim, nemanjai, adalava. Herald added subscribers: shchenz, kbarton, hiraditya. Herald added a project: All. pkubaj requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Curre

  1   2   >