shafik added inline comments.

================
Comment at: clang/lib/Sema/TreeTransform.h:4572
                : Sema::ExpressionEvaluationContext::ConstantEvaluated,
-        /*LambdaContextDecl=*/nullptr, /*ExprContext=*/
+        Sema::ReuseLambdaContextDecl, /*ExprContext=*/
         Sema::ExpressionEvaluationContextRecord::EK_TemplateArgument);
----------------
Not for this PR but I am looking at other place we use 
`EnterExpressionEvaluationContext` and it is not obvious to me when we should 
be using `Sema::ReuseLambdaContextDecl` or not. So might be worth looking at 
other uses as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144192/new/

https://reviews.llvm.org/D144192

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to