[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1511 + /// element type + QualType getWasmTableType(QualType EltTy) const; + Ah, I suggested `WebAssembly` in another review, but `Wasm` is also fine by me -- just pick a con

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4041308 , @aaron.ballman wrote: > Is your concern essentially that someone will add a new use to put files in a > temp directory and not have access to this information from ASTUnit? Or do > you have other concerns in

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6711 + // Prepare FDecl type + QualType Pointee = Context.getFunctionType(Context.VoidTy, {}, {}); + QualType Type = Context.getPointerType(Pointee); erichkeane wrote: > aaron.bal

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:139 - // if it's a lambda expression, return an error message - if (isa(*DeducedType) && - cast(*DeducedType)->getDecl()->isLambda()) { -return error("Could

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve updated this revision to Diff 488233. fdeazeve added a comment. Herald added subscribers: kosarev, jvesely. Change codegen to no longer depend on -g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141381/new/ https://reviews.llvm.org/D141381

[clang] 56ebfca - [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

Author: Joseph Huber Date: 2023-01-11T10:30:30-06:00 New Revision: 56ebfca4bcc0e7a54989ad7aea5395b27f67e373 URL: https://github.com/llvm/llvm-project/commit/56ebfca4bcc0e7a54989ad7aea5395b27f67e373 DIFF: https://github.com/llvm/llvm-project/commit/56ebfca4bcc0e7a54989ad7aea5395b27f67e373.diff

[clang] a17ab7a - [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

Author: Joseph Huber Date: 2023-01-11T10:30:38-06:00 New Revision: a17ab7aa3be0b2b2adf992e3754a58f17802491f URL: https://github.com/llvm/llvm-project/commit/a17ab7aa3be0b2b2adf992e3754a58f17802491f DIFF: https://github.com/llvm/llvm-project/commit/a17ab7aa3be0b2b2adf992e3754a58f17802491f.diff

[clang] fada902 - [CUDA][HIP] Support '--offload-arch=native' for the new driver

Author: Joseph Huber Date: 2023-01-11T10:30:34-06:00 New Revision: fada90286008b52a59ff13b15675032787501001 URL: https://github.com/llvm/llvm-project/commit/fada90286008b52a59ff13b15675032787501001 DIFF: https://github.com/llvm/llvm-project/commit/fada90286008b52a59ff13b15675032787501001.diff

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGfada90286008: [CUDA][HIP] Support '--offload-arch=native' for the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D141078?vs=486741&id=488237#toc Repository: rG LL

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56ebfca4bcc0: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa17ab7aa3be0: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading (authored by jhuber6). Repository: rG LLVM Github Monorepo CH

[clang] 0d9afee - [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

Author: Joseph Huber Date: 2023-01-11T10:31:47-06:00 New Revision: 0d9afee3d159f5b7cdac7637808f3e25ff16a536 URL: https://github.com/llvm/llvm-project/commit/0d9afee3d159f5b7cdac7637808f3e25ff16a536 DIFF: https://github.com/llvm/llvm-project/commit/0d9afee3d159f5b7cdac7637808f3e25ff16a536.diff

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9afee3d159: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode (authored by jhuber6). Repository: rG LLVM Github Monorep

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added subscribers: sbc100, ruiu, lhames. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:451 +- Add ``-Wcompare-function-pointers`` to warn about comparisons that may have + their behavior change when using ``icf=all``. --

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. In D141381#4040639 , @probinson wrote: > To get data about the code size impact, people typically build some large > codebase with/without their patch and compare the .text sizes. It's common to > use clang itself for this expe

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428 F->addFnAttr(llvm::Attribute::NoUnwind); + F->addFnAttr(llvm::Attribute::Convergent); yaxunl wrote: > How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as be

[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

dmgreen added a comment. In D141411#4042891 , @lenary wrote: > Can we check this logic, especially around adding both AEK_SVE and AEK_SVE2 > in the `AARCH64_ARCH` descriptions, this means that `-march=armv9-a+nosve2` > still can generate sve instruction

[clang] a18fe67 - [AMDGCN] Update search path for device libraries

Author: Siu Chi Chan Date: 2023-01-11T11:51:30-05:00 New Revision: a18fe67b9fcf3eb5cdaf8bbd4496f8653e4fc2b5 URL: https://github.com/llvm/llvm-project/commit/a18fe67b9fcf3eb5cdaf8bbd4496f8653e4fc2b5 DIFF: https://github.com/llvm/llvm-project/commit/a18fe67b9fcf3eb5cdaf8bbd4496f8653e4fc2b5.diff

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 488246. fahadnayyar added a comment. Moving the libunwind change to a separate patch and some refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 Files:

[PATCH] D140315: [AMDGCN] Update search path for device libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18fe67b9fcf: [AMDGCN] Update search path for device libraries (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://revie

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:139 - // if it's a lambda expression, return an error message - if (isa(*DeducedType) && - cast(*DeducedType)->getDecl()->isLambda()) { -return error("Could no

[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:545 } + // Match behavior for clang-tidy --system-headers=0 (the default). + if (Info.hasSourceManager() && nridge wrote: > Why not check `CTContext->

[clang] d32d749 - [Clang] Add requires flags to test using Linux command line

Author: Joseph Huber Date: 2023-01-11T11:03:09-06:00 New Revision: d32d749b11401cef214e3fd7b3814071d9e1e5a7 URL: https://github.com/llvm/llvm-project/commit/d32d749b11401cef214e3fd7b3814071d9e1e5a7 DIFF: https://github.com/llvm/llvm-project/commit/d32d749b11401cef214e3fd7b3814071d9e1e5a7.diff

[clang-tools-extra] 9b16c62 - [clangd] Respect clang-tidy SystemHeaders option if specified

Author: Sam McCall Date: 2023-01-11T18:04:42+01:00 New Revision: 9b16c624edde50e2a460f9bd0d2e9ac3cb1af695 URL: https://github.com/llvm/llvm-project/commit/9b16c624edde50e2a460f9bd0d2e9ac3cb1af695 DIFF: https://github.com/llvm/llvm-project/commit/9b16c624edde50e2a460f9bd0d2e9ac3cb1af695.diff LO

[clang] d5ac28e - [OpenMP] Fix unused capature and name

Author: Joseph Huber Date: 2023-01-11T11:05:24-06:00 New Revision: d5ac28efffa77191a65cacc25a39edfdef2ecc1a URL: https://github.com/llvm/llvm-project/commit/d5ac28efffa77191a65cacc25a39edfdef2ecc1a DIFF: https://github.com/llvm/llvm-project/commit/d5ac28efffa77191a65cacc25a39edfdef2ecc1a.diff

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added a comment. Moved the libunwind change to this separate patch: https://reviews.llvm.org/D141515 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 __

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

thakis added inline comments. Comment at: llvm/include/llvm/TargetParser/CMakeLists.txt:3 +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/) +add_public_tablegen_target(RISCVTargetParserTableGen) + All other t

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

dmgreen added a comment. Do you know why this code is in the Driver? I would have expected mandatory features to be added to the AARCH64_ARCH in AArch64TargetParser.td. I don't think they are then needed in the driver. I can put up a patch to show what I mean, as I think the same applies to i8

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

craig.topper added inline comments. Comment at: clang/docs/ReleaseNotes.rst:792 - Native detections via ``-mcpu=native`` and ``-mtune=native`` are supported. +- Fix interaction of ``-mcpu`` and ``-march``, RISC-V back-end will take the + architecture extension union of ``-mcpu`

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

dmgreen added a comment. I've put up D141518 to move the existing features. Let me know what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141404/new/ https://reviews.llvm.org/D141404 _

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry updated this revision to Diff 488265. v1nh1shungry added a comment. address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141226/new/ https://reviews.llvm.org/D141226 Files: clang-tools-extra/clangd/refactor/tweaks/CMak

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; aaron.ballman wrote: >

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added subscribers: MaskRay, dblaikie. aaron.ballman added a comment. In D139774#4043886 , @vedgy wrote: > In D139774#4041308 , @aaron.ballman > wrote: > >> Is your concern essentially that someone w

[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

dmgreen added a comment. It does look like this might be enabling Crypto in places it was not in the past though. I'll look into why that is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141411/new/ https://reviews.llvm.org/D141411 _

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:105 + " cui - cuda-cpp-output\n" + " hipi - hip-cpp-outpu\n" +

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

Jake-Egan added a comment. Getting a build failure on AIX, could you take a look please? /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: error: lambda capture 'C' is not used [-Werror,-Wunused-lambda-capture] auto IsHIPRDCInCompi

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added a comment. In D141440#4044300 , @Jake-Egan wrote: > Getting a build failure on AIX, could you take a look please? > > > /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: > error: la

[clang] 12bf816 - Speculatively fix the Clang sphinx build

Author: Aaron Ballman Date: 2023-01-11T13:10:25-05:00 New Revision: 12bf8165d5c8522d93d0fc92811f280def87eb17 URL: https://github.com/llvm/llvm-project/commit/12bf8165d5c8522d93d0fc92811f280def87eb17 DIFF: https://github.com/llvm/llvm-project/commit/12bf8165d5c8522d93d0fc92811f280def87eb17.diff

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; adriandole wrote: >

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

MaskRay added a comment. (Haven't looked carefully ) but the Pipeline model: matches AArch64 (ideal model in my view https://community.arm.com/arm-community-blogs/b/tools-software-ides-blog/posts/compiler-flags-across-architectures-march-mtune-and-mcpu) (I probably need to update my https://mas

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:105 + " cui - cuda-cpp-output\n" + " hipi - hip-cpp-outpu\n" + " d- dependency\n" ---

[clang] c0a5374 - Another round of speculative fixes for Clang sphinx

Author: Aaron Ballman Date: 2023-01-11T13:27:33-05:00 New Revision: c0a5374140262786a9f23aa5975f22ad4eec3b85 URL: https://github.com/llvm/llvm-project/commit/c0a5374140262786a9f23aa5975f22ad4eec3b85 DIFF: https://github.com/llvm/llvm-project/commit/c0a5374140262786a9f23aa5975f22ad4eec3b85.diff

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< aaron.ballman wrote:

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

aaron.ballman added a comment. Assuming my understanding is correct, this LGTM! Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); Am I correct in unders

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. Any reason this hasn't been pushed yet? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D141310: [clang] add -Wcompare-function-pointers

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< cjdb wrote:

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth added a comment. @thegameg I think I finally understood what you meant re: multi-line remarks. Sorry for the back/forth on that, it just didn't click for me until you commented on the screenshot. BTW, is there a way to nest some of the items? Ideally we'd be able to have a `Slot` in

[PATCH] D140489: Add builtin_elementwise_log

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:638 T __builtin_elementwise_floor(T x) return the largest integral value less than or equal to xfloating point types + T __builtin_elementwise_log(T x)return the natur

[PATCH] D141310: [clang] add -Wcompare-function-pointers

tschuett added subscribers: MaskRay, tschuett. tschuett added a comment. @MaskRay Dependent of the build flags, we decide which warnings to enable or not? Do we have other warnings for ThinLTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141310/

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Assuming pre-commit CI is happy, this LGTM aside from a few minor things. Comment at: clang/lib/Sema/SemaChecking.cpp:13516-13517 + /// Analyze the given compo

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM with a comment nit, thank you! Do you have commit access? Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:151 + + // We shouldn't repla

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4044437 , @paulkirth wrote: > BTW, is there a way to nest some of the items? Ideally we'd be able to have a > `Slot` in the YAML that contains all the various data, similar to how > `DebugLoc` is a more complex objec

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:151 + + // We shouldn't replace types like function and array, the commonality between + // these cases is that they use C-style declarator syntax that may have chunks

[clang] bc3edb6 - [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

Author: Haowei Wu Date: 2023-01-11T11:02:58-08:00 New Revision: bc3edb6272010320e601e7cf7153db617e4d616f URL: https://github.com/llvm/llvm-project/commit/bc3edb6272010320e601e7cf7153db617e4d616f DIFF: https://github.com/llvm/llvm-project/commit/bc3edb6272010320e601e7cf7153db617e4d616f.diff LOG

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3edb627201: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/ https://

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry updated this revision to Diff 488297. v1nh1shungry added a comment. modify the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141226/new/ https://reviews.llvm.org/D141226 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeL

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry marked 2 inline comments as done. v1nh1shungry added a comment. Thank you for reviewing and giving guidance! > Do you have commit access? I don't. If this patch is okay to land, could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141528: [Clang][OpenMP] Fix loop directed nested inside a parallel

doru1004 created this revision. doru1004 added reviewers: ronl, carlo.bertolli, ABataev, jdoerfert, jhuber6, gregrodgers. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added subscribers:

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry added a comment. Thank you for reviewing, @cjdb and @denik! If this patch is okay to land, could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107 _

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. Hello browneee, Thank you very much for the comments! I will take a closer look at the issue you pointed out. Do you prefer me to send a couple of diffs (one per each function) at once or one by one? Kind regards, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 488310. nickdesaulniers added a comment. - update optimize test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://reviews.llvm.org/D141451 Files: clang/include/clang/Basic/DiagnosticF

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

dblaikie added a comment. > This is a problem because some existing ObjectiveC code is not compatible > with LSV Hmm, how is that true? Does this code only build with Clang Header Modules enabled, and can't build without that? (if it could build without it, I don't know why it'd need LSV, if I

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488314. paulkirth added a comment. Address comments. - document what ValOffset is used for - remove dead code - fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D13

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 488315. nickdesaulniers added a comment. - use std::string, demangle C++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://reviews.llvm.org/D141451 Files: clang/include/clang/Basic/Di

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

sammccall added a comment. Sorry about the delay on this. This looks useful - I know a lot of people write comments in this style, whatever my own reservations :-) Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:30 +// Given: +// int func(int x, ch

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7865 +const Stmt *CS = cast(S.getAssociatedStmt())->getCapturedStmt(); +if (CS->getStmtClass() == Stmt::ForStmtClass) { + const ForStmt &ForS = cast(*CS); ``` if (const au

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} lebedev.ri wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > aaron.ballman wrot

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Looks great with the leftover minor changes, feel free to land this, thanks! I'll give this a try internally and provide feedback if any. Comment at: llvm/lib/CodeGen/St

[PATCH] D141537: [clangd] Tag clang-tidy diagnostics: modernize-*=deprecated, misc-unused-*=unneccesary

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a reviewer: njames93. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm added a comment. In D141447#4042273 , @yaxunl wrote: > need a test This is NFC, this is just fixing the API for the next commit I haven't posted yet CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D14

[PATCH] D141528: [Clang][OpenMP] Fix loop directive nested inside a parallel

jdoerfert added a comment. Drive by. Comment at: clang/test/OpenMP/nested_loop_codegen.cpp:32 + +int internal_decl() { + int i, res; Internal? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141528/new/ https://r

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

nhat-nguyen updated this revision to Diff 488332. nhat-nguyen added a comment. Herald added projects: clang, MLIR, LLVM, Flang. Herald added subscribers: llvm-commits, cfe-commits. Rebase and remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488338. paulkirth added a comment. - Actually remove dead code - Update pass description to be more accurate - fix typo - update enum member name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ http

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 488339. bob80905 added a comment. Herald added a reviewer: NoQ. - replace sin fxn with log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 Files: clang/docs/Langua

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

aaron.ballman added a comment. In D140860#4031872 , @dblaikie wrote: > The risk now is that this might significantly regress/add new findings for > this warning that may not be sufficiently bug-finding to be worth immediate > cleanup, causing users to h

[PATCH] D141538: [cmake] Fix path to LLVMConfig.cmake for multi-config builds

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jdoerfert. Thanks for fixing the whitespace as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141538/

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added a comment. In D139737#4042093 , @NoQ wrote: > It sounds to me as if by landing the patch we'll temporarily make the > compiler emit incorrect fixes. I think we should avoid doing that. Is it > possible to wait until our first proof-of-conc

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 488343. lebedev.ri marked an inline comment as done. lebedev.ri edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138958/new/ https://reviews.llvm.org/D138958 Files: clang-t

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 488344. serge-sans-paille added a comment. Nits + rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files: clang/lib/Driver/DriverOptions.cpp clang/lib/Driver/ToolChains/G

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added a comment. In D140800#4043723 , @nikic wrote: > Just to check, this isn't going to cause some warning spew about all those > OptTable implementations being non-final? nope. Why

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

serge-sans-paille updated this revision to Diff 488348. serge-sans-paille added a comment. nits + rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140699/new/ https://reviews.llvm.org/D140699 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/DriverOptions.c

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 488355. nickdesaulniers added a comment. - update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://reviews.llvm.org/D141451 Files: clang/include/clang/Basic/DiagnosticFrontendK

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 488356. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - remove test comment in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://re

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

dblaikie added a comment. In D141381#4043985 , @fdeazeve wrote: > In D141381#4040639 , @probinson > wrote: > >> To get data about the code size impact, people typically build some large >> codebase with/without

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; aaron.ballman wrote: >

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, arsenm, tianshilei1992. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Curr

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.push

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added a comment. Missing test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D141310: [clang] add -Wcompare-function-pointers

MaskRay added a comment. I have some notes about `--icf={safe,all}`: https://maskray.me/blog/2020-11-15-explain-gnu-linker-options#icfall-and---icfsafe I think this diagnostic has some value (and I appreciate that it can be implemented so little code!). Some `--icf=all` issues like using functi

[clang] b4ad387 - [clang-format][doc] Fix C++ code blocks for IntegerLiteralSeparator

Author: Owen Pan Date: 2023-01-11T13:24:39-08:00 New Revision: b4ad387ec558dc886c2ab85e4aea10c111cc83c0 URL: https://github.com/llvm/llvm-project/commit/b4ad387ec558dc886c2ab85e4aea10c111cc83c0 DIFF: https://github.com/llvm/llvm-project/commit/b4ad387ec558dc886c2ab85e4aea10c111cc83c0.diff LOG:

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers updated this revision to Diff 488360. nickdesaulniers added a comment. - add tests for alwaysinline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141451/new/ https://reviews.llvm.org/D141451 Files: clang/include/clang/Basic/Diagn

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:2467-2468 + +const Function *Callee = CI->getCalledFunction(); +if (Callee && (Callee->hasFnAttribute("dontcall-error") || + Callee->hasFnAttribute("dontca

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488361. jhuber6 added a comment. Herald added a subscriber: sstefan1. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrap

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); + CmdArgs.pus

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5736 + C.getArgs().hasArg(options::OPT_fmodule_output) && + C.getArgs().hasArg(options::OPT_o)) { +SmallString<128> OutputPath; ChuanqiXu wrote: > dblaikie wrote: > > Is there s

[PATCH] D141175: [bazel] Split out Annotations from `TestingSupport`

rupprecht updated this revision to Diff 488366. rupprecht added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman, hiraditya. Herald added projects: clang, clang-tools-extra. - Move annotations to a separate package entirely Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added a comment. Sonar ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D141175: [bazel] Split out Annotations from `TestingSupport`

rupprecht added a comment. In D141175#4038017 , @GMNGeoffrey wrote: > It seems like the same logic would extend to the CMake build. Could we make > the same change there? The simplest (only?) way to do that is to have it literally in a separate direct

<    1   2   3   >