thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.
Looks great with the leftover minor changes, feel free to land this, thanks!
I'll give this a try internally and provide feedback if any.
================
Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:55
+ Variable, // a Slot used to store a local data (could be a tmp)
+ Error // Its an error for a slot to have this type
+ };
----------------
paulkirth wrote:
> thegameg wrote:
> >
> Good catch! TY
I also suggested `Invalid` instead of `Error` but it's up to you.
================
Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:110
+
+ std::string genStackOffsetPrefix(int I) const {
+ // Negative offsets will print a leading `-`, so only add `+`
----------------
paulkirth wrote:
> thegameg wrote:
> > Is this still worth being a separate function?
> yeah, probably not
Looks like this stayed around unused
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135488/new/
https://reviews.llvm.org/D135488
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
