thakis added inline comments.
================
Comment at: llvm/include/llvm/TargetParser/CMakeLists.txt:3
+tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I
${CMAKE_SOURCE_DIR}/lib/Target/RISCV/)
+add_public_tablegen_target(RISCVTargetParserTableGen)
+
----------------
All other target tablegen'ing for all other targets (also for RISCV for other
.td changes) happen in llvm/lib/Target, not in llvm/TargetParser. Is there any
way this could be structured that way too? As-is, the layering looks pretty
unusual. (And your reland had to teach clang about tablegen targets for that
reason.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137517/new/
https://reviews.llvm.org/D137517
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
