jhuber6 added inline comments.

================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537
+  CmdArgs.push_back(*ClangPath);
+  CmdArgs.push_back("-o");
+  CmdArgs.push_back(*TempFileOrErr);
+  CmdArgs.push_back("-fPIC");
+  CmdArgs.push_back("-c");
+  CmdArgs.push_back(Args.MakeArgString("--target=" + Triple.getTriple()));
+  CmdArgs.push_back(Args.MakeArgString("-" + OptLevel));
----------------
arsenm wrote:
> can use initializer list?
Probably could, this is the same style we use in `Clang.cpp` so I usually end 
up using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141543/new/

https://reviews.llvm.org/D141543

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to