[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:97 def getListOfFiles(clang_tidy_path): - files = glob.glob(os.path.join(clang_tidy_path, '*')) - for dirname in files: -if os.path.isdir(dirname): - files += glob.glob(os.path.joi

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:97 def getListOfFiles(clang_tidy_path): - files = glob.glob(os.path.join(clang_tidy_path, '*')) - for dirname in files: -if os.path.isdir(dirname): - files += glob.glob(os.pa

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 488093. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files: clang/in

[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0127bb9f00: [AArch64] Make -march and target(arch=..) attributes imply dependent features (authored by dmgreen). Herald added a project: clang. Her

[clang] 0c0127b - [AArch64] Make -march and target(arch=..) attributes imply dependent features

Author: David Green Date: 2023-01-11T08:48:23Z New Revision: 0c0127bb9f0098752a9769748511e170ed240695 URL: https://github.com/llvm/llvm-project/commit/0c0127bb9f0098752a9769748511e170ed240695 DIFF: https://github.com/llvm/llvm-project/commit/0c0127bb9f0098752a9769748511e170ed240695.diff LOG: [

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

clementval added a comment. You should have a look at https://mlir.llvm.org/docs/PassManagement/#instance-specific-pass-options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___

[PATCH] D141467: [clang][Driver][CUDA] Get rid of unused LibPath

kadircet created this revision. kadircet added a reviewer: tra. Herald added subscribers: mattd, yaxunl. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. LibPath discovered during InstallationDet

[clang] cf7a830 - [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

Author: Francesco Petrogalli Date: 2023-01-11T10:00:04+01:00 New Revision: cf7a8305a2b4ddfd299c748136cb9a2960ef7089 URL: https://github.com/llvm/llvm-project/commit/cf7a8305a2b4ddfd299c748136cb9a2960ef7089 DIFF: https://github.com/llvm/llvm-project/commit/cf7a8305a2b4ddfd299c748136cb9a2960ef708

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7a8305a2b4: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[clang] 8bd65e5 - Revert "[TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen."

Author: Francesco Petrogalli Date: 2023-01-11T10:22:56+01:00 New Revision: 8bd65e535fb33bc48805bafed8217b16a853e158 URL: https://github.com/llvm/llvm-project/commit/8bd65e535fb33bc48805bafed8217b16a853e158 DIFF: https://github.com/llvm/llvm-project/commit/8bd65e535fb33bc48805bafed8217b16a853e15

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. @aaron.ballman Hi Aaron, since you requested an RFC for this. I wonder if you have any comments for this or the other related patches: D122215 , D139010 Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews added a comment. In D141375#4041360 , @bader wrote: > LGTM. > I expect this to be a common issue for all single-source offloading > programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP > offload). Probably we can generalize the

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. After submitting this, I had to revert it because of failures like https://lab.llvm.org/buildbot/#/builders/225/builds/12367/steps/5/logs/stdio Repository: rG LLVM Github Mono

[PATCH] D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests.

david-arm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9092 + if (BytesPerElt > 1) { +Value *Scale = ConstantInt::get(Int64Ty, Log2_32(BytesPerElt)); +Ops[2] = Builder.CreateShl(Ops[2], Scale); Given this seems a frequen

[PATCH] D140547: Perform access checking to private members in simple requirement.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547

[clang] 1bb8021 - [AArch64] Add REQUIRES: aarch64-registered-target to aarch64-targetattr-arch.c. NFC

Author: David Green Date: 2023-01-11T10:10:01Z New Revision: 1bb80214b63007784d7eab93835ebc4ac5da7b69 URL: https://github.com/llvm/llvm-project/commit/1bb80214b63007784d7eab93835ebc4ac5da7b69 DIFF: https://github.com/llvm/llvm-project/commit/1bb80214b63007784d7eab93835ebc4ac5da7b69.diff LOG: [

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a `FunctionPointer` class as well as a ne

[clang] ac1ffd3 - [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

Author: Francesco Petrogalli Date: 2023-01-11T11:18:44+01:00 New Revision: ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf URL: https://github.com/llvm/llvm-project/commit/ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf DIFF: https://github.com/llvm/llvm-project/commit/ac1ffd3caca12c254e0b8c847aa8ce8e51b6cfb

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. In D137517#4042758 , @fpetrogalli wrote: > After submitting this, I had to revert it > > because of failures like > https://lab.llvm.or

[PATCH] D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features

lenary added a comment. Can we check this logic, especially around adding both AEK_SVE and AEK_SVE2 in the `AARCH64_ARCH` descriptions, this means that `-march=armv9-a+nosve2` still can generate sve instructions. I'm not entirely sure of the intended behaviour there, especially as sve2 should m

[clang] 8b301b4 - [clang][Interp][NFC] Print Pointee address of Pointer

Author: Timm Bäder Date: 2023-01-11T12:01:32+01:00 New Revision: 8b301b4f6b3d7068fd81f88ac001916c2f138c33 URL: https://github.com/llvm/llvm-project/commit/8b301b4f6b3d7068fd81f88ac001916c2f138c33 DIFF: https://github.com/llvm/llvm-project/commit/8b301b4f6b3d7068fd81f88ac001916c2f138c33.diff LO

[PATCH] D141477: [include-mapping] Fix the instructions for running stdlib recognizer. Mention python command explicitly. Remove angle brackets.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141477 Files: clang/tools/include-mapping/gen_std.py I

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. HeaderSearch uses FileEntry::getName() to determine the best sp

[clang] 9e0474f - Perform access checking to private members in simple requirement.

Author: Utkarsh Saxena Date: 2023-01-11T12:13:16+01:00 New Revision: 9e0474fbb9c56725a1dfd1658837f07db73f4d8d URL: https://github.com/llvm/llvm-project/commit/9e0474fbb9c56725a1dfd1658837f07db73f4d8d DIFF: https://github.com/llvm/llvm-project/commit/9e0474fbb9c56725a1dfd1658837f07db73f4d8d.diff

[PATCH] D140547: Perform access checking to private members in simple requirement.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e0474fbb9c5: Perform access checking to private members in simple requirement. (authored by usaxena95). Changed prior to commit: https://reviews.

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder updated this revision to Diff 488135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Inter

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 488138. v1nh1shungry added a comment. add `LLVM_READONLY` to `getSourceRange()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files: clang/include/clang/AST/

[clang] 1b1d8ac - [clang-format][doc] Fix doc format for IntegerLiteralSeparator

Author: Owen Pan Date: 2023-01-11T03:23:34-08:00 New Revision: 1b1d8acdfa1e8fc5bc64ffd982bb689e308d6c20 URL: https://github.com/llvm/llvm-project/commit/1b1d8acdfa1e8fc5bc64ffd982bb689e308d6c20 DIFF: https://github.com/llvm/llvm-project/commit/1b1d8acdfa1e8fc5bc64ffd982bb689e308d6c20.diff LOG:

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder updated this revision to Diff 488139. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Funct

[clang] 75c0d43 - [docs] Add newline in clang release notes.

Author: Utkarsh Saxena Date: 2023-01-11T12:28:59+01:00 New Revision: 75c0d43e857dd6e61e9c354284347144b428f44a URL: https://github.com/llvm/llvm-project/commit/75c0d43e857dd6e61e9c354284347144b428f44a DIFF: https://github.com/llvm/llvm-project/commit/75c0d43e857dd6e61e9c354284347144b428f44a.diff

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

krasimir added a comment. > Was it actually a regression or did this patch also fix a bug? It seems that > the continuation indent before the & in your example is inconsistent with > other similar function declarations. Nice catch! I fully agree with you! Thank you for looking into this, sorry

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD updated this revision to Diff 488140. eopXD edited the summary of this revision. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://

[clang] 922c889 - Revert "Revert "[clang-format] Add an option for breaking after C++11 attributes""

Author: Krasimir Georgiev Date: 2023-01-11T11:30:30Z New Revision: 922c8891d9916fa094147c5c793291f97a83c84c URL: https://github.com/llvm/llvm-project/commit/922c8891d9916fa094147c5c793291f97a83c84c DIFF: https://github.com/llvm/llvm-project/commit/922c8891d9916fa094147c5c793291f97a83c84c.diff

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4042990 , @krasimir wrote: >> Was it actually a regression or did this patch also fix a bug? It seems that >> the continuation indent before the & in your example is inconsistent with >> other similar function declara

[clang] 83c5040 - [include-mapping] Fix the instructions for running stdlib recognizer. Mention python command explicitly. Remove angle brackets.

Author: Viktoriia Bakalova Date: 2023-01-11T11:35:53Z New Revision: 83c5040f6f3234a1fbf705b4aebe3ec1cf9d3bf6 URL: https://github.com/llvm/llvm-project/commit/83c5040f6f3234a1fbf705b4aebe3ec1cf9d3bf6 DIFF: https://github.com/llvm/llvm-project/commit/83c5040f6f3234a1fbf705b4aebe3ec1cf9d3bf6.diff

[PATCH] D141477: [include-mapping] Fix the instructions for running stdlib recognizer. Mention python command explicitly. Remove angle brackets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83c5040f6f32: [include-mapping] Fix the instructions for running stdlib recognizer. Mention… (authored by VitaNuo). Repository: rG LLVM Github Mon

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

eopXD updated this revision to Diff 488144. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140936/new/ https://reviews.llvm.org/D140936 Files: clang/in

[clang] 3696941 - [clang][Interp][NFC] Add an assertion

Author: Timm Bäder Date: 2023-01-11T13:05:14+01:00 New Revision: 3696941dae5cc5bb379c50eae6190e29f7edbbb1 URL: https://github.com/llvm/llvm-project/commit/3696941dae5cc5bb379c50eae6190e29f7edbbb1 DIFF: https://github.com/llvm/llvm-project/commit/3696941dae5cc5bb379c50eae6190e29f7edbbb1.diff LO

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD updated this revision to Diff 488150. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 Files: clang/in

[clang] 78a9ee7 - [clang][Interp][NFC] Remove code duplication in VisitRecordInitializer

Author: Timm Bäder Date: 2023-01-11T13:08:51+01:00 New Revision: 78a9ee7834331fb4360457cc565fa36f5452f7e0 URL: https://github.com/llvm/llvm-project/commit/78a9ee7834331fb4360457cc565fa36f5452f7e0 DIFF: https://github.com/llvm/llvm-project/commit/78a9ee7834331fb4360457cc565fa36f5452f7e0.diff LO

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

eopXD updated this revision to Diff 488152. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 Files: clang/in

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2260 -return CGF.CGM.getNullPointer(cast(ConvertType(DestTy)), - DestTy); +// The type may be a target extension type instead of a pointer type +// (e.g., Op

[clang] d3b5634 - Speculatively fix the Clang sphinx build

Author: Aaron Ballman Date: 2023-01-11T07:32:55-05:00 New Revision: d3b563444606b5d9a45c74eb60e7ebbcb97cc711 URL: https://github.com/llvm/llvm-project/commit/d3b563444606b5d9a45c74eb60e7ebbcb97cc711 DIFF: https://github.com/llvm/llvm-project/commit/d3b563444606b5d9a45c74eb60e7ebbcb97cc711.diff

[PATCH] D141432: Add two additional float8 types to MLIR and APFloat.

jakeh-gc added a comment. The build failure is for clang-format on `APFloat.cpp`. That file has an unusual indentation, so I don't believe I can make that pass without reformatting the whole file. I believe doing that would make this diff harder to review. Repository: rG LLVM Github Monorep

[PATCH] D141297: [OpenCL] Allow undefining header-only features

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, thanks! Btw I wonder if in the future we could add some error or warning in case someone uses the same approach for frontend specific features, i.e. #ifdef __undef___opencl_c_ge

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

eopXD updated this revision to Diff 488156. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 Files: clang/in

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

hokein added a comment. Thanks for tracking it down. The solution looks good to me. Since this is a fragile and subtle issue, is it possible to have a unittest for it? If it is not too hard, it would be nice to have a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12426 // FIXME: Apply default attributes F->addFnAttr(llvm::Attribute::NoUnwind); If `ConstructDefaultFnAttrList` was used it would get convergent correctly... Should we be usi

[clang] 800f0f1 - [docs] Apply previous sphinx fix to its actual source

Author: Emilia Dreamer Date: 2023-01-11T14:44:36+02:00 New Revision: 800f0f1546b2352ba42a4777149afb13cb874fcd URL: https://github.com/llvm/llvm-project/commit/800f0f1546b2352ba42a4777149afb13cb874fcd DIFF: https://github.com/llvm/llvm-project/commit/800f0f1546b2352ba42a4777149afb13cb874fcd.diff

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 488157. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/in

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 488158. junaire added a comment. Make build bots happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 488159. sepavloff added a comment. Remove support of __builtin_is{subnormal,zero,signaling}, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/

Re: [clang] 8bd65e5 - Revert "[TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen."

Reminder to please always mention the reason for the revert/recommit in the commit message. On Wed, Jan 11, 2023 at 12:23 PM Francesco Petrogalli via cfe-commits wrote: > > > Author: Francesco Petrogalli > Date: 2023-01-11T10:22:56+01:00 > New Revision: 8bd65e535fb33bc48805bafed8217b16a853e158 >

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" v1nh1shungry wrot

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4411 ++TCAndArch; } } JonChesterfield wrote: > Why is rdc involved here? HIP goes straight through a separate linker phase in non-RDC mode. Setting the type here would pr

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. Thanks for the reply! I'll raise a GitHub issue. > var will have three attributes associated with it, but the only source > location information you have access to is for the foo, bar, and baz tokens. > Each of those attributes also keeps track of what syntax was u

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter updated this revision to Diff 488169. ccotter added a comment. - revert git changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463 Files: clang-tools-extra/clang-tidy/rename_check.py Index: c

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git", "mv", fileName,

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng updated this revision to Diff 488173. kito-cheng added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Changes: - Add release note to mention the behavior change for `-march` and `-mcpu`. - New way to implement this behavior, passing all supp

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng updated this revision to Diff 488175. kito-cheng added a comment. Changes: - Trim unexpected change by clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 Files: clang/docs/ReleaseN

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:13 +// MCPU-SYNTACORE-SCR1-BASE: "-target-feature" "+c" +// MCPU-SYNTACORE-SCR1-BASE: "-target-feature" "-64bit" // MCPU-SYNTACORE-SCR1-BASE: "-target-abi" "ilp32" Need to break this in

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

sammccall added a comment. In D141478#4043134 , @hokein wrote: > Thanks for tracking it down. The solution looks good to me. Since this is a > fragile and subtle issue, is it possible to have a unittest for it? If it is > not too hard, it would be nice

[clang-tools-extra] d7bba07 - [include-cleaner] Improve header spelling in the presence of links

Author: Sam McCall Date: 2023-01-11T14:44:22+01:00 New Revision: d7bba07526a7298c9331de031dec15daecff3503 URL: https://github.com/llvm/llvm-project/commit/d7bba07526a7298c9331de031dec15daecff3503 DIFF: https://github.com/llvm/llvm-project/commit/d7bba07526a7298c9331de031dec15daecff3503.diff LO

[PATCH] D141478: [include-cleaner] Improve header spelling in the presence of links

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7bba07526a7: [include-cleaner] Improve header spelling in the presence of links (authored by sammccall). Repository: rG LLVM Github Monorepo CHA

[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Let's give a few days for other reviewers to get a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D128440#4042753 , @pmatos wrote: > @aaron.ballman Hi Aaron, since you requested an RFC for this. I wonder if you > have any commen

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo updated this revision to Diff 488182. mstorsjo added a comment. Updated with some testcases. This does test that the include directory is omitted when cross compiling, but those kinds of tests, which set up a simulated toolchain environment with symlinks, don't run on actual Windows - s

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D139705#4043225 , @v1nh1shungry wrote: > Thanks for the reply! I'll raise a GitHub issue. > >> var will have three attributes associa

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. Thank you for reviewing! I have opened an issue on GitHub: https://github.com/llvm/llvm-project/issues/59935. Hope my description is appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://revi

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:894 +return; + } + jdoerfert wrote: > Does this necessarily mean we failed with `=native`, if so it's ok. Just > didn't follow the logic

[PATCH] D140983: [IRBuilder] Use canonical i64 type for insertelement index used by vector splats.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeae26b6640af: [IRBuilder] Use canonical i64 type for insertelement index used by vector… (authored by paulwalker-arm). Changed prior to commit: ht

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" --

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 updated this revision to Diff 488187. jhuber6 added a comment. I realized that if I fix up how we propagate the ToolChains I can use it in `ConstructPhaseAction`. Should be cleaner this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 488189. v1nh1shungry added a comment. add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 updated this revision to Diff 488193. jhuber6 added a comment. Change to `SuppressError` and make`--offload-arch=` just default to native. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141105/new/ https://reviews.llvm.org/D141105 Files:

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} Note that it seems this is likely not going to work correctly on t

[PATCH] D140547: Perform access checking to private members in simple requirement.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:739 +- Correctly handle access-checks in requires expression. Fixes `GH53364 `_, + `GH53334 `_. C++2b Fe

[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a reviewer: njames93. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a proj

[PATCH] D140547: Perform access checking to private members in simple requirement.

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:739 +- Correctly handle access-checks in requires expression. Fixes `GH53364 `_, + `GH53334 `_. C++2b

[PATCH] D140547: Perform access checking to private members in simple requirement.

RKSimon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:739 +- Correctly handle access-checks in requires expression. Fixes `GH53364 `_, + `GH53334 `_. C++2b Fe

[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141495/new/ https://reviews.llvm.org/D141495 __

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. This change itself LGTM but I think it should wait until after we get more optimizations in to go back to fcmp, and after the release branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Factor this out into a `visitConditional()` that ca

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:920 + + Condition->dump(); + if (!this->visit(Condition)) This meant to be here? Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:921 + Condition->dum

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

sammccall added a comment. Thanks for doing this! There are a couple of separate logical changes here - I don't think it's a problem per se, but it does mean it takes a bit longer to get the good + obvious stuff reviewed and landed. Comment at: clang-tools-extra/clangd/refac

[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e60f99aeff: [clangd] Suppress clang-tidy warnings for code spelled in system macros (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang-tools-extra] f0e60f9 - [clangd] Suppress clang-tidy warnings for code spelled in system macros

Author: Sam McCall Date: 2023-01-11T16:11:25+01:00 New Revision: f0e60f99aefff66ca6223eb3c3a36615f36454ec URL: https://github.com/llvm/llvm-project/commit/f0e60f99aefff66ca6223eb3c3a36615f36454ec DIFF: https://github.com/llvm/llvm-project/commit/f0e60f99aefff66ca6223eb3c3a36615f36454ec.diff LO

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:920 + + Condition->dump(); + if (!this->visit(Condition)) erichkeane wrote: > This meant to be here? Nope! :( Comment at: clang/lib/AST/Interp/ByteCodeExprGen

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

v1nh1shungry added a comment. Thank you for reviewing and giving suggestions! Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:57 +std::string ExpandDeducedType::title() const { + return IsAutoType ? "Expand auto type" : "Expand decltype"; +}

[PATCH] D140992: clang: Add __builtin_elementwise_fma

RKSimon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer + T __builtin_elementwise_fma(T x, T y, T z) fused multiply add.

[PATCH] D140699: [OptTable] Make ValuesCode initialisation of Options constexpr

nikic added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:268 +if (!isa(R.getValueInit("ValuesCode"))) { + assert(!isa(R.getValueInit("Values")) && + "Cannot choose between Values and ValuesCode"); Isn't this assert the

[PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

nikic added a comment. Just to check, this isn't going to cause some warning spew about all those OptTable implementations being non-final? Comment at: llvm/include/llvm/Option/OptTable.h:256 +/// Specialization of +class GenericOptTable : public OptTable {

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added a subscriber: rjmccall. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1480 + /// Return a WebAssembly externref type. + QualType getExternrefType() const; + `getWebAssemblyExternrefType` ? ==

[PATCH] D141226: [clangd] support expanding `decltype(expr)`

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandDeducedType.cpp:139 - // if it's a lambda expression, return an error message - if (isa(*DeducedType) && - cast(*DeducedType)->getDecl()->isLambda()) { -return error("Could no

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4042405 , @ChuanqiXu wrote: > In D140867#4042351 , @Jake-Egan > wrote: > >>> Would you like to take a double look? >> >> Yes, it still fails on the bot and on my local machin

[PATCH] D141092: Optionally install clang-tblgen to aid cross-compiling

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141092/new/ https://reviews.llvm.org/D141092 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D141495: [clangd] Suppress clang-tidy warnings for code spelled in system macros

nridge added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:545 } + // Match behavior for clang-tidy --system-headers=0 (the default). + if (Info.hasSourceManager() && Why not check `CTContext->getOptions().System

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

ecatmur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 6916ebd - [clang][NFC] Use the TypeSize::getXXXValue() instead of TypeSize::getXXXSize)

Author: Guillaume Chatelet Date: 2023-01-11T16:07:48Z New Revision: 6916ebd026500061462917666a0e0d228ed52681 URL: https://github.com/llvm/llvm-project/commit/6916ebd026500061462917666a0e0d228ed52681 DIFF: https://github.com/llvm/llvm-project/commit/6916ebd026500061462917666a0e0d228ed52681.diff

[PATCH] D141507: [NFC] Fixed a typo in clang help docs

jolanta.jensen created this revision. jolanta.jensen added a reviewer: mgabka. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed minor typo in clang help docs. Repository: rG LLVM Github M

  1   2   3   >