ccotter added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/rename_check.py:97 def getListOfFiles(clang_tidy_path): - files = glob.glob(os.path.join(clang_tidy_path, '*')) - for dirname in files: - if os.path.isdir(dirname): - files += glob.glob(os.path.join(dirname, '*')) + files = glob.glob(os.path.join(clang_tidy_path, '**'), recursive=True) files += glob.glob(os.path.join(clang_tidy_path, '..', 'test', ---------------- carlosgalvezp wrote: > Why is this change needed? I'd expect only line 99 to be needed to fix moving > the test. Ah, it's not needed, but I thought it was a bit cleaner to have both the globs take the same approach and be recursive, avoiding the for-loop over the subdirectories. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
