Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM, thanks! Btw I wonder if in the future we could add some error or warning in case someone uses the same approach for frontend specific features, i.e. #ifdef __undef___opencl_c_generic_address_space #error "Feature __opencl_c_generic_address_space can only be disabled via -cl-ext flag" #endif Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141297/new/ https://reviews.llvm.org/D141297 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits