v1nh1shungry added a comment. Thanks for the reply! I'll raise a GitHub issue.
> var will have three attributes associated with it, but the only source > location information you have access to is for the foo, bar, and baz tokens. > Each of those attributes also keeps track of what syntax was used, so you > could tell that foo was a GNU-style attribute while bar and baz were C++. But > we don't keep enough information about bar and baz being part of the same > attribute list or whether that attribute list is leading or trailing. You > have to calculate all of this yourself and some of it might not even be > possible to calculate (for example, the user could have done > __attribute__((foo)) const int var [[bar]] [[baz]]; and the AST would come > out the same as the previous example). Can I post your reply there? I think it will help. > and then we'll ignore attributes for this patch. Then I think this patch is ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
