[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added a comment. In D134337#3863744 , @tstellar wrote: > In what scenarios will clang load the clang.cfg file? It will load it if all of the following are true: 1. `--no-default-config` is **not** passed.

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added a comment. In D127403#3863713 , @nridge wrote: > In D127403#3863686 , @thakis wrote: > >> In D127403#3863641 , @nridge wrote: >> >>> Landed https://reviews

[PATCH] D136124: [clang][deps] Remove unintentional `move`

DavidSpickett added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400 +auto OverlayFS = +llvm::makeIntrusiveRefCnt(BaseFS); auto InMemoryFS = Is this equivalent? ``` auto OverlayFS = BaseFS; ``` G

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ruoso added a comment. FWIW, having a differently named argument for output files and input files is very important for tooling. In particular, in the case of remote execution, it makes a huge difference being able to tell what are the inputs and outputs by looking at the arguments alone, so I

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3864368 , @ruoso wrote: > FWIW, having a differently named argument for output files and input files is > very important for tooling. > > In particular, in the case of remote execution, it makes a huge difference >

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra updated this revision to Diff 468448. raghavendhra added a comment. Herald added projects: clang, LLVM, Flang. Herald added subscribers: llvm-commits, cfe-commits. Seperated map_operands with map-type and map-type-modifier as enum attributes. Repository: rG LLVM Github Monorepo C

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ruoso added a comment. Currently, no. I think we do need a paper to discuss the requirements of the remote execution protocol and how they relate to the implementation of C++ modules. The simple summary is that one way that remote execution is implemented is by just wrapping the compiler execu

[clang] 09aaf19 - [AArch64] Make ACLE intrinsics always available part MTE

Author: Daniel Kiss Date: 2022-10-18T10:35:40+02:00 New Revision: 09aaf190d93393d9e29d29a033cc3979589c5e84 URL: https://github.com/llvm/llvm-project/commit/09aaf190d93393d9e29d29a033cc3979589c5e84 DIFF: https://github.com/llvm/llvm-project/commit/09aaf190d93393d9e29d29a033cc3979589c5e84.diff L

[PATCH] D136062: [AArch64] Make ACLE intrinsics always available part MTE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE (authored by danielkiss). Herald added a project: clang. Herald added a subscr

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3864416 , @ruoso wrote: > Currently, no. I think we do need a paper to discuss the requirements of the > remote execution protocol and how they relate to the implementation of C++ > modules. > > The simple summary i

[clang] a175d8b - Revert "[AArch64] Make ACLE intrinsics always available part MTE"

Author: Daniel Kiss Date: 2022-10-18T10:45:32+02:00 New Revision: a175d8b1772f729b2caf95a1b755cb9a59563e21 URL: https://github.com/llvm/llvm-project/commit/a175d8b1772f729b2caf95a1b755cb9a59563e21 DIFF: https://github.com/llvm/llvm-project/commit/a175d8b1772f729b2caf95a1b755cb9a59563e21.diff L

[PATCH] D136106: [clang][RISCV] Set vscale_range attribute based on VLEN

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136106/new/ https://reviews.llvm.org/D136106 ___ cfe-commits mailing list cfe

[clang] 0d0ca64 - [AArch64] Make ACLE intrinsics always available part MTE

Author: Daniel Kiss Date: 2022-10-18T11:03:02+02:00 New Revision: 0d0ca64356ff1a9e3427660732da033a14521e5b URL: https://github.com/llvm/llvm-project/commit/0d0ca64356ff1a9e3427660732da033a14521e5b DIFF: https://github.com/llvm/llvm-project/commit/0d0ca64356ff1a9e3427660732da033a14521e5b.diff L

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

pengfei created this revision. pengfei added reviewers: craig.topper, uweigand, lenary, efriedma. Herald added subscribers: StephenFan, jdoerfert, hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-co

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, atanasyan, hiraditya, arichardson, sdardis. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, L

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei added a comment. In D136040#3862551 , @uweigand wrote: > In D136040#3862386 , @pengfei wrote: > >> Sure, it is possible. But at least for now, there's no real target requires >> it. Checked with `grep -rw

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

RKSimon added inline comments. Comment at: llvm/test/MC/X86/x86-64-cmpccxadd-att.s:1 +// RUN: llvm-mc -triple x86_64 --show-encoding %s | FileCheck %s + Drop the -att.s and add intel test coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. once again we are getting off topic for this patch :) We (compiler engineers) will have to cater for multiple models used by different build systems. SG15 might give guidance/recommendations, but in the end the standard's normative text is not likely to make a 'discover

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

mariusz-sikora-at-amd added a comment. In D135110#3859844 , @mstorsjo wrote: > I don't quite know why, but it seems like this new library breaks tests of > llvm-config; if I start out with an empty build directory and run `ninja > check-llvm` (or `ninja

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. > once again we are getting off topic for this patch :) Yeah, let's wait for @dblaikie's opinion on the flag name : ) The remained question: To use `-fc++-module-bmi-output=` or `-fc++-module-filename=`, or anything else (maybe `-fc++-module-output=`) CHANGES SINCE

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

RKSimon added a comment. Can you fix the MC + disasm test file names - drop att/intel and ensure you test both syntaxes for 32 and 64 bits. Ideally the 32/64 bit names should be close to each other in a file list (e.g. avx-vnni-int8-32.s + avx-vnni-int8-64.s ?) Repository: rG LLVM Github Mo

[PATCH] D135937: [X86] Support -march=meteorlake

RKSimon added a comment. Please can you update the summary now that raptorlake + meteorlake are in the same patch? Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2233 +// RUN: %clang -march=raptorlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468463. pengfei added a comment. Rebased on D136145 and split RIP optimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Fi

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added a comment. merge att/intel test coverage files and rename the 32/64 bit files so that they are close together in the file lists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135930/new/ https://reviews.llvm.org/D135930 _

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2126 return false; FormatToken *LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); Perhaps add: ``` if (Tok.MatchingParen->is(TT_OverloadedOperatorLParen))

[PATCH] D134728: [clangd] Add highlighting modifier "constructorOrDestructor"

ckandeler updated this revision to Diff 468465. ckandeler retitled this revision from "[clangd] Add highlighting modifiers "constructor" and "destructor"" to "[clangd] Add highlighting modifier "constructorOrDestructor"". ckandeler edited the summary of this revision. ckandeler added a comment.

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

lenary added a comment. The Arm changes (for tests) here are reasonable, and indeed both arm architectures do not allocate encoding space for instruction write. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136145/new/ https://reviews.llvm.org/D13

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added a comment. Is the pre-commit CI failure here related to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing list c

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

dstuttard added a comment. I think that the reason we don't see the same failure for e.g. OpenACC is that there's a unittest/Frontend that requires OpenACC - if I comment out that subdir in the unittests/CMakeLists.txt it fails llvm-config test in the same way for OpenACC. Similarly, if I add F

[PATCH] D136154: Fix the continuation indenter

hel-ableton created this revision. hel-ableton added reviewers: JonasToth, MyDeveloperDay, owenpan. hel-ableton added a project: clang-format. Herald added a project: All. hel-ableton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When Sty

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. It looks good to me. As discussed offline, would be nice to show line number for each line of code in the html dump. Comment at: clang-tools-extra/include-cleaner/lib/HTMLR

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 468473. rymiel marked 4 inline comments as done. rymiel added a comment. Do not annotate the trailing identifier of an UDL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D1348

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2126 return false; FormatToken *LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); owenpan wrote: > Perhaps add: > ``` >

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

pengfei added a comment. In D136145#3864584 , @lenary wrote: > The Arm changes (for tests) here are reasonable, and indeed both arm > architectures do not allocate encoding space for instruction write. Thanks @lenary for confirmation! Repository: rG

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah marked 5 inline comments as done. tblah added a comment. Thanks for taking a look. I've updated accordingly and will upload the patch soon. > are you confident that we will need LangOptions.def? Clang places this flag (and many other floating point options) in LangOptions so I thought I

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

uweigand added inline comments. Comment at: llvm/test/CodeGen/SystemZ/prefetch-01.ll:18 -; Check that instruction write prefetches are ignored. -define dso_local void @f2(ptr %ptr) { -; CHECK-LABEL: f2: -; CHECK-NOT: %r2 -; CHECK: br %r14 - call void @llvm.prefetch(ptr %ptr, i

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 468475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/flang/Frontend/CompilerInvocation.h flang/includ

RE: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

Thanks for the suggestion. Updated llvm_unreachable. The static_cast not only check the switch cases all covered, also make sure 2 enums not out of sync. Sent from Mail for Windows From: David Blaikie Sent: Monday, Oc

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 added a comment. In D136041#3863748 , @dblaikie wrote: > Hmm - this does mean linking IR can produce invalid code, though, right (you > link in a definition of the function, so what was valid is now invalid - > because it now has a definition, c

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

bader created this revision. bader added a reviewer: aaron.ballman. Herald added a subscriber: ebevhan. Herald added a project: All. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a contradiction in the #pragma unroll behavi

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

pengfei updated this revision to Diff 468486. pengfei marked an inline comment as done. pengfei added a comment. Remove instruction write prefetch test from SystemZ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136145/new/ https://reviews.llvm.org

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

bader updated this revision to Diff 468487. bader added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136160/new/ https://reviews.llvm.org/D136160 Files: clang/include/clang/Basic/AttrDocs.td Index: clang/incl

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

SuibianP updated this revision to Diff 468488. SuibianP added a comment. Remove superfluous parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133248/new/ https://reviews.llvm.org/D133248 Files: clang/include/clang/Parse/Parser.h clang/

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij updated this revision to Diff 468495. stuij added a comment. addressed review comment by adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135680/new/ https://reviews.llvm.org/D135680 Files: clang/lib/Basic/Targets/ARM.cpp clang/

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/test/Preprocessor/init-arm.c:404 +// is specified +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi -target-feature +soft-float -target-feature +soft-float-abi < /dev/

[PATCH] D136162: [analyzer] Fix assertion failure in RegionStore within bindArray()

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, ASDenysPetrov, tomasz-kaminski-sonarsource, xazax.hun, isuckatcs. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All.

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135680/new/ https://reviews.llvm.org/D135680

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah added a comment. Linux CI is passing. I suspect the CI failure on windows is unrelated to my code: the test failure is for clang-scan-deps and the previous version of the patch passed CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/array-bounds.cpp:240 -((char*)foo)[sizeof(foo)] = '\0'; // expected-warning {{array index 32768 is past the end of the array (which contains 32768 elements)}} +((char*)foo)[sizeof(foo)] = '\0'; // ex

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added a comment. Thank you for all the reviews. Appreciate it. So will some of you land this or am I supposed to do something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 ___

[PATCH] D135025: [clang][Interp] Support base class constructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Okay, this is incremental progress, so LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

SuibianP updated this revision to Diff 468509. SuibianP added a comment. Add release note entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133248/new/ https://reviews.llvm.org/D133248 Files: clang/docs/ReleaseNotes.rst clang/include/clang/P

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

erichkeane added a comment. Thank you so much for doing this. I'm hopeful our hackery can go away sometime soon. Comment at: clang/test/CXX/drs/dr25xx.cpp:3 -namespace dr2565 { // dr252: 16 +namespace dr2565 { // dr2565: partial template If you could add

[clang] 2946b25 - [Clang] Fix crash when checking misaligned member with dependent type

Author: Jun Zhang Date: 2022-10-18T21:05:49+08:00 New Revision: 2946b252993d9b4c12479bf318b648bed2c0427a URL: https://github.com/llvm/llvm-project/commit/2946b252993d9b4c12479bf318b648bed2c0427a DIFF: https://github.com/llvm/llvm-project/commit/2946b252993d9b4c12479bf318b648bed2c0427a.diff LOG

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. junaire marked an inline comment as done. Closed by commit rG2946b252993d: [Clang] Fix crash when checking misaligned member with dependent type (authored by junaire).

[clang] 4bcb85c - Stop evaluating trailing requires clause after overload resolution

Author: Erich Keane Date: 2022-10-18T06:08:10-07:00 New Revision: 4bcb85c638c1c1719c5c01a70ee2e376e4032d2a URL: https://github.com/llvm/llvm-project/commit/4bcb85c638c1c1719c5c01a70ee2e376e4032d2a DIFF: https://github.com/llvm/llvm-project/commit/4bcb85c638c1c1719c5c01a70ee2e376e4032d2a.diff L

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bcb85c638c1: Stop evaluating trailing requires clause after overload resolution (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2843 -// subregions of the `LCS.getRegion()` also lazily copied. -if (const MemRegion *R = LCS->getRe

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 updated this revision to Diff 468514. eddyz87 added a comment. Split the original commit in two to separate clang and llvm parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136041/new/ https://reviews.llvm.org/D136041 Files: clang/lib

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

rymiel added a comment. Please provide a name and an email so someone could commit it on your behalf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 ___ cfe-com

[clang] bb3c90d - [OpenMP] Make device functions have hidden visibility

Author: Joseph Huber Date: 2022-10-18T08:15:39-05:00 New Revision: bb3c90d3ecd142e60cf994338bdd4b59d8788cd3 URL: https://github.com/llvm/llvm-project/commit/bb3c90d3ecd142e60cf994338bdd4b59d8788cd3 DIFF: https://github.com/llvm/llvm-project/commit/bb3c90d3ecd142e60cf994338bdd4b59d8788cd3.diff

[PATCH] D136111: [OpenMP] Make device functions have hidden visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb3c90d3ecd1: [OpenMP] Make device functions have hidden visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136111/new/ https:/

[PATCH] D136013: [clang][Interp] Fix ignoring expression return values

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:208 + +struct S { + int a = 0; Hmmm, this feels related to the discarded value results changes, but it might be a test case for a different scenario as well, so take this or leav

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

SuibianP added a comment. @aaron.ballman Thanks for the guidance! I have rectified the parentheses and appended to the release notes. Please feel free to point out any additional issues with the Differential. If all is good, I would like to have the patch attributed to `Jialun Hu `. Reposito

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. > which isn't clear to me what you mean - In the function `Sema::CheckTemplateArgument` at line 5725, `Params` has been substituted in a way all `TemplateTypeParmDecl`s are instantiated with a smaller depth, and so are constraints of them at SemaTemplateInstantiateDecl.cp

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added a comment. I think I have a fix for this and I'll get it up today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 ___ cfe-commits mailing list cfe-

[clang] 95bbe9a - [clang][ARM] follow GCC behavior for defining __SOFTFP__

Author: Ties Stuij Date: 2022-10-18T14:38:03+01:00 New Revision: 95bbe9a1930886cffc79f1f5b953f5aafff1557f URL: https://github.com/llvm/llvm-project/commit/95bbe9a1930886cffc79f1f5b953f5aafff1557f DIFF: https://github.com/llvm/llvm-project/commit/95bbe9a1930886cffc79f1f5b953f5aafff1557f.diff LO

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rG95bbe9a19308: [clang][ARM] follow GCC behavior for defining __SOFTFP__ (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D136162: [analyzer] Fix assertion failure in RegionStore within bindArray()

martong added a comment. Hmm, seems like the conflicting prototype (i.e. the obsolescent use of zero parameters) is needed to reproduce the assertion failure. That makes me wonder, how does the redecl chain of `b` looks like? Is `void b()` chained with `void b(int*)`, or are they represented in

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3865063 , @lime wrote: >> which isn't clear to me what you mean > > - In the function `Sema::CheckTemplateArgument` at line 5725, `Params` has > been substituted in a way all `TemplateTypeParmDecl`s are instantiated

[PATCH] D136162: [analyzer] Fix assertion failure in RegionStore within bindArray()

martong added a comment. > A similar situation could happen if we reinterpret cast pointers, etc. so the > situation is not limited to conflicting function prototypes. Please provide tests for those cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added a comment. In D132131#3865004 , @rymiel wrote: > Please provide a name and an email so someone could commit it on your behalf name: Yusuke Kadowaki email: yusuke.kadowaki.1...@gmail.com Repository: rG LLVM Github Monorepo CHANG

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468525. qiongsiwu1 added a comment. Address a review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 added a comment. @w2yehia @daltenty may I ask for a review? Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135885/new/ https://reviews.llvm.org/D135885 ___ cfe-commits mailing l

[clang] 94e8bd0 - [clang] Fix crash upon stray coloncolon token in C2x mode

Author: Jialun Hu Date: 2022-10-18T21:57:32+08:00 New Revision: 94e8bd002c81ace308ddac9b66385ef932655fd3 URL: https://github.com/llvm/llvm-project/commit/94e8bd002c81ace308ddac9b66385ef932655fd3 DIFF: https://github.com/llvm/llvm-project/commit/94e8bd002c81ace308ddac9b66385ef932655fd3.diff LOG

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94e8bd002c81: [clang] Fix crash upon stray coloncolon token in C2x mode (authored by Jialun Hu , committed by inclyc). Reposit

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

inclyc added a comment. In D133248#3865010 , @SuibianP wrote: > @aaron.ballman Thanks for the guidance! I have rectified the parentheses and > appended to the release notes. Please feel free to point out any additional > issues with the Differential. >

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

jhuber6 added a comment. In D136100#3863427 , @MyDeveloperDay wrote: > Pretty interesting, it looks ok from what I can tell, let the others take a > look Thanks, I was originally hoping I could avoid adding a new boolean for `InPragma` by asking somet

[clang] 04615b6 - [clang][LTO] Setting Desired Default AIX Debugging Options

Author: Qiongsi Wu Date: 2022-10-18T10:43:19-04:00 New Revision: 04615b695aadf5f3860e3be9631131518227f410 URL: https://github.com/llvm/llvm-project/commit/04615b695aadf5f3860e3be9631131518227f410 DIFF: https://github.com/llvm/llvm-project/commit/04615b695aadf5f3860e3be9631131518227f410.diff LO

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04615b695aad: [clang][LTO] Setting Desired Default AIX Debugging Options (authored by Qiongsi Wu ). Repository: rG LLVM Githu

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Hooks.h:38 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: sammccall wrote: > IWYU pragmas requi

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a comment. In D135269#3863470 , @nikic wrote: > Checking back here, have you made any progress on reducing the issue? > > cc @arsenm for awareness No. I am busy with other work and have not got time to get back on it. Repository: rG LLVM

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added a comment. The llvm-config test issue should be resolved in rGa4b010034f57 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

rupprecht added a comment. I'm seeing a fair number of breakages from this patch (not really sure how many we truly have, I've hit ~5-10 so far in widely used libraries, but I suspect we have far more in the long tail). They're all valid (most are just adding missing thread safety annotations,

[PATCH] D136124: [clang][deps] Remove unintentional `move`

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400 +auto OverlayFS = +llvm::makeIntrusiveRefCnt(BaseFS); auto InMemoryFS = DavidSpickett wrote: > Is this equivalent? > ``` > auto

[PATCH] D136124: [clang][deps] Remove unintentional `move`

jansvoboda11 updated this revision to Diff 468555. jansvoboda11 added a comment. Use both `-j 1` and `-j 4` in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136124/new/ https://reviews.llvm.org/D136124 Files: clang/lib/Tooling/DependencyS

[PATCH] D136124: [clang][deps] Remove unintentional `move`

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:18 // -// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 4 -format experimental-full \ +// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 1 -format

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 added a comment. This looks good to me in principle. It would be nice to have a simple test that shows what kind of output we get. Can you add that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D1

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a comment. Probably if the `StdLibraryFunctionsChecker` object can be get from `StreamChecker` (a new function is needed) it is possible to check the option and use `CheckerManager::reportInvalidCheckerOptionValue` (for the `StdLibraryFunctionsChecker`). But not sure if it does w

[clang] 10c0eca - [clang][Lexer] Speed up HeaderSearch when there are many HeaderMaps

Author: Troy Johnson Date: 2022-10-18T08:21:14-07:00 New Revision: 10c0eca25523e3bf1872522bde4693aaa55513e0 URL: https://github.com/llvm/llvm-project/commit/10c0eca25523e3bf1872522bde4693aaa55513e0 DIFF: https://github.com/llvm/llvm-project/commit/10c0eca25523e3bf1872522bde4693aaa55513e0.diff

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

This revision was automatically updated to reflect the committed changes. Closed by commit rG10c0eca25523: [clang][Lexer] Speed up HeaderSearch when there are many HeaderMaps (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/n

[PATCH] D136078: [RFC] Use-after-return binary metadata.

dvyukov updated this revision to Diff 468562. dvyukov added a comment. Herald added subscribers: llvm-commits, Enna1, hiraditya. Herald added a project: LLVM. WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D1

[PATCH] D136124: [clang][deps] Remove unintentional `move`

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM As it happens the bot that found this has been moved to silent for other reasons. I'll let you know if we see any further issues. Repository: rG LLVM Github Monorepo CH

[clang] 57ba07c - [clang] fix typo in unit test

Author: Susana Monteiro Date: 2022-10-18T16:32:13+01:00 New Revision: 57ba07c06f8b68d401f47ab115259fa2dd3d7136 URL: https://github.com/llvm/llvm-project/commit/57ba07c06f8b68d401f47ab115259fa2dd3d7136 DIFF: https://github.com/llvm/llvm-project/commit/57ba07c06f8b68d401f47ab115259fa2dd3d7136.dif

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a comment. Richard, ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135192/new/ https://reviews.llvm.org/D135192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added a comment. (catching up after I was away last week) I agree with @dexonsmith's analysis above. One historical note: > As a heuristic on top of (4), "last-ref" (before this patch) probably gets > the answer the user expects more often than "first-ref" (this patch) does, > whic

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

dblaikie accepted this revision. dblaikie added a comment. In D136041#3864171 , @yonghong-song wrote: > In D136041#3863748 , @dblaikie > wrote: > >> Hmm - this does mean linking IR can produce invalid code, thou

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

tahonermann added a comment. The code changes look good to me. I offered a suggested rewording of the release note. Comment at: clang/docs/ReleaseNotes.rst:499-501 +- Implemented DR692, DR1395 and DR1432. Note that the fix for DR1432 is speculative + that there is no wording

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. It looks like this: F24958018: image.png F24958020: image.png There is a generic test for the TimeTraceScope functionality. Other than that there's only this one I found in https://reviews.llvm.org/

  1   2   3   >