tahonermann added a comment. The code changes look good to me. I offered a suggested rewording of the release note.
================ Comment at: clang/docs/ReleaseNotes.rst:499-501 +- Implemented DR692, DR1395 and DR1432. Note that the fix for DR1432 is speculative + that there is no wording or even resolution for this issue. A speculative fix for + DR1432 is needed because it fixes regressions caused by DR692. ---------------- - Implemented `DR692 <https://wg21.link/cwg692>`_, `DR1395 <https://wg21.link/cwg1395>`_, and `DR1432<https://wg21.link/cwg1432>`_. The fix for DR1432 is speculative since the issue is still open and has no proposed resolution at this time. A speculative fix for DR1432 is needed to prevent regressions that would otherwise occur due to DR692. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
