DavidSpickett added inline comments.
================
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400
+ auto OverlayFS =
+ llvm::makeIntrusiveRefCnt<llvm::vfs::OverlayFileSystem>(BaseFS);
auto InMemoryFS =
----------------
Is this equivalent?
```
auto OverlayFS = BaseFS;
```
Given that BaseFS is already `IntrusiveRefCntPtr`.
================
Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:18
//
-// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 4 -format
experimental-full \
+// RUN: clang-scan-deps -compilation-database %t_clangcl.cdb -j 1 -format
experimental-full \
// RUN: -mode preprocess-dependency-directives -module-name=header1 >
%t_clangcl.result
----------------
Would it help to have one be j1 and one j4, any extra coverage by doing that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136124/new/
https://reviews.llvm.org/D136124
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
