[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj created this revision. troyj added a reviewer: rsmith. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rG04ba1856 introduced a

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465750. lime added a comment. I updated patch to fix the previous problem that failed to pass unit tests. And, isn't this patch accepted a little quickly? BTW, `NormalizationCache` becomes heavier than before. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Hi @fhahn, After a second thought, I think posting a clear RFC [0] to the community that defines the problem and goal this patch tries to achieve so the community is notified of such change is a better approach than directly updating this patch. Please consider to drop b

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. In D134128#3840232 , @lime wrote: > I updated patch to fix the previous problem that failed to pass unit tests. > And, isn't this pa

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added a comment. In D135220#3840177 , @dexonsmith wrote: > In D135220#3839671 , @goncharov > wrote: > >> That change might be problematic for content addressing storages. E.g. >> clang/test/Driver/cl-

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added a comment. In D135118#3839442 , @nikic wrote: > FYI this caused a noticeable compile-time regression (about 0.4% geomean at > `-O0`): > http://llvm-compile-time-tracker.com/compare.php?from=92233159035d1b50face95d886901cf99035bd99&to=37188

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

dexonsmith added a comment. In D135220#3840257 , @goncharov wrote: > In D135220#3840177 , @dexonsmith > wrote: > >> In D135220#3839671 , @goncharov >> wrote: >> >>> That

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

dexonsmith added a comment. In D135220#3840257 , @goncharov wrote: > It's possbile to make it deterministic by making headers unique though. Also, this is the first time you've mentioned non-determinism. Is this non-deterministic? Repository: rG LLV

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:106 + +constexpr C RVOAndParams(const C *c) { + return C(); aaron.ballman wrote: > We're missing a fair amount of test coverage here in terms of calling member > functions. Can you add

[clang] 4b53c00 - [Format] Drop speculative test added in previous patch, it hits asserts?

Author: Sam McCall Date: 2022-10-06T17:57:58+02:00 New Revision: 4b53c00173163774d32125fbcae283a46a9a4b19 URL: https://github.com/llvm/llvm-project/commit/4b53c00173163774d32125fbcae283a46a9a4b19 DIFF: https://github.com/llvm/llvm-project/commit/4b53c00173163774d32125fbcae283a46a9a4b19.diff LO

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj updated this revision to Diff 465759. troyj added a comment. Pulled and regenerated diff. I'm not sure what the problem was and it still looks the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D1353

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb planned changes to this revision. cjdb added a comment. I learnt last night that this one is incredibly wrong and needs revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 _

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3839876 , @erichkeane wrote: > This doesn't cause us to lose this in Microsoft C mode, does it? Otherwise, > LGTM. Why is destructibility necessary in C? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D135373: [clang][test] Make headers unique to avoid linking issues

benlangmuir created this revision. benlangmuir added reviewers: goncharov, dexonsmith. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the empty headers used by cl-pch-showincludes.cpp unique so

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added a comment. Okay, I was able to reproduce by symlinking all the 0-byte header files to header0 (any choice probably works). The behaviour is deterministic before and after my change. This was only passing by luck in this setup, because it was relying on mutation of `FileEntry

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw added a comment. See https://github.com/llvm/llvm-project/issues/58188#issuecomment-1270355888. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___ cfe-c

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__referen

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, yaxunl, arsenm. Herald added subscribers: kosarev, guansong, t-tye, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465768. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, rjmccall, efriedma, fhahn, dexonsmith. zahiraam changed the visibility from "Custom Policy" to "Public (No Login Required)". Herald added a subscriber: MaskRay. CHANGES SINCE LAST ACTION ht

[PATCH] D135372: [clang-format] Fix for #58188

HazardyKnusperkeks added a comment. What is the problem that remains? Please add a test case. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1142-1143 + PPStack.back().Kind == PP_Unreachable && + !(PPStack.size() > 1 && +PPStack[PPStack.size() - 2].Kind

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Calling

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw updated this revision to Diff 465772. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 Files: clang/lib/Format/UnwrappedLineParser.cpp Index: clang/lib/Format/UnwrappedLineParser.cpp =

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Callin

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Calling

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__r

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw added a comment. The problem that remains is this, as I explained in the issue. The second branch of the second block is not indented. #if 1 { #endif #if X x; #else x; #endif } I didn't add a test case because I was not expecting this patch to be committed as there

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

erichkeane added a comment. In D135339#3840323 , @cjdb wrote: > In D135339#3839876 , @erichkeane > wrote: > >> This doesn't cause us to lose this in Microsoft C mode, does it? Otherwise, >> LGTM. > > Why is des

[PATCH] D135373: [clang][test] Make headers unique to avoid linking issues

goncharov accepted this revision. goncharov added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135373/new/ https://reviews.llvm.org/D135373 ___

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a reviewer: HAPPY. ppluzhnikov added a comment. Richard, could you take a look? You've added the check in commit 78d81ecfc38c2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135192/new/ https://reviews.llvm.org/D135192 __

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Callin

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

gulfem added a comment. We are seeing the same error reported above: FormatTests: clang/lib/Lex/Lexer.cpp:1151: SourceLocation clang::Lexer::getSourceLocation(const char *, unsigned int) const: Assertion `Loc >= BufferStart && Loc <= BufferEnd && "Location out of range for this buffer!"' fai

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added a comment. In D135220#3840354 , @benlangmuir wrote: > Okay, I was able to reproduce by symlinking all the 0-byte header files to > header0 (any choice probably works). The behaviour is deterministic before > and after my change. > > Th

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3840406 , @erichkeane wrote: > In D135339#3840323 , @cjdb wrote: > >> In D135339#3839876 , @erichkeane >> wrote: >> >>> This doesn't cau

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

erichkeane added a comment. In D135339#3840422 , @cjdb wrote: > In D135339#3840406 , @erichkeane > wrote: > >> In D135339#3840323 , @cjdb wrote: >> >>> In D135339#3839876

[clang] 6ebc3ab - [NFC] Replace use of !isTranslationUnit && !isNamespace with !isFileContext

Author: Erich Keane Date: 2022-10-06T09:40:51-07:00 New Revision: 6ebc3abd7603ddefc08e3ab2f5daed2bdd8ec631 URL: https://github.com/llvm/llvm-project/commit/6ebc3abd7603ddefc08e3ab2f5daed2bdd8ec631 DIFF: https://github.com/llvm/llvm-project/commit/6ebc3abd7603ddefc08e3ab2f5daed2bdd8ec631.diff L

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

sammccall added a comment. Fixed by 4b53c00173163774d32125fbcae283a46a9a4b19 I think. (@kadircet suggested a possible second crash, I couldn't get it to crash so included the testcase with this patch. Turns out it does crash.

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added a comment. > I was mostly trying to confirm that symlink setups will be fine I don't know if we promise this is supported anywhere, but I know we've made this kind of test change to force unique files several times in the past. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D134947: [analyzer] Fix the liveness of Symbols for values in regions referred by LazyCompoundVal

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:461 +bool SymbolReaper::isLazilyCopiedRegion(const MemRegion *MR) const { + // TODO: See comment in isLive

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > It's too long ago for me. Does the `--files` option take multiple file names > on the command line, or a file containing the file names? If the latter the > patch generally lo

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

royjacobson added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

erichkeane added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__r

[PATCH] D135356: [Format] Fix crash when hitting eof while lexing JS template string

gulfem added a comment. In D135356#3840428 , @sammccall wrote: > Fixed by 4b53c00173163774d32125fbcae283a46a9a4b19 > I think. It fixed the test error that we are seeing, thanks! Rep

[clang] 8d9a3a6 - [clang][test] Make headers unique to avoid linking issues

Author: Ben Langmuir Date: 2022-10-06T10:09:22-07:00 New Revision: 8d9a3a6b9bd10f294d0e5adb0972a1ed8845e4aa URL: https://github.com/llvm/llvm-project/commit/8d9a3a6b9bd10f294d0e5adb0972a1ed8845e4aa DIFF: https://github.com/llvm/llvm-project/commit/8d9a3a6b9bd10f294d0e5adb0972a1ed8845e4aa.diff

[PATCH] D135373: [clang][test] Make headers unique to avoid linking issues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d9a3a6b9bd1: [clang][test] Make headers unique to avoid linking issues (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D135115: [clang-format] update --files help description

ychen added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > Except for the `@` part. (Which also isn't handles by clang-format, or > is it?) It is not. It is handled by the LLVM commandline library. https://llvm.org/docs/CommandLine.html#

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__referen

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert updated this revision to Diff 465782. aaronpuchert added a comment. Add trimmed-down documentation back in and a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.org/D129755 Files: clang/d

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus created this revision. Szelethus added reviewers: NoQ, martong, steakhal, balazske, isuckatcs. Szelethus added a project: clang. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Her

[PATCH] D135374: [OpenMP][AMDGPU] Add 'uniform-work-group' attribute to OpenMP kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::Calling

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

Szelethus added a comment. Just a note on the test files -- I've diverged from the usual stance of just changing what the new output is, to modifying the test files. The reason is that reading an undefined value is a fatal error, leading to the analyzer to stop analyzing prematurely, and I thin

[clang] 7404b85 - [clang][NFC] Use enum for -fstrict-flex-arrays

Author: Bill Wendling Date: 2022-10-06T10:45:41-07:00 New Revision: 7404b855e528f88bf2a395a0a14937ca6812e8d1 URL: https://github.com/llvm/llvm-project/commit/7404b855e528f88bf2a395a0a14937ca6812e8d1 DIFF: https://github.com/llvm/llvm-project/commit/7404b855e528f88bf2a395a0a14937ca6812e8d1.diff

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7404b855e528: [clang][NFC] Use enum for -fstrict-flex-arrays (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

aaron.ballman added a comment. In D37624#3838587 , @paquette wrote: > +1, someone just asked me if this feature exists and then found this patch. > If this could be revived, I think it would help a lot of folks out. :) I took a quick pass over it and the

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

MaskRay added a comment. Thanks for noticing the issue. There are some formatting issues in the description:) And a typo in the table cell `initeMathOnly` -menable-unsafe-fp-math looks like a CC1 for a long time, probably from 2012. In 2020 D82574 accidentally

[clang] c131883 - [clang][NFC] Remove extraneous normalized value

Author: Bill Wendling Date: 2022-10-06T11:01:25-07:00 New Revision: c131883146c2efdef5c6ee17d624f8cada277d9d URL: https://github.com/llvm/llvm-project/commit/c131883146c2efdef5c6ee17d624f8cada277d9d DIFF: https://github.com/llvm/llvm-project/commit/c131883146c2efdef5c6ee17d624f8cada277d9d.diff

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465790. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/fp-options-

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

ronlieb added a comment. hi, seeing our amdgpu buildbot broken with this patch. please look into ? let me know if you any help on our end. https://lab.llvm.org/buildbot/#/builders/193/builds/19744 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added a comment. In D135107#3840602 , @ronlieb wrote: > hi, seeing our amdgpu buildbot broken with this patch. please look into ? > let me know if you any help on our end. > https://lab.llvm.org/buildbot/#/builders/193/builds/19744 It's been fixed.

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra updated this revision to Diff 465799. tra added a comment. Use VersionTuple instead of a manually encoded integer version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328 Files: clang/lib/Basic/Cuda

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

tra updated this revision to Diff 465800. tra added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135306/new/ https://reviews.llvm.org/D135306 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsNVPTX.def c

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra marked an inline comment as done. tra added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:59 +CudaVersion ToCudaVersion(llvm::VersionTuple Version) { + int IVer = Version.getMajor() * 10 + Version.getMinor().value_or(0); + for (auto *I = CudaNameVersionMap; I->Versi

[PATCH] D135381: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, rsmith. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up to D1342

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added a comment. I'm also okay with this direction. I took a look to see if people seemed to be using this option in their build scripts (maybe we would need a louder deprecation period), and it seems like most of the uses out there are in forks of Clang. Once I excluded things th

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

beanz added a comment. In D133993#3816526 , @efriedma wrote: > Why are we using different mechanisms for global constructors in "libraries" > vs. other code? If we need a mechanism in LLVM already, we might as well use > it all the time? To elaborate

[PATCH] D135381: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:598 + // Cannot use a module if the header is excluded in it. + if (!AllowExcluded && H.getRole() == ModuleMap::ExcludedHeader) +continue; This is what actually fixes th

[PATCH] D135384: Enable the use of the -pg flag

francii created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. francii requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1019 + const Token &T) { +return ID == SM.getFileID(T.getLocation()); + }) &&

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.org/D129755 ___ cfe-commits mailing list cfe-comm

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:106 + +constexpr C RVOAndParams(const C *c) { + return C(); tbaeder wrote: > aaron.ballman wrote: > > We're missing a fair amount of test coverage here in terms of calling > > me

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:797 + // SLocOffset. + unsigned LessIndex = 0; + // upper bound of the search range. Consider renaming this `LesserIndex` which matches

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. It seems like it would be better to put the code in an LLVM IR transform pass, if we can. It separates the concerns more clearly, and it would make life easier for other compilers. (If yo

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman updated this revision to Diff 465825. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Rebased and updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/ https://reviews.llvm.org/D134813 Files: clang/inc

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

beanz added a comment. @efriedma, I think that's a great suggestion. @python3kgae, if you don't adjust this patch, can you file an issue for that so that we don't lose that feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https:

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. Thank you *so much* to @sammccall @zixuw and @dang for the help with indexing and API extraction, I really appreciate it! Comment at: clang/include/clang/AST/Decl.h:3647 + void printName(raw_ostream &OS, const PrintingPolicy &Policy) const; +

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2e1fc90a01: [PowerPC] Fix types for vcipher builtins. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 0e2e1fc - [PowerPC] Fix types for vcipher builtins.

Author: Stefan Pintilie Date: 2022-10-06T14:21:34-05:00 New Revision: 0e2e1fc90a01f84b982b48fb9189c06aec55baed URL: https://github.com/llvm/llvm-project/commit/0e2e1fc90a01f84b982b48fb9189c06aec55baed DIFF: https://github.com/llvm/llvm-project/commit/0e2e1fc90a01f84b982b48fb9189c06aec55baed.dif

[PATCH] D135375: [analyzer] Initialize regions returned by CXXNew to undefined

steakhal added a comment. Awesome! Have you measured how often would this change introduce new garbage value warnings? At the other side of the spectrum it could also hide reports, because it sinks the path too soon due to the falsely binding uninitialized value there. WDYT?

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, jyknight, MaskRay, yaxunl, aaron.ballman, ronlieb. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

stephanemoore added a comment. LGTM after fixing the assertion ✅ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3839312 , @thieta wrote: > This looks fine to me in principle. But I wonder if we should land the flag > change first separately and make sure that no buildbots break because of it. > Then we can merge the simpli

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. ManuelJBrito added a project: clang. Herald added subscribers: dmgreen, arphaman, kbarton, nemanjai. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits. Repla

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra added a comment. LGTM in principle. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1) This looks fo

[clang] d8fa40d - Thread safety analysis: Handle additional cast in scoped capability construction

Author: Aaron Puchert Date: 2022-10-06T22:18:26+02:00 New Revision: d8fa40dfa7adb062c969ce7ea6ce505e10626838 URL: https://github.com/llvm/llvm-project/commit/d8fa40dfa7adb062c969ce7ea6ce505e10626838 DIFF: https://github.com/llvm/llvm-project/commit/d8fa40dfa7adb062c969ce7ea6ce505e10626838.diff

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rGd8fa40dfa7ad: Thread safety analysis: Handle additional cast in scoped capability construction (author

[clang] 0041a69 - Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

Author: Aaron Puchert Date: 2022-10-06T22:19:09+02:00 New Revision: 0041a69495f828f6732803cfb0f1e3fddd7fbf2a URL: https://github.com/llvm/llvm-project/commit/0041a69495f828f6732803cfb0f1e3fddd7fbf2a DIFF: https://github.com/llvm/llvm-project/commit/0041a69495f828f6732803cfb0f1e3fddd7fbf2a.diff

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0041a69495f8: Thread safety analysis: Support copy-elided production of scoped capabilities… (authored by aaronpuchert). Repository: rG LLVM Githu

[PATCH] D135091: Load the `_cmd` selector for generated getters/setters of `direct` Objective-C properties.

stephanemoore accepted this revision. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjC.cpp:1189-1191 // Return (ivar-type) objc_getProperty((id) self, _cmd, offset, true). // FIXME: Can't this be

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman updated this revision to Diff 465857. mwyman retitled this revision from "Load the `_cmd` selector for generated getters/setters of `direct` Objective-C properties." to "Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C pro

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman marked an inline comment as done. mwyman added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:171-177 +// Check the synthesized objectProperty calls objc_getProperty(); this also +// checks that the synthesized method accesses _cmd (or rather loads the

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

ldionne added a comment. Interesting, I actually wasn't even aware of that C++23 feature in the library. FWIW, libc++ will be more than happy to use that builtin instead of trying to figure it out inside the library (if that's even possible)! We'll have to check whether GCC implements it, but h

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 updated this revision to Diff 465862. jhuber6 added a comment. Adjusting check to ensure that this only applies for an edit length of zero once the `-` is added. Also adding a negative check line for other inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb added a comment. In D135341#3841126 , @ldionne wrote: > Interesting, I actually wasn't even aware of that C++23 feature in the > library. FWIW, libc++ will be more than happy to use that builtin instead of > trying to figure it out inside the libra

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:337 +std::string Nearest; +if (getOpts().findNearest("-" + ArgString, Nearest, IncludedFlagsBitmask, + ExcludedFlagsBitmask) == 1)

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, our boolean formulas (`BoolValue`)

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added a comment. In D135097#3840706 , @aaron.ballman wrote: > I'm also okay with this direction. I took a look to see if people seemed to > be using this option in their build scripts (maybe we would need a louder > deprecation period), and it

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

ldionne added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__refe

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae added a comment. In D133993#3840838 , @efriedma wrote: > It seems like it would be better to put the code in an LLVM IR transform > pass, if we can. It separates the concerns more clearly, and it would make > life easier for other compilers.

[PATCH] D135389: [Clang] Emit a warning for ambiguous joined '-o' arguments

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Test nit. LGTM otherwise. Comment at: clang/test/Driver/unknown-arg.c:73 +// O-WARN-NEXT: warning: joined argument treated as '-o utput'; did you mean '--output'? +// O-WARN-NOT:

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. Is this option really required? Can we just fix the regression as reported in https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't followed the policy late

<    1   2   3   >