arsenm added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:9424-9431 const bool IsHIPKernel = M.getLangOpts().HIP && FD && FD->hasAttr<CUDAGlobalAttr>(); + const bool IsOpenMPkernel = + M.getLangOpts().OpenMPIsDevice && + (F->getCallingConv() == llvm::CallingConv::AMDGPU_KERNEL); + if (IsHIPKernel || IsOpenMPkernel) ---------------- jhuber6 wrote: > arsenm wrote: > > Can we move this whole thing out of amdgpu code and into language code? > Do you mean moving this into each language's respective code generation / > sema? This seemed like the most straightforward place to put it as it's where > we attach other target specific attributes. But it's not actually a target specific attribute, it's a language property Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135374/new/ https://reviews.llvm.org/D135374 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits