[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 452095. ChuanqiXu added a comment. Remove `non-inline` terms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/CPlusPlus20Modules.rst clang/docs/index.rst Index: clang/docs/index.rs

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:395-396 + +Roughly, this theory is correct. But the problem is that it is too rough. Let's see what actually happens. +For example, the behavior also depends on the optimization level, as we will ill

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

mstorsjo added a comment. In D131528#3716876 , @shafik wrote: > In D131528#3715841 , @thakis wrote: > >> We're also still seeing the diag fire after this: >> https://ci.chromium.org/p/chromium/builders/ci/ToTLinu

[clang-tools-extra] 6e75ec5 - [clang-tidy] Support C++14 in bugprone-signal-handler.

Author: Balázs Kéri Date: 2022-08-12T09:45:53+02:00 New Revision: 6e75ec5e38dacb14c9ac9578c8e07548861b6d27 URL: https://github.com/llvm/llvm-project/commit/6e75ec5e38dacb14c9ac9578c8e07548861b6d27 DIFF: https://github.com/llvm/llvm-project/commit/6e75ec5e38dacb14c9ac9578c8e07548861b6d27.diff L

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added a comment. The target option was added, but I can not verify if the change fixes all the buildbots, we will see if it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 ___

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ilya-biryukov added a comment. In D112374#3716982 , @mizvekov wrote: > We even match GCC now: https://gcc.godbolt.org/z/WT93WdE7e > > Ie we are printing the function type as-written correctly now. We don't match GCC in other cases. GCC seems to always pr

[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

ChuanqiXu added a comment. In D129833#3717291 , @jyknight wrote: > Note that this change caused LLVM to no longer be aware that a TLS variable > cannot be NULL. Thus, code like: > > __thread int x; > int main() { > int* y = &x; > return *y; >

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

mstorsjo added a comment. I found another case of this warning, which is kinda borderline whether it really is an error not: #include static _Noreturn void my_exit(void) { exit(42); } __attribute__((noreturn)) void (*handler)(void) = my_exit; The fix is simple though, just be consi

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

sberg added a comment. In D131307#3714629 , @shafik wrote: > In D131307#3713011 , @sberg wrote: > >> With this commit, >> >> $ cat test.cc >> #include "boost/numeric/conversion/cast.hpp" >> int main() { retu

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. LGTM, thank you for this patch! I'll wait until Monday to let others have a look and then we can backport, I think it's useful and it's small enough to not be a problem. Could you ad

[clang] e6db064 - [doc] Remove release notes from the main branch for changes that were backported to 15.x

Author: Martin Storsjö Date: 2022-08-12T11:21:51+03:00 New Revision: e6db064394bc19aac906531564ce59e9de255cc1 URL: https://github.com/llvm/llvm-project/commit/e6db064394bc19aac906531564ce59e9de255cc1 DIFF: https://github.com/llvm/llvm-project/commit/e6db064394bc19aac906531564ce59e9de255cc1.diff

[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: sylvestre.ledru, andrewng, russell.gallop, phosek, beanz. CarlosAlbertoEnciso added projects: All, LLVM, clang. Herald added a subscriber: mgorny. CarlosAlbertoEnciso requested review of this revision. Herald added a s

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc updated this revision to Diff 452120. inclyc added a comment. move implemention of CheckTypeTraitArity into SemaExprCXX, since type traits are C++ specific language extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https:/

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:140 for (const Expr *Init : Sem->inits()) { +if (!Init) + continue; we should have this bail out after introducing the scope_exit below to make sure we skip the field

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 452123. usaxena95 added a comment. Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaD

[PATCH] D131479: Handle explicitly defaulted consteval special members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ac7cac3f14: Handle explicitly defaulted consteval special members. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 72ac7ca - Handle explicitly defaulted consteval special members.

Author: Utkarsh Saxena Date: 2022-08-12T12:13:06+02:00 New Revision: 72ac7cac3f14c905426ba7ff0c6c36ee3b3fb375 URL: https://github.com/llvm/llvm-project/commit/72ac7cac3f14c905426ba7ff0c6c36ee3b3fb375 DIFF: https://github.com/llvm/llvm-project/commit/72ac7cac3f14c905426ba7ff0c6c36ee3b3fb375.diff

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3718417 , @ilya-biryukov wrote: > We don't match GCC in other cases. GCC seems to always print the type name > without qualifiers, clang used to always print with qualifiers, but will now > print what was typed in t

[PATCH] D131724: [pseudo] Eliminate an ambiguity for the empty member declaration.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131724/new/ https://reviews.llvm.org/D131724

[PATCH] D131646: [clang][dataflow] Restructure loops to call widen on back edges

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:157 +// Returns whether `Block` is a "back edge" in the CFG. Such a block has only +// one successor, the start of the loop. Let's start function comments

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3718421 , @mstorsjo wrote: > I found another case of this warning, which is kinda borderline whether it > really is an error not: > > #include > static _Noreturn void my_exit(void) { > exit(42); > } >

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

mizvekov added a comment. In D131351#3718725 , @aaron.ballman wrote: > However, we don't care about the type mismatch when doing a redeclaration or > when dropping the attribute, as in: > > __attribute__((noreturn)) void my_exit(void); > void (*hand

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

mstorsjo added a comment. In D131351#3718725 , @aaron.ballman wrote: > In D131351#3718421 , @mstorsjo > wrote: > >> I found another case of this warning, which is kinda borderline whether it >> really is an err

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

hokein updated this revision to Diff 452141. hokein marked an inline comment as done. hokein added a comment. address review comment -- make sure we skip the corresponding field when its init expr is null, and polish the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

hokein added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:140 for (const Expr *Init : Sem->inits()) { +if (!Init) + continue; kadircet wrote: > we should have this bail out after introducing the scope_exit below to make > sure

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131730/new/ https://reviews.llvm.org/D131730 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] a1a1a78 - [pseudo] Eliminate an ambiguity for the empty member declaration.

Author: Haojian Wu Date: 2022-08-12T13:46:26+02:00 New Revision: a1a1a78ac8cf837e4c05152c9715f399b33bfb59 URL: https://github.com/llvm/llvm-project/commit/a1a1a78ac8cf837e4c05152c9715f399b33bfb59 DIFF: https://github.com/llvm/llvm-project/commit/a1a1a78ac8cf837e4c05152c9715f399b33bfb59.diff LO

[PATCH] D131724: [pseudo] Eliminate an ambiguity for the empty member declaration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a1a78ac8cf: [pseudo] Eliminate an ambiguity for the empty member declaration. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 1828c75 - [pseudo] Apply the function-declarator to member functions.

Author: Haojian Wu Date: 2022-08-12T13:49:01+02:00 New Revision: 1828c75d5f4ff657cf977476091fa224c8193e1d URL: https://github.com/llvm/llvm-project/commit/1828c75d5f4ff657cf977476091fa224c8193e1d DIFF: https://github.com/llvm/llvm-project/commit/1828c75d5f4ff657cf977476091fa224c8193e1d.diff LO

[PATCH] D131720: [pseudo] Apply the function-declarator to member functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1828c75d5f4f: [pseudo] Apply the function-declarator to member functions. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131762: [pseudo][wip] Enforce the C++ rule for the optional init-declarator-list.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Basically it implements the https://eel.is/c++draft/dcl.pre#5 rule. The moti

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6557-6558 +Here're resource binding examples with and without space: +``register(t3, space1)`` +``register(t1)`` +The full documentation is available here: https://docs.microsoft.com/en-us/win

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; thakis wrote: > This was to suppress false positi

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:157 +/// 1. https://docs.oasis-open.org/sarif/sarif/v2.1.0/os/sarif-v2.1.0-os.html#_Toc34317648";>level property +enum class SarifResultLevel { Note, Warning, Error }; + vaibhav.y

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. In D129694#3718225 , @ssquare08 wrote: > Yes, that is correct. My question is, is it okay to mangle the host and the > device side independently using `getTargetEntryUniqueInfo`? The reason I am > asking is because you had expre

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:144 }); -if (llvm::isa(Init)) +if (!Init || llvm::isa(Init)) continue; // a "hole" for a subob

[clang] 48e1250 - [clang][SVE] Undefine preprocessor macro defined in

Author: Maciej Gabka Date: 2022-08-12T12:25:49Z New Revision: 48e1250a91d244741c8677fed248ace1fcd7c41c URL: https://github.com/llvm/llvm-project/commit/48e1250a91d244741c8677fed248ace1fcd7c41c DIFF: https://github.com/llvm/llvm-project/commit/48e1250a91d244741c8677fed248ace1fcd7c41c.diff LOG:

[PATCH] D131580: [clang][SVE] Undefine preprocessor macro defined in

This revision was automatically updated to reflect the committed changes. Closed by commit rG48e1250a91d2: [clang][SVE] Undefine preprocessor macro defined in (authored by mgabka, committed by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

awarzynski added a comment. Left a few more comments and also added Diana as a reviewer. Would be good to get an extra pair of eyes on this :) Comment at: clang/include/clang/Driver/Options.td:6320-6325 +def pic_level : Separate<["-"], "pic-level">, + HelpText<"Value for __PI

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

hokein updated this revision to Diff 452155. hokein added a comment. update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131696/new/ https://reviews.llvm.org/D131696 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extr

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

hokein added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:144 }); -if (llvm::isa(Init)) +if (!Init || llvm::isa(Init)) continue; // a "hole" for a subobject that was not explicitly initialized kadircet wrote: > nit: can

[clang-tools-extra] 06b97b4 - [clangd] Fix an inlay-hint crash on a broken designator.

Author: Haojian Wu Date: 2022-08-12T14:37:46+02:00 New Revision: 06b97b4985ad0415f6cde4baad2bc7d73b456244 URL: https://github.com/llvm/llvm-project/commit/06b97b4985ad0415f6cde4baad2bc7d73b456244 DIFF: https://github.com/llvm/llvm-project/commit/06b97b4985ad0415f6cde4baad2bc7d73b456244.diff LO

[PATCH] D131696: [clangd] Fix an inlay-hint crash on a broken designator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06b97b4985ad: [clangd] Fix an inlay-hint crash on a broken designator. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; aaron.ballman wrote: > thakis wrote: > > This was to

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

erichkeane accepted this revision. erichkeane added a comment. Did @royjacobson 's patch make it to the 15.0 branch? If so, Roy: After this is committed, can you file to get this merged into the 15.x branch? This seems trivial enough (HAH!) of a fix that it is zero risk, and also keeps it from

[clang] e857896 - [ADT] Replace STLForwardCompat.h's C++17 equivalents

Author: Joe Loser Date: 2022-08-12T06:55:59-06:00 New Revision: e8578968f684997840f680ed62bff5cad0accc13 URL: https://github.com/llvm/llvm-project/commit/e8578968f684997840f680ed62bff5cad0accc13 DIFF: https://github.com/llvm/llvm-project/commit/e8578968f684997840f680ed62bff5cad0accc13.diff LOG

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8578968f684: [ADT] Replace STLForwardCompat.h's C++17 equivalents (authored by joe_loser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131717/new/ https:

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

mstorsjo added a comment. A different but slightly similar case, where I've run into these errors too, FWIW: On ARM, when compiling with a hardfloat target, Clang does consider a function pointer with `__attribute__((pcs("aapcs-vfp")))` different from one without, even if the default still in t

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. SO, I charted the differences in runtimes, and my patch is BETTER time-wise in release mode, but WORSE with asserts enabled. I don't know of any expensive assert that I added. SO, if everyone could review this, I'd love to get this committed to see if it beats the

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

zahen added a comment. In D131730#3718921 , @erichkeane wrote: > Did @royjacobson 's patch make it to the 15.0 branch? If so, Roy: After this > is committed, can you file to get this merged into the 15.x branch? This > seems trivial enough (HAH!) of

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

zahen added a comment. In D131730#3718430 , @royjacobson wrote: > Could you add name+email for the commit message? Zachary Henkel za...@microsoft.com Github Username: ZacharyHenkel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; ShawnZhong wrote: > ShawnZhong wrote: > > aaron.ball

[PATCH] D121365: [CFG] Fix crash on CFG building when deriving from a template.

courbet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121365/new/ https://reviews.llvm.org/D121365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. Pre-commit CI found build errors that should be addressed. Comment at: clang/include/clang/AST/TransformTypeTraits.def:1-2 +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. And for context, here is an actual bug this check would help find: https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1578#discussion_r889038610 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___

[clang] fba88ad - [Sema] Always perform ADL when searching for transormed operators in C++20

Author: Ilya Biryukov Date: 2022-08-12T16:07:02+02:00 New Revision: fba88adc8961fc8b8d7dece7bfecbfc31c652aff URL: https://github.com/llvm/llvm-project/commit/fba88adc8961fc8b8d7dece7bfecbfc31c652aff DIFF: https://github.com/llvm/llvm-project/commit/fba88adc8961fc8b8d7dece7bfecbfc31c652aff.diff

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

jdoerfert added a comment. This doesn't actually test much, only once case/compilation is covered. In the second function nothing specific to LLVM as impl is checked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131763/new/ https://reviews.llvm.o

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; ShawnZhong wrote: > ShawnZhong wrote: > > ShawnZh

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

saiislam added a comment. In D131763#3719132 , @jdoerfert wrote: > This doesn't actually test much, only once case/compilation is covered. In > the second function nothing specific to LLVM as impl is checked. The second function, is the only place in ll

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should add a release note for the change. Comment at: clang/lib/Basic/TypeTraits.cpp:64 +#define TYPE_TRAIT_N(Spelling, Name, Key) 0, +#include "c

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

samestep created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp created this revision. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Lambdas are implemented as regular

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

xazax.hun added a comment. LLVM switched to C++17 recently. I am not sure whether this means `std::optional` is preferred over `llvm::Optional`. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3902 }, - {/*.ApplyBuiltinTransfer=*

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

sgatev accepted this revision. sgatev added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:70 + ? TransferOptions{} +

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

samestep updated this revision to Diff 452193. samestep added a comment. Use llvm::None per Gábor's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131779/new/ https://reviews.llvm.org/D131779 Files: clang/include/clang/Analysis/FlowSen

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:70 + ? TransferOptions{} + : llvm::Optional()}) {} sgatev wrote: > I tried tha

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

samestep updated this revision to Diff 452196. samestep added a comment. Remove unnecessary explicit call to hasValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131779/new/ https://reviews.llvm.org/D131779 Files: clang/include/clang/Analysis/

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc updated this revision to Diff 452198. inclyc added a comment. add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https://reviews.llvm.org/D131423 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Type

[PATCH] D131388: [docs] Add "C++20 Modules"

ruoso added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:309 + +Remember to compile and link BMIs +~ I think this is a bit confusing. The BMI is not linked... Maybe something like: "Remember that modules still ha

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

inclyc updated this revision to Diff 452199. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131423/new/ https://reviews.llvm.org/D131423 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TypeTraits.h clang

[PATCH] D131268: [HLSL] Generate buffer subscript operators

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/buffer-array-operator.hlsl:3 + +const RWBuffer In; +RWBuffer Out; Why add const instead of using Buffer directly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

jdoerfert added a comment. In D131763#3719140 , @saiislam wrote: > In D131763#3719132 , @jdoerfert > wrote: > >> This doesn't actually test much, only once case/compilation is covered. In >> the second function

[clang] e582519 - [clang] fix frontend crash when evaluating type trait

Author: YingChi Long Date: 2022-08-13T00:02:19+08:00 New Revision: e5825190b8ad7ac8fe762fe4101cd4af04f4c057 URL: https://github.com/llvm/llvm-project/commit/e5825190b8ad7ac8fe762fe4101cd4af04f4c057 DIFF: https://github.com/llvm/llvm-project/commit/e5825190b8ad7ac8fe762fe4101cd4af04f4c057.diff

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5825190b8ad: [clang] fix frontend crash when evaluating type trait (authored by inclyc). Changed prior to commit: https://reviews.llvm.org/D13142

[PATCH] D131779: [clang][dataflow] Encode options using llvm::Optional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f1a6bf1080: [clang][dataflow] Encode options using llvm::Optional (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] b3f1a6b - [clang][dataflow] Encode options using llvm::Optional

Author: Sam Estep Date: 2022-08-12T16:29:41Z New Revision: b3f1a6bf1080fb67cb1760a924a56d38d51211aa URL: https://github.com/llvm/llvm-project/commit/b3f1a6bf1080fb67cb1760a924a56d38d51211aa DIFF: https://github.com/llvm/llvm-project/commit/b3f1a6bf1080fb67cb1760a924a56d38d51211aa.diff LOG: [cl

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

shafik added a comment. In D131528#3718405 , @mstorsjo wrote: > In D131528#3716876 , @shafik wrote: > >> In D131528#3715841 , @thakis wrote: >> >>> We're also still seeing

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3718982 , @mstorsjo wrote: > A different but slightly similar case, where I've run into these errors too, > FWIW: On ARM, when compiling with a hardfloat target, Clang does consider a > function pointer with `__

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

ayermolo added a comment. Was this and previous change intended to capture this case? const enum NumberType neg_one = (enum NumberType) ((enum NumberType) 0 - (enum NumberType) 1); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https:/

[PATCH] D131789: [clang-tools-extra] Rewrite prints in python3 compatible way

eoanermine created this revision. eoanermine added reviewers: klimek, HazardyKnusperkeks. eoanermine added a project: clang-tools-extra. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner

craig.topper added inline comments. Comment at: llvm/include/llvm/ADT/iterator_range.h:50 +/// As of C++17, the types of the begin-expr and the end-expr do not have to be +/// the same in 'based-range for loop'. This class represents a tag that should +/// be returned from the 'e

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

mstorsjo added a comment. In D131528#3719414 , @shafik wrote: > In D131528#3718405 , @mstorsjo > wrote: > >> In D131528#3716876 , @shafik wrote: >> >>> In D131528#3715841

[PATCH] D131793: Fix assert on startup in clang-doc

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. When using `clang-doc --format=

[PATCH] D131739: Fix some clang-doc issues.

brettw updated this revision to Diff 452227. brettw edited the summary of this revision. brettw added a comment. Startup assert fix broken out into https://reviews.llvm.org/D131793 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131739/new/ https://reviews.llvm.org/D131739 Files: clang

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae updated this revision to Diff 452232. python3kgae marked an inline comment as done. python3kgae added a comment. Limit to lower case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130033/new/ https://reviews.llvm.org/D130033 Files: c

[libunwind] b559777 - [libunwind] Remove __ANDROID_API__ < 18 workaround

Author: Fangrui Song Date: 2022-08-12T10:46:46-07:00 New Revision: b559777c308dcdf40a5dc8dffd35867083a46c3c URL: https://github.com/llvm/llvm-project/commit/b559777c308dcdf40a5dc8dffd35867083a46c3c DIFF: https://github.com/llvm/llvm-project/commit/b559777c308dcdf40a5dc8dffd35867083a46c3c.diff

[PATCH] D131793: Fix assert on startup in clang-doc

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is LGTM, but can you add a tag to the summary title/commit message? ie. `[clang-doc] Fix assert on startup in clang-doc` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D131739: Fix some clang-doc issues.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Can you update the summary to reflect what's in this change now + add a tag for clang-doc? `[clang-doc] Always emit the TagType for RecordInfo` I can land this and D131793

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:112-113 +} +if (!Tok.is(tok::identifier)) { + Diag(Tok.getLocation(), diag::err_expected) << tok::identifier; + SkipUntil(tok::r_paren, Sto

[clang-tools-extra] 42ee0d8 - [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the result is not used

Author: Aleksandr Platonov Date: 2022-08-12T21:00:11+03:00 New Revision: 42ee0d8c16f7052c3bc8434325868f48a501baf2 URL: https://github.com/llvm/llvm-project/commit/42ee0d8c16f7052c3bc8434325868f48a501baf2 DIFF: https://github.com/llvm/llvm-project/commit/42ee0d8c16f7052c3bc8434325868f48a501baf2.

[PATCH] D131706: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the result is not used

This revision was automatically updated to reflect the committed changes. Closed by commit rG42ee0d8c16f7: [clangd][unittests][IncludeCleaner] Don't call findReferencedFiles() if the… (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman added a comment. In D131351#3718728 , @mizvekov wrote: > In D131351#3718725 , @aaron.ballman > wrote: > >> However, we don't care about the type mismatch when doing a redeclaration or >> when dropp

[PATCH] D131793: [clang-doc] Fix assert on startup

brettw added a comment. In D131793#3719619 , @paulkirth wrote: > This is LGTM, but can you add a tag to the summary title/commit message? ie. > `[clang-doc] Fix assert on startup in clang-doc` Done Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6557-6558 +Here're resource binding examples with and without space: +``RWBuffer Uav : register(u3, space1)`` +``Buffer Buf : register(t1)`` +The full documentation is available here: https://

[PATCH] D131739: [clang-doc] Always emit the TagType for RecordInfo

brettw added a comment. In D131739#3719634 , @paulkirth wrote: > Can you update the summary to reflect what's in this change now + add a tag > for clang-doc? > > `[clang-doc] Always emit the TagType for RecordInfo` > > I can land this and D131793

[PATCH] D131796: [clang][deps] Use a cc1 invocation in FullDependencies::getCommandLine()

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of trying to "fix" the original driver invocatin by ap

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

aaron.ballman added a comment. > In D119051#3715939 , @aaron.ballman > wrote: > >> In D119051#3714645 , @dblaikie >> wrote: >> >>> >> >> I would have thought use of `__is_pod` would tell us, but I'm not seeing t

[clang-tools-extra] 75c7e79 - [clang-doc] Fix assert on startup

Author: Brett Wilson Date: 2022-08-12T18:37:23Z New Revision: 75c7e79464a3e77043571d187cd8019370326bcb URL: https://github.com/llvm/llvm-project/commit/75c7e79464a3e77043571d187cd8019370326bcb DIFF: https://github.com/llvm/llvm-project/commit/75c7e79464a3e77043571d187cd8019370326bcb.diff LOG:

[PATCH] D131793: [clang-doc] Fix assert on startup

This revision was automatically updated to reflect the committed changes. Closed by commit rG75c7e79464a3: [clang-doc] Fix assert on startup (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131793/new/ http

  1   2   >