[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. skc7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the ability to put __attribute__((maybe_undef))

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added a comment. I feel like we could land this sooner to avoid any unimagined failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 ___ cfe-commi

[clang] ecdeabe - enable P10 vector builtins test on AIX 64 bit; NFC

Author: Chen Zheng Date: 2022-07-21T03:51:30-04:00 New Revision: ecdeabef385d13bc0c3b935cc56b09883fd7b108 URL: https://github.com/llvm/llvm-project/commit/ecdeabef385d13bc0c3b935cc56b09883fd7b108 DIFF: https://github.com/llvm/llvm-project/commit/ecdeabef385d13bc0c3b935cc56b09883fd7b108.diff LO

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added a comment. Thanks for digging! Agreed then that reverting this patch won't really solve anything. I expect I can reproduce on linux by enabling LLVM_OPTIMIZED_TABLEGEN in the same way, looking into it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang-tools-extra] 2955192 - [pseudo] Make sure we rebuild pseudo_gen tool.

Author: Haojian Wu Date: 2022-07-21T10:09:21+02:00 New Revision: 2955192df8ac270515b5fa4aaa9e9380148e7f00 URL: https://github.com/llvm/llvm-project/commit/2955192df8ac270515b5fa4aaa9e9380148e7f00 DIFF: https://github.com/llvm/llvm-project/commit/2955192df8ac270515b5fa4aaa9e9380148e7f00.diff LO

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein added a comment. I'm sorry for the trouble it causes, and thanks for all details! > This could have something to do with "LLVM_OPTIMIZED_TABLEGEN": "ON", > perhaps, and there is some dependency missing to rebuild the NATIVE target. Yeah, the native clang-pseudo-gen tool didn't rebuild s

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

phosek created this revision. phosek added reviewers: abrachet, paulkirth. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This should provide a

[clang] 97af17c - re-land [C++20][Modules] Update handling of implicit inlines [P1779R3]

Author: Iain Sandoe Date: 2022-07-21T09:17:01+01:00 New Revision: 97af17c5cae64f5fd5e89806e8cf20f50fec30ec URL: https://github.com/llvm/llvm-project/commit/97af17c5cae64f5fd5e89806e8cf20f50fec30ec DIFF: https://github.com/llvm/llvm-project/commit/97af17c5cae64f5fd5e89806e8cf20f50fec30ec.diff L

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

This revision was automatically updated to reflect the committed changes. Closed by commit rG97af17c5cae6: re-land [C++20][Modules] Update handling of implicit inlines [P1779R3] (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12904

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3651074 , @whisperity wrote: > I will attempt to write a concise response to this today (and tomorrow)! > Sorry, I was away travelling to and doing post-action bureaucracy of > conferences the past few weeks. @aa

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. That way when

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

balazske updated this revision to Diff 446385. balazske added a comment. Fix in overlap check, replaced test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130091/new/ https://reviews.llvm.org/D130091 Files: clang/docs/analyzer/checkers.rst

[clang] 708084e - [PowerPC] Support x86 compatible intrinsics on AIX

Author: Qiu Chaofan Date: 2022-07-21T16:33:41+08:00 New Revision: 708084ec379ea8f409fbae6ba5d4154ea469f25a URL: https://github.com/llvm/llvm-project/commit/708084ec379ea8f409fbae6ba5d4154ea469f25a DIFF: https://github.com/llvm/llvm-project/commit/708084ec379ea8f409fbae6ba5d4154ea469f25a.diff L

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG708084ec379e: [PowerPC] Support x86 compatible intrinsics on AIX (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130160: [pseudo] Eliminate the dangling-else syntax ambiguity.

hokein updated this revision to Diff 446388. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130160/new/ https://reviews.llvm.org/D130160 Files: clang-tools-extra/p

[PATCH] D130160: [pseudo] Eliminate the dangling-else syntax ambiguity.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:25 + const TokenStream &Tokens; + SymbolID Lookahead; +}; sammccall wrote: > passing the position in the stream would be more general, there's no reason > in par

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

balazske added a comment. I did not found the existing tests in other files, now all tests for the "non-wide" functions are copied for the "wide" functions. I do not like fully this solution but a single test file with macros for wide and non-wide case is probably not better. Repository: rG

[PATCH] D130091: [clang][analyzer] Added partial wide character support to CStringChecker

balazske added inline comments. Comment at: clang/test/Analysis/wstring.c:385 + wchar_t a[32]; + // FIXME: This should work with 'w_str' instead of 'w_str1' + const wchar_t w_str1[] = L"Hello world"; The problem may be that the global constant is not encounter

[PATCH] D130231: [WIP][clang-doc] Improve the Markdown output

phosek created this revision. phosek added reviewers: abrachet, paulkirth. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This change tries to improve the usability of Markdown output, taking

[PATCH] D130231: [WIP][clang-doc] Improve the Markdown output

phosek updated this revision to Diff 446391. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130231/new/ https://reviews.llvm.org/D130231 Files: clang-tools-extra/clang-doc/MDGenerator.cpp Index: clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D130081: Add foldings for multi-line comment.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:1782 unsigned endCharacter; - std::string kind; + FoldingRangeKind kind; }; sorry for not being clear on my previous comment, I think the current `string kind;` is good, and it a

[clang] ea623af - [C++20] [Modules] Avoid inifinite loop when iterating default args

Author: Chuanqi Xu Date: 2022-07-21T17:25:05+08:00 New Revision: ea623af7c90f0c02fed72010a018cb1e259cca8d URL: https://github.com/llvm/llvm-project/commit/ea623af7c90f0c02fed72010a018cb1e259cca8d DIFF: https://github.com/llvm/llvm-project/commit/ea623af7c90f0c02fed72010a018cb1e259cca8d.diff LO

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

kito-cheng accepted this revision. kito-cheng added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130190/new/ https://reviews.llvm.org/D130190 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

ChuanqiXu updated this revision to Diff 446404. ChuanqiXu retitled this revision from "[Modules] Disable preferred_name attribute in C++20 Modules" to "[C++20] [Modules] Warn for the use of preferred_name in modules". ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Don'

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 446405. pmatos added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 446406. pmatos added a comment. Rebase on top of main. Add missing code in Sema* to ensure the new funcref builtin is checked for. Thanks to @asb for helping fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

ChuanqiXu added a comment. In D129748#3666511 , @tahonermann wrote: > I can imagine several ways in which things may be going wrong. Perhaps > (de)serialization is switching to a canonical declaration when it should not > be (e.g., reading/writing a de

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

ChuanqiXu added a comment. @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell the user honestly that we couldn't handle it (temporarily). We could still modularize the STL by a trick: https://github.com/ChuanqiXu9/stdmodules/blob/e81f4e9e74f96021f2e45c48f44da93e806c4524/M

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

usaxena95 added a comment. Would it make sense to expose this tool run + statistics as a library. This would help share the code for all the metrics with google3 (as we wanted to keep these metrics in both the places). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. In D130089#3666076 , @mizvekov wrote: > This seems to have introduced a test which always fails on windows: > > $ ":" "RUN: at line 4" > $ "cp" "clang\test\utils\update_cc_test_checks/Inputs/ifdef.c" > "build\llvm\tools\clan

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. This change broke standalone build of clang. Please fix. Comment at: clang/unittests/ASTMatchers/ASTMatchersInternalTest.cpp:15 #include "llvm/ADT/Triple.h" +#include "llvm/

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668022 , @nhaehnle wrote: > Aren't the before and after lines of the diff identical? Is this a Windows > new-lines issue? Yeah it looks like it from a glance, but I haven't had time to take a harder look at this ye

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm marked an inline comment as done. srishti-pm added inline comments. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:110 + /// operand at a particular point in time. + DenseSet visitedAncestors; + Mogball wrote: > Since this is a set of p

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. I've been staring at ifdef.test vs. basic-cplusplus.test for a while now and don't see any relevant difference, including when I look at the line endings in a hex editor (on Linux). So I guess there is a difference that appears only on Windows somehow? Unfortunately, I

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. In D129222#3667638 , @hokein wrote: > Yeah, the native clang-pseudo-gen tool didn't rebuild somehow even its > source file changes, it is a bug in our cmake config. Should be fixed in > 2955192df8ac270515b5fa4aaa9e9380148e7f00

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668061 , @nhaehnle wrote: > I've been staring at ifdef.test vs. basic-cplusplus.test for a while now and > don't see any relevant difference, including when I look at the line endings > in a hex editor (on Linux). S

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. My version of `diff` has a `--strip-trailing-cr` flag. But I don't really see that being used in many places at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130089/new/ https://reviews.llvm.org/D130089

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668111 , @nhaehnle wrote: > My version of `diff` has a `--strip-trailing-cr` flag. But I don't really see > that being used in many places at all. What I see is that the sources are checked out with the expected win

[clang] 396e944 - [Flang] Generate documentation for compiler flags

Author: Dylan Fleming Date: 2022-07-21T11:33:19Z New Revision: 396e944d82f3e212746cd241e4caba445523aff6 URL: https://github.com/llvm/llvm-project/commit/396e944d82f3e212746cd241e4caba445523aff6 DIFF: https://github.com/llvm/llvm-project/commit/396e944d82f3e212746cd241e4caba445523aff6.diff LOG:

[PATCH] D129864: [Flang] Generate documentation for compiler flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG396e944d82f3: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129864/new/ ht

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added a comment. In D129222#3668073 , @mizvekov wrote: > In D129222#3667638 , @hokein wrote: > >> Yeah, the native clang-pseudo-gen tool didn't rebuild somehow even its >> source file changes, it is a

[PATCH] D67025: Add .inl as valid C++ header type

aaron.ballman added a comment. In D67025#3666513 , @sammccall wrote: >> ! In D67025#3665293 , >> @aaron.ballman wrote: >> this is why we have the `-x` option so that users can specify a specific >> language mode

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Please note the NIT that arguably improves readability. Comment at: clang-tools-extra/clangd/tool/Check.cpp:114 Cmd = std::move(*TrueCmd); - l

[clang] ce82407 - Revert "[Flang] Generate documentation for compiler flags"

Author: Andrzej Warzynski Date: 2022-07-21T11:54:49Z New Revision: ce824078de2fbd46e8514e7f6e8b8dde6f201259 URL: https://github.com/llvm/llvm-project/commit/ce824078de2fbd46e8514e7f6e8b8dde6f201259 DIFF: https://github.com/llvm/llvm-project/commit/ce824078de2fbd46e8514e7f6e8b8dde6f201259.diff

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. I'm in C standards meetings this week and don't have a lot of ability to thoroughly review this yet, but the most immediate concern which springs to mind for me is that this is exposing LLVM implementation details to users. Users should not have to think about thi

[clang-tools-extra] 65c8e24 - [pseudo] Fix an invalid assertion on recoveryBrackets.

Author: Haojian Wu Date: 2022-07-21T14:02:11+02:00 New Revision: 65c8e246222940b458b72dddf7158303ca33c2ba URL: https://github.com/llvm/llvm-project/commit/65c8e246222940b458b72dddf7158303ca33c2ba DIFF: https://github.com/llvm/llvm-project/commit/65c8e246222940b458b72dddf7158303ca33c2ba.diff LO

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 ___ cfe-commits mailing list cfe-comm

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

arsenm added a comment. In D130224#3668225 , @aaron.ballman wrote: > It sounds like there's an extremely specific use case in mind for this > attribute; is there a reason why this needs to be the user's problem instead > of something the compiler can i

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. In D130224#3668240 , @arsenm wrote: > In D130224#3668225 , @aaron.ballman > wrote: > >> It sounds like there's an extremely specific use case in mind for this >> attribute; is ther

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

sebastian-ne created this revision. sebastian-ne added reviewers: awarzynski, PeteSteinfeld. Herald added a subscriber: mgorny. Herald added a project: All. sebastian-ne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copying the folder kee

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

arsenm added a comment. In D130224#3668243 , @aaron.ballman wrote: > In D130224#3668240 , @arsenm wrote: > >> In D130224#3668225 , >> @aaron.ballman wrote: >> >>> It sou

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin. Herald added subscribers: StephenFan, krytarowski, mgorny. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. I see what is going on here. The problem is not in this patch, but there is a problem in update_cc_test_checks.py. I had all the other files in `clang/test/utils/update_cc_test_checks` still checked out as unix line endings from before I had updated the config, and tha

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

upsj created this revision. upsj added reviewers: nridge, sammccall, kadircet. upsj added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

upsj added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:721 +} + )cpp" /*, ExpectedHint{"s: ", "param1"}, ExpectedHint{"x: ", "param2"}*/); +} I'm not sure whether we should detect this case, since it would be nice to h

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. This could cr

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. Repository:

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16198-16201 +if (EnumTy->isPromotableIntegerType()) + ED->setPromotionType(Context.getPromotedIntegerType(EnumTy)); +else + ED->setPromotionType(EnumTy); ---

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

mgorny added a comment. I'm sorry for noticing it this late but this change seems to have broken the test on 32-bit x86: FAIL: Clang :: Frontend/embed-object.ll (8280 of 15613) TEST 'Clang :: Frontend/embed-object.ll' FAILED Script: -- : 'RUN:

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 added a comment. In D122683#3668412 , @mgorny wrote: > I'm sorry for noticing it this late but this change seems to have broken the > test on 32-bit x86: Seems to be a difference in the alignment, I'm not sure why this changes though because th

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3667265 , @ChuanqiXu wrote: > In D126907#3665900 , @erichkeane > wrote: > >> The more I look at this... the more I question my approach. I now am >> definitely sure we won

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

rengolin added a comment. This looks great, thanks! Exciting that we can finally go all the way from C source to LoongArch binary. The changes look good to me, other than a few nits. But please wait for a day or two for other people to review on their own time. Comment at: c

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 added a comment. In D122683#3668423 , @jhuber6 wrote: > In D122683#3668412 , @mgorny wrote: > >> I'm sorry for noticing it this late but this change seems to have broken the >> test on 32-bit x86: > > See

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

erichkeane added a comment. In D129748#3667932 , @ChuanqiXu wrote: > @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell the > user honestly that we couldn't handle it (temporarily). We could still > modularize the STL by a trick:

[PATCH] D130265: [clangd] resolve forwarded parameters in Hover

upsj created this revision. upsj added reviewers: sammccall, kadircet. upsj added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. This us

Re: [clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

Ping :) On Mon, Jul 18, 2022 at 1:22 PM Manuel Klimek wrote: > Ping :) > > On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote: > >> This is a functional change, as it removes the debug output when the >> tokens do not match, which is important for understanding test failures. >> >> On Wed, Ju

[PATCH] D129048: Rewording the "static_assert" to static assertion

erichkeane added a comment. Tests ran clean for me as well. Looking at the CI, it appears that the libcxx tests are improperly configured, and are being run against an 'older' version of the compiler (not including this patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129048: Rewording the "static_assert" to static assertion

philnik added a comment. In D129048#3668542 , @erichkeane wrote: > Tests ran clean for me as well. Looking at the CI, it appears that the > libcxx tests are improperly configured, and are being run against an 'older' > version of the compiler (not inc

[PATCH] D129048: Rewording the "static_assert" to static assertion

philnik added a comment. Also, please wait for #libc approval next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 _

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 created this revision. yurai007 added reviewers: nikic, dexonsmith, wolfgangp, dblaikie. Herald added subscribers: jsji, ecnelises, pengfei, kbarton, hiraditya, nemanjai. Herald added a project: All. yurai007 requested review of this revision. Herald added projects: clang, LLVM. Herald ad

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a continuation of https://re

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added a comment. Instead adding one more constructor another option is tweaking existing SmallVector(const iterator_range &R) one in following way: - template - explicit SmallVector(const iterator_range &R) - : SmallVectorImpl(N) { + template , T>::value>> + SmallVec

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. The new test fails in the pre merge checks. Maybe the diff is missing some more changes? Comment at: clang-tools-extra/clangd/AST.cpp:794 }

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

nikic added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems : t

[clang] ceb6c23 - [NFC][LoopVectorize] Explicitly disable tail-folding on some SVE tests

Author: David Sherwood Date: 2022-07-21T15:23:00+01:00 New Revision: ceb6c23b708d4cae3fbb0a569c5ac14069524a63 URL: https://github.com/llvm/llvm-project/commit/ceb6c23b708d4cae3fbb0a569c5ac14069524a63 DIFF: https://github.com/llvm/llvm-project/commit/ceb6c23b708d4cae3fbb0a569c5ac14069524a63.diff

[PATCH] D129137: [NFC][LoopVectorize] Explicitly disable tail-folding on some SVE tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGceb6c23b708d: [NFC][LoopVectorize] Explicitly disable tail-folding on some SVE tests (authored by david-arm). Herald added a project: clang. Herald a

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

ro created this revision. ro added reviewers: MaskRay, glaubitz, jrtc27. ro added a project: clang. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. To make use of SPARC support in `getHostCPUName` as implemented by D

[PATCH] D129048: Rewording the "static_assert" to static assertion

ldionne added a comment. In D129048#3668594 , @philnik wrote: > Also, please wait for #libc approval > next time. This, x1000. We go through the trouble of having excellent pre-commit testing and automatic review g

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3668846 , @ldionne wrote: > In D129048#3668594 , @philnik wrote: > >> Also, please wait for #libc approval >> next time. > > This, x1

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM w/ the caveat that I think we should update the release notes, since we're changing the default behavior of a command line tool. I've also left a few small suggestions the wording.

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130279: [clang-doc] Add check for pointer validity

paulkirth created this revision. paulkirth added reviewers: phosek, abrachet. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. clang-doc would SEGV when running over the Fuchsia code base. T

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

nikic added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems : t

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[clang-tools-extra] 1515490 - [clangd] Mention whether compile flags were inferred in check mode

Author: Kadir Cetinkaya Date: 2022-07-21T17:33:44+02:00 New Revision: 1515490c80fab3d60da58efcfc91155228f7a156 URL: https://github.com/llvm/llvm-project/commit/1515490c80fab3d60da58efcfc91155228f7a156 DIFF: https://github.com/llvm/llvm-project/commit/1515490c80fab3d60da58efcfc91155228f7a156.dif

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG1515490c80fa: [clangd] Mention whether compile flags were inferred in check mode (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D130

[PATCH] D129048: Rewording the "static_assert" to static assertion

Mordante added a comment. In D129048#3668905 , @aaron.ballman wrote: > In D129048#3668846 , @ldionne wrote: > >> In D129048#3668594 , @philnik >> wrote: >> >>> Also, ple

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3667188 , @MaskRay wrote: > `forwardOptions` will be better if you are renaming it anyway. I'd rather create a separate patch and update all other methods to follow LLVM's style. Any idea why the style is not follo

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1446 +void bax(Args... args) { foo({args...}, args...); } + +void foo() { ilya-biryukov wrote: > NIT: maybe test for the case with a single expansion here: >

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet updated this revision to Diff 446529. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130261/new/ https://reviews.llvm.org/D130261 Files: clang-tools-

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130261/new/ https://reviews.llvm.org/D130261 _

[clang-tools-extra] b5871df - [clangd] Refactor forwarding call detection logic

Author: Kadir Cetinkaya Date: 2022-07-21T17:58:56+02:00 New Revision: b5871dfaf31873e6172f8a3fcd1e01e54498c811 URL: https://github.com/llvm/llvm-project/commit/b5871dfaf31873e6172f8a3fcd1e01e54498c811 DIFF: https://github.com/llvm/llvm-project/commit/b5871dfaf31873e6172f8a3fcd1e01e54498c811.dif

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5871dfaf318: [clangd] Refactor forwarding call detection logic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedElems

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446531. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/unitt

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

chrish_ericsson_atx added a comment. I've added a few suggestions for more rigorous testing, and raised a concern about a bug in this patch that is hiding expected -Warray-bounds warnings in certain cases. Comment at: clang/lib/CodeGen/CGExpr.cpp:888-889 if (const auto *CA

  1   2   3   >