mizvekov added a comment. I see what is going on here. The problem is not in this patch, but there is a problem in update_cc_test_checks.py.
I had all the other files in `clang/test/utils/update_cc_test_checks` still checked out as unix line endings from before I had updated the config, and that is why they were not failing. Fixing `update_cc_test_checks.py` and restoring those other files makes every test pass. Here is my diff: diff --git a/llvm/utils/update_cc_test_checks.py b/llvm/utils/update_cc_test_checks.py index b9e91f19461b..0e755d100760 100755 --- a/llvm/utils/update_cc_test_checks.py +++ b/llvm/utils/update_cc_test_checks.py @@ -414,7 +414,7 @@ def main(): output_lines, global_vars_seen_dict, True, False) common.debug('Writing %d lines to %s...' % (len(output_lines), ti.path)) with open(ti.path, 'wb') as f: - f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines]) + f.writelines(['{}{}'.format(l, os.linesep).encode('utf-8') for l in output_lines]) return 0 I will submit a MR with this patch later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130089/new/ https://reviews.llvm.org/D130089 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits