[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:263 +private: + std::vector> Vals; +}; `#include ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443982. wyt added a comment. Move `DebugStringGenerator` class into anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-f

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443983. wyt added a comment. Change propagated from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files: clang/include/clang/Analysis/FlowSensitive/Debu

[clang] 5791bcf - [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

Author: Chuanqi Xu Date: 2022-07-13T00:13:56+08:00 New Revision: 5791bcf9db0a3ec8bbce586dd99fce71fd773134 URL: https://github.com/llvm/llvm-project/commit/5791bcf9db0a3ec8bbce586dd99fce71fd773134 DIFF: https://github.com/llvm/llvm-project/commit/5791bcf9db0a3ec8bbce586dd99fce71fd773134.diff LO

[PATCH] D128974: [RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5791bcf9db0a: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo C

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

craig.topper accepted this revision. craig.topper added a comment. I also reviewed off-list and the X86 parts LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129572/new/ https://reviews.llvm.org/D129572 _

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers updated this revision to Diff 443986. nickdesaulniers added a comment. - add more links to commit message as they come in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129572/new/ https://reviews.llvm.org/D129572 Files: clang/doc

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:33-34 + explicit DebugStringGenerator( + llvm::DenseMap UserSpecifiedAtomNames) + : Counter(0), AtomNames(std::move(UserSpecifiedAtomNames

[clang] 2240d72 - [X86] initial -mfunction-return=thunk-extern support

Author: Nick Desaulniers Date: 2022-07-12T09:17:54-07:00 New Revision: 2240d72f15f3b7b9d9fb65450f9bf635fd310f6f URL: https://github.com/llvm/llvm-project/commit/2240d72f15f3b7b9d9fb65450f9bf635fd310f6f DIFF: https://github.com/llvm/llvm-project/commit/2240d72f15f3b7b9d9fb65450f9bf635fd310f6f.di

[PATCH] D129476: [AArch64][SVE] Prefer SIMD&FP variant of clast[ab]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Please update the comment, then LGTM Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:801 + Intrins

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2240d72f15f3: [X86] initial -mfunction-return=thunk-extern support (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Some nits inline, but looks good to me. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:119-133 +std::vector> LinesData; +for (auto &AtomAssignmen

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645660 , @nickdesaulniers wrote: > - add more links to commit message as they come in Oh, right, updating the commit message doesn't update the description in phab. Oops! Repository: rG LLVM Github Monor

[clang] 0b89d1d - [Sema] Add deprecation warnings for some compiler provided __has_* type traits

Author: Roy Jacobson Date: 2022-07-12T19:24:17+03:00 New Revision: 0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9 URL: https://github.com/llvm/llvm-project/commit/0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9 DIFF: https://github.com/llvm/llvm-project/commit/0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9.diff

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b89d1d59f82: [Sema] Add deprecation warnings for some compiler provided __has_* type traits (authored by royjacobson). Repository: rG LLVM Github

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:49-56 +debugString(std::vector &Constraints, Solver::Result &Result, +llvm::DenseMap AtomNames = {{}}); +inline std::string +debu

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Ah... I remember now, and I think that solution isn't quite right. The idea is that we want to defer constraint evaluation when the constraint is on a function decl/template decl. The PROBLEM I need to solve is when it is in a body of a struct or function. CHANGE

[PATCH] D129569: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

akyrtzi accepted this revision. akyrtzi added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129569/new/ https://reviews.llvm.org/D129569 ___ cfe-commits mailing list cfe-c

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

Vigilans added a comment. In my knowledge of clang-format, `Requires Clause` and `Requires Expression` are treated differently. In cppreference , A `Requires Clause` is specific to the `requires` keyword used for constraints on template a

[clang] 23d8eca - Silence a sphinx diagnostic; NFC

Author: Aaron Ballman Date: 2022-07-12T13:02:20-04:00 New Revision: 23d8ecaa9f97a34ddc80d0ee3fcf885aa0302855 URL: https://github.com/llvm/llvm-project/commit/23d8ecaa9f97a34ddc80d0ee3fcf885aa0302855 DIFF: https://github.com/llvm/llvm-project/commit/23d8ecaa9f97a34ddc80d0ee3fcf885aa0302855.diff

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Hmm... I think my approach was slightly off... I have to spend more time on this, but thanks for the review! I hope I'm learning each time we go again :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

erichkeane added a comment. Did a post-commit review on the CFE changes, and all look OK to me. That FIXME is a shame, we should see if we can fix that ASAP. We should AT LEAST document in the FIXME what semantics we are looking to emulate from GCC, and what those semantics ARE. Repository:

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645895 , @erichkeane wrote: > Did a post-commit review on the CFE changes, and all look OK to me. Thanks for the review! > That FIXME is a shame, we should see if we can fix that ASAP. We should AT > LEAST

[PATCH] D129542: [CodeGen] Add codegen of IR function attribute fine_grained_bitfields

jmciver created this revision. Herald added a project: All. jmciver published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change helps to prevents mixing fine grained and non fine grained bit-field addressing schemes, which can result in in

[clang] fcb7d76 - [coroutine] add nomerge function attribute to `llvm.coro.save`

Author: Yuanfang Chen Date: 2022-07-12T10:39:38-07:00 New Revision: fcb7d76d65e8df04ea54058cb5e9f2d63b13787a URL: https://github.com/llvm/llvm-project/commit/fcb7d76d65e8df04ea54058cb5e9f2d63b13787a DIFF: https://github.com/llvm/llvm-project/commit/fcb7d76d65e8df04ea54058cb5e9f2d63b13787a.diff

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb7d76d65e8: [coroutine] add nomerge function attribute to `llvm.coro.save` (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

erichkeane added a comment. In D129572#3645917 , @nickdesaulniers wrote: > In D129572#3645895 , @erichkeane > wrote: > >> Did a post-commit review on the CFE changes, and all look OK to me. > > Thanks for the re

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I would propose to move forward with this patch. It was partially discussed in https://reviews.llvm.org/D126781 and we can rely on a post-commit review if necessary. Repository:

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for publicly visible classes

aeubanks updated this revision to Diff 444013. aeubanks added a comment. Herald added subscribers: MaskRay, emaste. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClas

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. In D126864#3641939 , @serge-sans-paille wrote: > @kees are you ok with current state? Build tests are still looking correct on my end. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. I should clarify: I still need the =3 mode. Since sizeof([0]) == 0 and sizeof([]) == error, they are being treated differently already by the compiler causing bugs in Linux. The kernel must still have a way to reject the _use_ of a [0] array. We cannot reject _declaration_

[clang] 514dd3c - Update the status for more C DRs

Author: Aaron Ballman Date: 2022-07-12T14:06:39-04:00 New Revision: 514dd3c3c334251e573cf2201273ab3c38982e94 URL: https://github.com/llvm/llvm-project/commit/514dd3c3c334251e573cf2201273ab3c38982e94 DIFF: https://github.com/llvm/llvm-project/commit/514dd3c3c334251e573cf2201273ab3c38982e94.diff

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645934 , @erichkeane wrote: > Our typical rule is to keep the 1st one I think, and reject the 2nd. But then the _codegen_ will differ from GCC. And we _want_ clang to be a drop in replacement, so differing

[clang] a844378 - Change default C dialect for PS5 to gnu17/gnu18.

Author: Sunil Srivastava Date: 2022-07-12T11:14:56-07:00 New Revision: a844378b2bc2c0a7f18e8d7cdd259b6c4d443128 URL: https://github.com/llvm/llvm-project/commit/a844378b2bc2c0a7f18e8d7cdd259b6c4d443128 DIFF: https://github.com/llvm/llvm-project/commit/a844378b2bc2c0a7f18e8d7cdd259b6c4d443128.di

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa844378b2bc2: Change default C dialect for PS5 to gnu17/gnu18. (authored by Sunil_Srivastava). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129404/new/ htt

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

erichkeane added a comment. In D129572#3646004 , @nickdesaulniers wrote: > In D129572#3645934 , @erichkeane > wrote: > >> Our typical rule is to keep the 1st one I think, and reject the 2nd. > > But then the _co

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

Mordante added a comment. The libc++ build failures are due a broken libc++ HEAD. The current HEAD should work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 _

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:894 bool useObjCFPRetForRealType(FloatModeKind T) const { -return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T); +return (int)((FloatModeKind)RealTypeUsesObjCFPRe

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

MaskRay added a comment. In D129572#3646044 , @erichkeane wrote: > In D129572#3646004 , > @nickdesaulniers wrote: > >> https://godbolt.org/z/rf16T83Kj >> >> IMO, the standards bodies focusing on standardizing at

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

wyt updated this revision to Diff 444026. wyt marked an inline comment as done. wyt added a comment. Address comments: add used import, remove unused imports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129546/new/ https://reviews.llvm.org/D12954

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 444029. wyt marked an inline comment as done. wyt added a comment. Address comment on renaming parameter. Add const qualifier to BoolValue input to debugString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:537 llvm::json::Object{ - {"allCommitCharacters", -{" ", "\t", "(", ")", "[", "]",

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 444030. wyt marked 3 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files: clang/include/clang/Analysis

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt added a comment. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:119-133 +std::vector> LinesData; +for (auto &AtomAssignment : AtomAssignments) { + auto Name = getAtomName(AtomAssignment.first); + MaxNameLength = std::max(MaxNameLength, Name

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

wyt updated this revision to Diff 444031. wyt added a comment. Removed unused imports in SolverTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129546/new/ https://reviews.llvm.org/D129546 Files: clang/unittests/Analysis/FlowSensitive/Solv

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/DebugSupportTest.cpp:230 + +Unsatisfiable. + wyt wrote: > @xazax.hun > > I don't see a test case for `Unsatisfiable` constraints. >

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 updated this revision to Diff 444032. ziqingluo-90 added a comment. Taking @aaron.ballman 's advice to overload `callee` instead of creating a new matcher. Avoid to bloat `ASTMatchers.h`. Sorry to the reviewers that have to review this patch again. Repository: rG LLVM Github Mo

[PATCH] D129581: [Clang] Rework LTO argument handling in the linker wrapper

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, MaskRay, tra, ABataev, yaxunl, tianshilei1992. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan

[clang] 953ba18 - [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

Author: Nico Weber Date: 2022-07-12T15:09:04-04:00 New Revision: 953ba18fda9230c0ac382e90c62b3f48af311db7 URL: https://github.com/llvm/llvm-project/commit/953ba18fda9230c0ac382e90c62b3f48af311db7 DIFF: https://github.com/llvm/llvm-project/commit/953ba18fda9230c0ac382e90c62b3f48af311db7.diff LO

[PATCH] D129569: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

This revision was automatically updated to reflect the committed changes. Closed by commit rG953ba18fda92: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos… (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

davidxl added a comment. For coverage mode, why using 'incrementProfileCounter'? Should it be set to '1' instead? Also is the 'or' expression needed? The expression can be folded to either zero or 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 2346d19 - Speculatively fix this C DR test

Author: Aaron Ballman Date: 2022-07-12T15:18:03-04:00 New Revision: 2346d19a262eb6d62db9588afb154a5ef856dabb URL: https://github.com/llvm/llvm-project/commit/2346d19a262eb6d62db9588afb154a5ef856dabb DIFF: https://github.com/llvm/llvm-project/commit/2346d19a262eb6d62db9588afb154a5ef856dabb.diff

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Ping! Comment at: clang/lib/AST/OpenMPClause.cpp:1614-1617 + if (Node->getTI().Sets.size() == 0) { +OS << "default("; +return; + } ABataev wrote: > Is this correct? Just `default(` is expected to be printed? This fun

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 444044. ckissane added a comment. - make sure LLVM_ENABLE_ZSTD OFF turns into 0 - add zstd compression namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 File

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3642997 , @MaskRay wrote: > As I mentioned, the proper approach is to add zstd functionality along with > the CMake change, instead of adding CMake to all llvm-project components > without a way to test them. @MaskR

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

tra added a comment. Oops. Thank you for fixing this. Comment at: clang/test/CodeGenCUDA/shuffle_long_long.cu:52 + long long ll = 17; + ull = __shfl(ull, 7, 32); + ll = __shfl(ll, 7, 32); This crashes LLVM when we taget sm_70 where these instructions no long

[PATCH] D129583: [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Those two DRs about the (copy) triviality of types with deleted special member functions are not implemented in MSV

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646203 , @ckissane wrote: > In D128465#3642997 , @MaskRay wrote: > >> As I mentioned, the proper approach is to add zstd functionality along with >> the CMake change, instead

[clang-tools-extra] 93cd159 - [clangd] Remove `allCommitCharacters`

Author: Sam McCall Date: 2022-07-12T21:42:38+02:00 New Revision: 93cd159ca9d3cfd4afcd20cbfba9ef789a80bdda URL: https://github.com/llvm/llvm-project/commit/93cd159ca9d3cfd4afcd20cbfba9ef789a80bdda DIFF: https://github.com/llvm/llvm-project/commit/93cd159ca9d3cfd4afcd20cbfba9ef789a80bdda.diff LO

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

This revision was automatically updated to reflect the committed changes. Closed by commit rG93cd159ca9d3: [clangd] Remove `allCommitCharacters` (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D129579?vs=444015&id=444051#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D129586: [LinkerWrapper] Support remarks files for device LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: wenlei, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. Thanks for the review. @aaron.ballman @erichkeane. About the non-trailing pack, I had the impression that DR692 is only about the trailing pack in practice but don't remember the exact wording, so I dig the standardese further. For partial specialization: https://eel.is/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12177 +return X; + assert(X->getCanonicalDecl() == Y->getCanonicalDecl()); + // FIXME: Could return the earliest declaration between those two. Comment at: clang/lib/

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 444057. kastiglione added a comment. simplify error handling by checking for .pcm extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444 +if (TST1->getNumArgs()) { + const TemplateArgument &TA1 = TST1->template_arguments().back(); + if (TA1.getKind() == TemplateArgument::Pack) { aaron.ballman wr

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

aaron.ballman added a comment. In D129572#3646074 , @MaskRay wrote: > In D129572#3646044 , @erichkeane > wrote: > >> In D129572#3646004 , >> @nickdesaulniers wrote: >> >

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 444065. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Sema/Sema.

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 444066. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

rsmith accepted this revision. rsmith added a comment. Looks good to me. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6504-6516 // If we have function pointer types, unify them anyway to unify their // exception specifications, if any. if (LTy->isFunctionPointerTyp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3646066 , @Mordante wrote: > The libc++ build failures are due a broken libc++ HEAD. The current HEAD > should work again. Thanks for letting me know! Pushed my patches again just to have a look at the result, haven

[PATCH] D129583: [DOC] Add DR1734 and DR1496 Clang's cxx_dr_status as not implemented

aaron.ballman added a comment. Thanks for the updated tests! Some minor commenting suggestions (that will need to be re-flowed to 80 col limit), but otherwise LGTM! Comment at: clang/test/CXX/drs/dr14xx.cpp:510 +}; +// FIXME: A should not be trivial. +static_assert(__is_trivia

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rsmith accepted this revision. rsmith added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. Currently `CXXMethodDecl::isMoveAssignmentOperator()` does not look though type sugar and so if the parameter is a type alias it will not be able

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444074. cassanova added a comment. The ProtobufMutator CMake module will build targets for clang and lldb individually depending on which project is building the mutator, instead of both fuzzers trying to build the same target. The expression fuzzer's sou

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444078. ckissane added a comment. - add zstd tests to CompressionTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D129595: [clangd] Enable designator inlay hints by default.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis abandoned this revision. ellis added a comment. The function `__clang_call_terminate` seems to be a special case that clang builds itself. This diff might be too much for this rare specific case. Closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D122255: Meta directive runtime support

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10852 +def err_omp_misplaced_default_clause : Error< + "misplaced default clause! Only one default clause is allowed in" + "metadirective in the end">; ABataev wrote:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646258 , @MaskRay wrote: > In D128465#3646203 , @ckissane > wrote: > >> In D128465#3642997 , @MaskRay >> wrote: >> >>> As I mention

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() If feels wrong to me that the cl

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() mib wrote: > If feels wron

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3645795 , @Vigilans wrote: > In my knowledge of clang-format, `Requires Clause` and `Requires Expression` > are treated differently. > +1 for the enum, even if we only have 2 options yet. And yes, the op

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

SimplyDanny created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. SimplyDanny requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/55

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12225-12227 +#define NON_CANONICAL_TYPE(Class, Base) UNEXPECTED_TYPE(Class, "non-canonical") +#define TYPE(Class, Base) +#include "clang/AST/TypeNodes.inc"

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646561 , @ckissane wrote: > In D128465#3646258 , @MaskRay wrote: > >> In D128465#3646203 , @ckissane >> wrote: >> >>> In D128465#3642

[clang] a262f4d - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

Author: Jonas Devlieghere Date: 2022-07-12T15:22:29-07:00 New Revision: a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437 URL: https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437 DIFF: https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437.d

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

JDevlieghere added a comment. I had to revert this because it breaks a bunch of LLDB tests: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45288/#showFailuresLink. It looks like this causes an error when building some SDK modules. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for publicly visible classes

aeubanks updated this revision to Diff 444098. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/thinlto-distr

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen updated this revision to Diff 444099. ychen marked 4 inline comments as done. ychen added a comment. - add Clang ABI check - replace one NTTP with a local constexpr variable - style changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5423-5424 +template ::value> +static TemplateLikeDecl * aaron.ballman wrote: > Can't this be a local constexpr variable instead of an NTTP, or are there > reasons you want to allow

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added a comment. In D126864#3645994 , @kees wrote: > I should clarify: I still need the =3 mode. Since sizeof([0]) == 0 and > sizeof([]) == error, they are being treated differently already by the > compiler causing bugs in Linux. The kernel mu

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

abrahamcd added a subscriber: denik. abrahamcd added a comment. Hi! I'm interning with @cjdb and @denik this summer and I was working on adding a `-fdiagnostics-format=sarif` option to start off my project, but I just found that a previous abandoned version of this change (D109697

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/IR/GlobalValue.h:349 +const SanitizerMetadata& Meta = getSanitizerMetadata(); +return Meta.Memtag; + } `return

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Is there an ASan test to update? I guess before this change, for an ignorelisted global, ASan would emit wrongly typed declaration on the undef side - which should not cause any practi

[clang] a3cbb15 - [LinkerWrapper] Tweak save-temps output name

Author: Joseph Huber Date: 2022-07-12T19:42:04-04:00 New Revision: a3cbb158a277e62dfa19b3740012270b3cfd0a47 URL: https://github.com/llvm/llvm-project/commit/a3cbb158a277e62dfa19b3740012270b3cfd0a47 DIFF: https://github.com/llvm/llvm-project/commit/a3cbb158a277e62dfa19b3740012270b3cfd0a47.diff

[clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

Author: Jorge Gorbe Moya Date: 2022-07-12T16:46:58-07:00 New Revision: ee88c0cf09969ba44307068797e12533b94768a6 URL: https://github.com/llvm/llvm-project/commit/ee88c0cf09969ba44307068797e12533b94768a6 DIFF: https://github.com/llvm/llvm-project/commit/ee88c0cf09969ba44307068797e12533b94768a6.di

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

hctim updated this revision to Diff 444111. hctim marked an inline comment as done. hctim added a comment. Final comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128950/new/ https://reviews.llvm.org/D128950 Files: clang/lib/CodeGen/Saniti

<    1   2   3   >