cassanova added inline comments.
================
Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5
+ set (PBM_PREFIX clang_protobuf_mutator)
+elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb")
+ set (PBM_PREFIX lldb_protobuf_mutator)
+endif()
----------------
mib wrote:
> If feels wrong to me that the clang protobuf cmake module knows about lldb.
>
> May be we should just have 2 separate files for clang and lldb
My preferred solution to this was just creating a target called
${LLVM_VARIABLE_THAT_TELLS_YOU_THE_SUBPROJECT_NAME}_protobuf_mutator to avoid
using if-statements and direct strings but it looks like clang and lldb aren't
defined as subprojects unless they're being built standalone.
Also in the event that some other subproject wanted to use this library then
this solution just gets messier. Having 2 different CMake module files for the
clang and lldb sides each or putting protobuf mutator in a more central
location is another way to approach this
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129377/new/
https://reviews.llvm.org/D129377
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
