[PATCH] D124349: [analyzer] Get direct binding for specific punned case

martong accepted this revision. martong added a comment. LGTM! Thanks Vince! Comment at: clang/test/Analysis/array-punned-region.c:38 + ff.b[0] = 3; + clang_analyzer_eval(*((int *)pff + 2) == 3); // expected-warning{{TRUE}} // Or should this be `pff + 3` ??? +}

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

martong added a comment. Very good, this is a great initiative! Also, the quality of this patch is high, docs are great, even the release notes are updated. I would accept if I were that confident in Clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

balazske added a comment. It looks mostly good now, apart from the line 1 comment problem. Usually in a review all phabricator diffs are created against the original commit or at least against an existing (in the current github repository) commit, here the last diff seems to be against an other

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

akuegel created this revision. Herald added a project: All. akuegel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124995 Files: clang/lib/ExtractAPI/ExtractAPIConsumer.cp

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/include/clang/Tooling/LevDistance.h:1 +//===--- LevDistance.h --*- C++ -*-===// +// ken-matsui wrote: > aaron.ballman wrote: > > You shouldn't need this file or the imple

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

martong added a comment. Looks promising, I am close to accept this, thanks! Comment at: clang/include/clang/Analysis/ConstructionContext.h:122-124 assert(isa(E) || isa(E) || - isa(E) || isa(E)); + isa(E) || isa(E) || + isa(E)); --

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

alok updated this revision to Diff 427237. alok added a comment. re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124982/new/ https://reviews.llvm.org/D124982 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/CodeGen/CGOpenMPRuntime.cpp c

[clang] cc344d2 - [clang] Add static_cast to fix Bazel build.

Author: Adrian Kuegel Date: 2022-05-05T10:29:47+02:00 New Revision: cc344d262a2eaa65f9e380f5b1eeb03a7048fa39 URL: https://github.com/llvm/llvm-project/commit/cc344d262a2eaa65f9e380f5b1eeb03a7048fa39 DIFF: https://github.com/llvm/llvm-project/commit/cc344d262a2eaa65f9e380f5b1eeb03a7048fa39.diff

[PATCH] D124995: [clang] Add static_cast to fix Bazel build.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcc344d262a2e: [clang] Add static_cast to fix Bazel build. (authored by akuegel). Repository: rG LLVM Github Monorepo C

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added a comment. In D124690#3492981 , @upsj wrote: > I will take a different approach to the matchers: For each CallExpr involving > parameter packs, record the arguments (if they are a ParmVarDecl or > stdForward(ParmVarDecl)) and the matchin

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:106-126 +// FIXME: Move ASTMatcher library. +// Note: Taken from UnusedUsingDeclsCheck. +AST_POLYMORPHIC_MATCHER_P( +forEachTemplateArgument, +AST_POLYMORPHIC_SUPPO

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. > ! In D124690#3493246 , @sammccall > wrote: > > This makes sense to me. > This sounds more complicated, but if I'm reading correctly this multi-level > forwarding isn't handled in the current version of the patch either? > At som

[PATCH] D124448: [clang-tidy] Add project-level analysis support to misc-discarded-return-value

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/DiscardedReturnValueCheck.cpp:132 + + auto IDIt = FunctionIDs.find(FD); + if (IDIt == FunctionIDs.end()) { Please spell out the type instead of `auto`. Comment at:

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

martong added a comment. > The patch adds two new checkers. I don't see any technical dependencies between the two, so, please split it into two independent patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 ___

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427245. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/test/Analysis/additive-op-on-sym-int-expr.c clang/test/Analy

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

martong added a comment. Also, could you please update the `Static Analyzer` section of `clang/docs/ReleaseNotes.rst` with the new checkers and their description? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124244/new/ https://reviews.llvm.org/D124244 ___

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

martong added a comment. Maybe it is not too late to update the clang/docs/ReleaseNotes.rst? A new checker is certainly important for the users. Many thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D12048

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 427246. vabridgers added a comment. fix a stupid leftover cut/paste mistake in the test case :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files: clang/lib/

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers marked an inline comment as done. vabridgers added a comment. Thanks @martong. I fixed the "typo" :/, landing. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349

[clang] df58018 - [analyzer] Get direct binding for specific punned case

Author: einvbri Date: 2022-05-05T04:53:45-05:00 New Revision: df5801806d03c22099c85942134ca3004776016b URL: https://github.com/llvm/llvm-project/commit/df5801806d03c22099c85942134ca3004776016b DIFF: https://github.com/llvm/llvm-project/commit/df5801806d03c22099c85942134ca3004776016b.diff LOG:

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5801806d03: [analyzer] Get direct binding for specific punned case (authored by einvbri ). Repository: rG LLVM Gi

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. UTF8 char literals are always unsigned. Fixes https://github.com/llvm/

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427252. phyBrackets added a comment. address inline comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h In

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. I'm having a problem , this patch expected to address the previous inline comment but after making the specific change and committing it , when I'm creating the patch using //arc diff --update // , the changes were suddenly gone and I thought that maybe the changes

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

MattDevereau created this revision. MattDevereau added reviewers: paulwalker-arm, peterwaller-arm, bsmith, DavidTruby, dtemirbulatov. Herald added subscribers: ctetreau, psnobl, arphaman, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a reviewer: aaron.ballman. Herald add

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427259. phyBrackets added a comment. address inline comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h In

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. In D124774#3493382 , @phyBrackets wrote: > I'm having a problem , this patch expected to address the previous inline > comment but after making the specific change and committing it , when I'm > creating the patch using //

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427261. phyBrackets added a comment. Correct the number of character in line 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/AS

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 427262. ken-matsui added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update codes as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.l

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Thanks, I think this is a neat idea! I haven't had the chance to review thoroughly yet, but wanted to point out that precommit CI is showing a fair amount of failures that I believe are related to your patch. Repository:

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 427263. ken-matsui added a comment. Remove unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427264. phyBrackets added a comment. address the buildbot failing issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImport

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

jansvoboda11 added inline comments. Comment at: clang/include/clang/Lex/PreprocessorOptions.h:213 + std::function>( + FileEntryRef)> + DependencyDirectivesForFile; You'll need to `#include "clang/Basic/FileEntry.h"`. Build with modules fails otherwise

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:255 + )cpp", + ExpectedHint{"a: ", "param"}); +} upsj wrote: > sammccall wrote: > > upsj wrote: > > > I haven't been able to figure out why,

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

aaron.ballman added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:16 char f = u8'ab'; // expected-error {{Unicode character literals may not contain multiple characters}} #elif __STDC_VERSION__ > 202000L char a = u8'ñ'; // expected-error {{character

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

DavidSpickett added a comment. I think that this has caused assert failures on the VLS (fixed sized vector) SVE bot. https://lab.llvm.org/buildbot/#/builders/176/builds/1632/steps/12/logs/stdio Based on the other SVE change being in llvm and seeing Sema in the backtrace. These issues are not o

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427267. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/u

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3491985 , @sammccall wrote: > I'm still concerned some users will find this a large regression and we won't > have a good workaround: > > - it'll use a lot more battery than before On Intel Macs, I'm not sure tha

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1994 + case OO_Equal: + case OO_PlusEqual: + case OO_MinusEqual: If we're going to be handling these, should we also be handling overloads of `++` and `--`? ===

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit, I think this LGTM. Thank you for working on this! Comment at: clang/lib/Sema/SemaChecking.cpp:476 +analyze_printf::PrintfSpecifier S

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Presuming precommit CI comes back green, this LGTM! Can you also add a release note for the bug fix when landing, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Seems right. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 ___ cfe-commits mailin

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter updated this revision to Diff 427275. RosieSumpter marked 3 inline comments as done. RosieSumpter added a comment. - Changed operand names to be more descriptive - Made int/uint/float variables global - Moved bfloat tests into a separate file CHANGES SINCE LAST ACTION https://revi

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource added a comment. I do not have commit rights. Would it be possible to you to commit the changes on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 ___ cfe-comm

[PATCH] D124983: [HLSL} add -fcgl option flag.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; Any particular reason for

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/utf8-char-lit

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6168 llvm::Value *EVal = CGF.EmitScalarExpr(E); + if (auto CI = dyn_cast(EVal)) +EVal = CGF.Builder.CreateIntCast( 1. `auto *CI` 2. What if this is not a constant, but just a va

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { aaron.ballman wrote: > mboehme wrote: > > aaron.ballman wrote: > > > mboehme wrote: > > > > aaron.ballman wrot

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgrang. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. With this patch, we're able to parse small

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

kadircet added a comment. Thanks this LGTM. Just two questions: - Why not migrate rest of the usages and drop the old function completely in this patch - What about moving the function from clang/Frontend to Tooling, Support or FrontendTool? this is clearly only inteded to be used by tools and

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added a comment. In D111548#3483326 , @xbolva00 wrote: > Please answer points in “ Contributing Extensions to Clang “ > https://clang.llvm.org/get_involved.html I've added these to the RFC: https://discourse.llvm.org/t/rfc-new-attribute-annotate

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added a comment. In D111548#3483326 , @xbolva00 wrote: >>> The intent is to allow adding arbitrary annotations to types for use in >>> static analysis tools > > This patch should not land until we see some real use cases to justify new > h

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6168 llvm::Value *EVal = CGF.EmitScalarExpr(E); + if (auto CI = dyn_cast(EVal)) +EVal = CGF.Builder.CreateIntCast( ABataev wrote: > 1. `auto *CI` > 2. What if this is not

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks! It would be nice to rebase the patch and see the pre-commit CI passing, but then again you're the one dealing with the buildbots if you break anything, so do as you prefer :) Rep

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. Looks good to me with minor nits. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, ---

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427289. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/utf8-char-lit

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. @manas gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

peterwaller-arm added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, peterwaller-arm wrote: > It shouldn't matter in principle (... "but in practice" ...) we should > probab

[PATCH] D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! as discussed offline, let's move forward with what you proposed (i.e. this patch, and then flip the default while making libclang opt-in) Comment at: clan

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

sammccall added a comment. In D124971#3493657 , @kadircet wrote: > Thanks this LGTM. Just two questions: > > - Why not migrate rest of the usages and drop the old function completely in > this patch In order to keep the patch small. I can do this as a f

[clang] 40c1372 - [Frontend] give createInvocationFromCommandLine an options struct

Author: Sam McCall Date: 2022-05-05T15:12:07+02:00 New Revision: 40c13720a4b977d4347bbde53c52a4d0703823c2 URL: https://github.com/llvm/llvm-project/commit/40c13720a4b977d4347bbde53c52a4d0703823c2 DIFF: https://github.com/llvm/llvm-project/commit/40c13720a4b977d4347bbde53c52a4d0703823c2.diff LO

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG40c13720a4b9: [Frontend] give createInvocationFromCommandLine an options struct (authored by sammccall). Repository: rG

[PATCH] D124955: [clang-tidy] Make header-guard check a little looser on comment whitespace

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think `"// FOO_BAR_H"` in your message should be `"// FOO_BAR_H" ` (two space). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124955/new/ ht

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 427296. ymandel added a comment. Fixed the FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAcc

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, peterwaller-arm wrote: > peterwaller-arm wrote: > > It shouldn't matter in principle (... "but in practice"

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel added a comment. In D124932#3492495 , @xazax.hun wrote: > Overall looks good to me. I am curious what will the strategy be to properly > support construction. Do you plan to introduce a customization point to > `Env.createValue` to give checks/m

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear there are necessary changes (at least to unbreak the C ABI). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

kadircet added a comment. I agree that clangd's indexing should probably be higher priority than whatever FS indexing is going on (because clangd's indexing only start when user actually starts working on a project, hence this indicates some level of "interactiveness"). so I feel like the right

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

tschuett added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, aaron.ballman wrote: > peterwaller-arm wrote: > > peterwaller-arm wrote: > > > It shouldn't matter in principle

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Specifiers.h:283 CC_AArch64VectorCall, // __attribute__((aarch64_vector_pcs)) +CC_AArch64SVEPcs, // __attribute__((aarch64_sve_pcs)) }; aaron.ballman wrote: > I continue to be con

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin updated this revision to Diff 427297. DiggerLin marked an inline comment as done. DiggerLin added a comment. address MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: cl

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. Just wanted to say this is not a new calling convention as such, but rather an existing one that is generally auto-detected based on function signature. The problem we're trying to solve here is that we need a way to allow a user to force the calling convention

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane accepted this revision. erichkeane added a comment. FWIW, I'm in favor of the patch as it sits. As a followup: So I was thinking about the "%s" specifier for string types. Assuming char-ptr types are all strings is a LITTLE dangerous, but more so the way we're doing it. Its a shame

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

TiehuZhang updated this revision to Diff 427300. TiehuZhang added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix the failed case (optimization-remark-options.c), because the remark info should be updated Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. is there still any problem ? I'm not sure ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe-commits mailing list cfe-commit

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! And please accept my apologies @v.g.vassilev for taking it months to review this small change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119675/new

[clang] c894e85 - In MSVC compatibility mode, handle unqualified templated base class initialization

Author: Fred Tingaud Date: 2022-05-05T16:03:39+02:00 New Revision: c894e85fc64dd8d83b460de81080fff93c5ca334 URL: https://github.com/llvm/llvm-project/commit/c894e85fc64dd8d83b460de81080fff93c5ca334 DIFF: https://github.com/llvm/llvm-project/commit/c894e85fc64dd8d83b460de81080fff93c5ca334.diff

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGc894e85fc64d: In MSVC compatibility mode, handle unqualified templated base class… (authored by frederic-tingaud-sonarsource, committed by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

balazske added a comment. The code looks correct but the diff is not OK. I think that you have separate commits for every change (instead of changing the first with `git commit --amend` when a new change is made). In this case `arc diff --update main` may work (if you have a separate branch fo

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `#pragma alloc_text` is a MSVC pragma that names the code section where functions should be placed. It only applies to fu

[PATCH] D124816: [Tooling] use different FileManager for each CWD

Kale updated this revision to Diff 427313. Kale added a comment. Fix path in compile_commands.json for windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124816/new/ https://reviews.llvm.org/D124816 Files: clang/include/clang/Basic/FileManag

[PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. (Followup from 40c13720a4b9

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel created this revision. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. Eugene.Zelenko retitled this revision from "[clang][tidy] New check for safe usage of `std::optional` and like types." to "[clang-tidy] New check for safe usage of `std::optional` and like

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

martong added a comment. In D124774#3493868 , @balazske wrote: > The code looks correct but the diff is not OK. I think that you have separate > commits for every change (instead of changing the first with `git commit > --amend` when a new change is mad

[PATCH] D124816: [Tooling] use different FileManager for each CWD

Kale updated this revision to Diff 427317. Kale added a comment. Format all overriding functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124816/new/ https://reviews.llvm.org/D124816 Files: clang/include/clang/Basic/FileManager.h clang/in

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. I think changes are needed to make this behavior dependent on whether `char8_t` support is active or not. Comment at: clang/lib/Lex/PPExpressions.cpp:413

[PATCH] D125014: [Driver] Remove -fno-concept-satisfaction-caching

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. The flag was added when the C++20 draft did not allow for concept caching. The final C++20 standard permits th

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets updated this revision to Diff 427322. phyBrackets added a comment. Rebase several commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h cl

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter updated this revision to Diff 427320. RosieSumpter added a comment. - Corrected name `const_b16_ptr` to `const_bf16_ptr` in acle_sve2_bfloat.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124850/new/ https://reviews.llvm.org/D124850 Files: clang/test/CodeGen/aarch64-s

[clang-tools-extra] 04b4190 - [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

Author: Sam McCall Date: 2022-05-05T16:47:17+02:00 New Revision: 04b419048955fc33718ba97e79f3558b6a27830e URL: https://github.com/llvm/llvm-project/commit/04b419048955fc33718ba97e79f3558b6a27830e DIFF: https://github.com/llvm/llvm-project/commit/04b419048955fc33718ba97e79f3558b6a27830e.diff LO

[PATCH] D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG04b419048955: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd (authored by sammccall). Changed prior to commit: https://reviews

[PATCH] D104975: Implement P1949

tahonermann added a comment. > Since it is a C++23 feature, can we at least have it only if the user > requests C++23 standard compliance? WG21 adopted P1949 as a defect report (DR) against prior standards with the intent that the changes be applied retroactive

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3493446 , @aaron.ballman wrote: > precommit CI is showing a fair amount of failures that I believe are related > to your patch. It was me who helped @bahramib to rebase and split a much larger and more convoluted

[PATCH] D124983: [HLSL} add -fcgl option flag.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; aaron.ballman wrote: > Any partic

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

aaron.ballman added a comment. In D124221#3493792 , @erichkeane wrote: > FWIW, I'm in favor of the patch as it sits. > > As a followup: So I was thinking about the "%s" specifier for string types. > Assuming char-ptr types are all strings is a LITTLE d

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tahonermann added inline comments. Comment at: clang/lib/Lex/PPExpressions.cpp:413 Val.setIsUnsigned(!TargetInfo::isTypeSigned(TI.getWCharType())); -else if (!Literal.isUTF16() && !Literal.isUTF32()) +else if (!Literal.isUTF8() && !Literal.isUTF16() && !Literal.isU

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added a comment. In D124221#3494000 , @aaron.ballman wrote: > In D124221#3493792 , @erichkeane > wrote: > >> FWIW, I'm in favor of the patch as it sits. >> >> As a followup: So I was thinking about th

[clang] ad2263d - [Sema] Replace invalid FIXME about memory leak. NFC

Author: Ilya Biryukov Date: 2022-05-05T15:04:11Z New Revision: ad2263de9f75119626f316e253fdc1de28d5c23a URL: https://github.com/llvm/llvm-project/commit/ad2263de9f75119626f316e253fdc1de28d5c23a DIFF: https://github.com/llvm/llvm-project/commit/ad2263de9f75119626f316e253fdc1de28d5c23a.diff LOG:

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 427329. steplong added reviewers: rnk, aaron.ballman, hans. steplong added a comment. Update patch to error out if a function is not C linkage. Not sure how to check if a function has been declared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   3   >