aaron.ballman added a comment. In D111548#3483326 <https://reviews.llvm.org/D111548#3483326>, @xbolva00 wrote:
>>> The intent is to allow adding arbitrary annotations to types for use in >>> static analysis tools > > This patch should not land until we see some real use cases to justify new > hundreds of lines of code. We should more careful and take maintenance cost > really into account and not merge every experimental cool research extensions > automatically. > > Please answer points in “ Contributing Extensions to Clang “ > https://clang.llvm.org/get_involved.html Sorry, I had missed this. The justification is from the original RFC on adding lifetime annotation checking to the clang static analyzer (https://discourse.llvm.org/t/rfc-new-attribute-annotate-type-iteration-2). I think this code has utility as a general-purpose mechanism in the same manner that the existing declaration annotation attribute does. As attribute code owner, I think this meets the bar for a contribution as an extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
