sammccall added a comment. In D124971#3493657 <https://reviews.llvm.org/D124971#3493657>, @kadircet wrote:
> Thanks this LGTM. Just two questions: > > - Why not migrate rest of the usages and drop the old function completely in > this patch In order to keep the patch small. I can do this as a followup. > - What about moving the function from clang/Frontend to Tooling, Support or > FrontendTool? this is clearly only inteded to be used by tools and not part > of the Frontend. There's actually Tooling/Tooling.h which has a > `newInvocation` that takes in cc1 args, rather than driver args. so these two > seem like siblings. Sounds reasonable to me, but I'm not personally planning to work on it. Note that ASTUnit depends on this, so there's some layering mess to clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124971/new/ https://reviews.llvm.org/D124971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
