[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

owenpan added a comment. Should we handle `#import` and `@import` for Object-C only so as to simply the regex for C++? Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:136 +/// #include +/// @include bar; +/// #include "bar.h" I think you m

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 423343. nridge marked 5 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files: clang-tools-e

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:858 } ExprResult Awaitable = buildOperatorCoawaitCall(*this, Loc, E, Lookup); if (Awaitable.isInvalid()) sammccall wrote: > (aside, this variable name is really unfortunate: I thi

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke created this revision. Sockke added reviewers: malcolm.parsons, hokein, alexfh. Herald added a project: All. Sockke requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. If two different texts are inserted at the same off

[PATCH] D123926: [clang] Add a raw_ostream operator<< overload for QualType

njames93 created this revision. njames93 added reviewers: rsmith, dblaikie, aaron.ballman. Herald added a subscriber: martong. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Under the hood this prints

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok added a comment. In D123787#3452970 , @aprantl wrote: >> For an example, if thread local variable is present in copyin clause >> (testcase attached with the > > patch), parameter with same name is generated as parameter to artificial > function. Wh

Re: [clang-tools-extra] 3eeca52 - Fix wrong signature for std::move and std::swap in test.

Thanks for fixing this one. It seems like there's a related bootstrap failure that may be worth looking into as well: https://lab.llvm.org/buildbot/#/builders/119/builds/8131 https://lab.llvm.org/buildbot/#/builders/168/builds/5806 ~Aaron On Sun, Apr 17, 2022 at 10:25 PM Richard Smith via cfe-co

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke updated this revision to Diff 423355. Sockke retitled this revision from "[WIP][clang-apply-replacements] Added support for adjusting conflict offset." to "[clang-apply-replacements] Added support for adjusting conflict offset.". Sockke added a comment. Herald added a subscriber: carlosgal

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:5281 + SourceLocation TemplateKwLoc, + bool HasTrailingLParen); + This parameter is always f

[PATCH] D123924: [clang-apply-replacements] Added support for adjusting conflict offset.

Sockke added a comment. It stands to reason that there should be no insert conflicts in the YAML generated by clang-tidy except for the header insertion. The two checks that caused the conflict should be fixed in clang-tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ ht

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4889-4890 return T->isArrayType(); + case UTT_IsBoundedArray: +return T->isArrayType() && !T->isIncompleteArrayType(); + case UTT_IsUnboundedArray: cjdb wrote: > aaron.ball

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:700 + + if (Tok.is(tok::identifier) && NextToken().is(tok::r_paren)) { +SourceLocation TemplateKWLoc; aaron.ballman wrote: > This feels surprisingly restrictive to me, but it's suff

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 423359. Sockke retitled this revision from "[clang-apply-replacements] Added support for adjusting conflict offset." to "[clang-apply-replacements] Added an option to ignore insert conflict.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added inline comments. Comment at: clang/include/clang/Sema/Sema.h:5281 + SourceLocation TemplateKwLoc, + bool HasTrailingLParen); + aaron.ballman wrote: > This par

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok updated this revision to Diff 423362. alok added a comment. Re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123787/new/ https://reviews.llvm.org/D123787 Files: clang/include/clang/AST/Decl.h clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test

[PATCH] D122008: [flang][driver] Add support for generating executables

clementval added a comment. Do you plan to discuss this again at during the next call? Note that today is a holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 is probably better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423363. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Aaron's feedback - Typos - Remove unused parameters - return ExprError() if ParseUnqualifiedId fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:5281 + SourceLocation TemplateKwLoc, + bool HasTrailingLParen); + cor3ntin wrote: > aaron.ba

Re: [PATCH] D123479: [clang-tidy] Support parenthesized literals in modernize-macro-to-enum

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang] 2121dc5 - [llvm-lto] Remove support for legacy pass manager

___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added a comment. We should probably add a release note that says we partially implement CWG 2569 (just the `decltype` portion) and that the core issue has not yet been approved by WG21 but the changes are needed to keep libstdc++ working. Comment at: clang/lib/P

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:700 + + if (Tok.is(tok::identifier) && NextToken().is(tok::r_paren)) { +SourceLocation TemplateKWLoc; aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > This feel

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); Why do we need to use `IgnoreImpCasts()` here and in other places? Repository: rG LLVM Github Mon

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:700 + + if (Tok.is(tok::identifier) && NextToken().is(tok::r_paren)) { +SourceLocation TemplateKWLoc; cor3ntin wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > aaron.bal

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. @DavidSpickett @chill @momchil.velikov May I get some comments on the `arm/aarch64` related code changes? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 __

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:700 + + if (Tok.is(tok::identifier) && NextToken().is(tok::r_paren)) { +SourceLocation TemplateKWLoc; aaron.ballman wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > cor3ntin

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

erichkeane added a comment. 1 nit, otherwise no comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2703 + UnqualifiedId &Id) { + InMutableAgnosticContext = true; + ExprResult Res = ActOnIdExpression(S, SS, /*TemplateKwLoc*/

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423365. cor3ntin added a comment. - Add a release note - Add tests for lookup errors in decltype expressions in lambda parameters clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123909/new/ https://revie

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 updated this revision to Diff 423366. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123612/new/ https://reviews.llvm.org/D123612 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/gcc/avr/5.4.0/avr5

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

erichkeane added a comment. Pretty sure those OMP bugs are unrelated, we've been seeing those a ton lately on just about every patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 _

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman added a reviewer: beanz. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh",

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423367. cor3ntin added a comment. - Use a RAII class to control InMutableAgnosticContext - Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123909/new/ https://reviews.llvm.org/D123909 Files: clang/

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2703 + UnqualifiedId &Id) { + InMutableAgnosticContext = true; + ExprResult Res = ActOnIdExpression(S, SS, /*TemplateKwLoc*/ erichkeane wrot

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit (forgot to remove a line covered by RAII). Comment at: clang/lib/Sema/SemaExpr.cpp:2704-2712 + ExprResult Res = ActOnId

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added subscribers: urnathan, erichkeane. hvdijk added a comment. ping. Apologies, I don't know who to add as a reviewer, there is no one specifically listed as code owner and it does not seem to be handled by anyone in particular. @urnathan, @erichkeane, you two appear to be the most rece

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423368. cor3ntin added a comment. Thanks Aaron, let's pretend this did not happen :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123909/new/ https://reviews.llvm.org/D123909 Files: clang/docs/ReleaseNotes

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. @rjmccall is the expert on the Itanium ABI. Code wise, I have no real comments, though he might. As far as: >> Question: does this need to be covered by -fclang-abi-compat= when the prior >> mangling resulted in names that even llvm-cxxfilt agreed made no sense? (I

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423370. cor3ntin added a comment. ... and we don't need a local variable anymore either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123909/new/ https://reviews.llvm.org/D123909 Files: clang/docs/ReleaseNo

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:537-543 + static StringRef getPrimaryModuleInterfaceName(StringRef Name) { +return Name.split(':').first; + } + /// Get the primary module interface name from a partition. StringRef getPrimary

[clang] daa6d7b - [Clang] Use of decltype(capture) in parameter-declaration-clause

Author: Corentin Jabot Date: 2022-04-18T15:58:25+02:00 New Revision: daa6d7b250edb81ffef7770a71049d7af211698b URL: https://github.com/llvm/llvm-project/commit/daa6d7b250edb81ffef7770a71049d7af211698b DIFF: https://github.com/llvm/llvm-project/commit/daa6d7b250edb81ffef7770a71049d7af211698b.diff

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa6d7b250ed: [Clang] Use of decltype(capture) in parameter-declaration-clause (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added a comment. @aaron.ballman @erichkeane Thanks for the review - I've landed it. Hopefully the remediation should be enough so that libstdc++ is no longer affected but we should still keep an eye out for further issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. The remediation has landed, sorry again for the trouble this caused, I'll keep an eye out for further issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

grandinj added a comment. thanks for the quick response Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. Generally looking good to me, mostly just drive-by commentary at this point. Comment at: clang/include/clang/Sema/DeclSpec.h:407 static bool isTypeRep(TST T) { -return (T == TST_typename || T == TST_typeofType || -T == TST_under

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

yaxunl created this revision. yaxunl added reviewers: tra, jhuber6. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. Rename gpu.used.external as __clang_gpu_used_external as ptxas does not allow . in global variable name. Fixes: https://git

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

aaron.ballman added a comment. Generally looks correct to me, but I did have some questions about the types used in the fix. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235 SmallVector Files; + std::vector ExpressionNames; FileState *CurrentF

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123946/new/ https://reviews.llvm.org/D123946 ___ cfe-commits mailing list cfe-commits

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added inline comments. Comment at: clang/test/CodeGenCXX/no_auto_return_lambda.cpp:8 + +// CHECK: !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed) +// CHECK-NOT: !DIBasicType(tag: DW_TAG_unspecified_type, name: "auto") aprantl wrote: > This tes

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh", +"amplificat

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6409-6411 +- The attribute will not cause any additional data to be output to LLVM IR, + object files or debug information. It is only intended to be consumed using + Clang APIs by source-lev

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_drive

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/annotate-type.c:6 +void foo(float * [[clang::annotate_type("foo")]] a) { + int [[clang::annotate_type("bar")]] x1; + int * [[clang::annotate_type("bar")]] x2; Is it possible to typedef int [[clang::ann

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

vitalybuka added a comment. It's broken again here https://lab.llvm.org/buildbot/#/builders/74/builds/10427 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_driv

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

paulkirth added a comment. Hi, this is also breaking Fuchsia's clang CI builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8816531831869640417/overview). If this will be hard to address, would you mind reverting until a patch is ready? Repository: rG

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

dblaikie added a comment. In D121959#3454606 , @tahonermann wrote: >> This might've caused a regression? >> (https://github.com/llvm/llvm-project/issues/54892) > > @dblaikie, it most definitely did. Note that I'm the author of the patch that > introduc

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423416. jhuber6 added a comment. Herald added a subscriber: mattd. Splitting major changes into two files as per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D1

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

efriedma abandoned this revision. efriedma added a comment. Opened https://github.com/llvm/llvm-project/issues/54963 to more specifically track the clang issue. With b27430f , it should be easy enough to special-case calls to

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

rtrieu added a comment. This seems to be acting weird in template instantations. Here's an example where the lambda only errors inside a template. template int foo(int x = 0) { auto lambda = [x = x+1]() -> decltype(x) { return x; }; return -1; } // no tem

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks! If it fails CI we might want to submit the tests and the code change separately, but I'm fine with trying it as one block in the first instance. Repository:

[PATCH] D123950: Look through calls to std::addressof to compute pointer alignment.

efriedma created this revision. efriedma added reviewers: jyknight, rsmith, rjmccall. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. This is sort of a followup to D37310 ; that basically fixed the same issue

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

rjmccall added a comment. In D123898#3455933 , @theraven wrote: > I'd like to. The test case from the original bug report was very large but > I'm not sure how to trigger this with anything comprehensibly small. You > need something where the callee i

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:764 + int t30[F(__is_bounded_array(void*))]; + int t31[F(__is_bounded_array(cvoid*))]; +} aaron.ballman wrote: > cjdb wrote: > > aaron.ballman wrote: > > > Any reason there's not a test

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3456964 , @paulkirth wrote: > Hi, this is also breaking Fuchsia's clang CI builders > (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8816531831869640417/overview). > If this will be

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

tstellar added a comment. In D123850#3453750 , @cor3ntin wrote: > @tstellar I wasn't sure what the procedure was for backporting fixes, so I > made a PR. I think your suggestion of keeping the old signature works well. > This also modifies the serialized

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423426. hvdijk added a comment. Herald added a subscriber: dexonsmith. Allow the old mangling with suitable -fclang-abi-compat= value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llv

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3456507 , @erichkeane wrote: > I believe the answer here is 'yes'. We also likely need release notes. Thanks for the feedback. -fclang-abi-compat= support added. Other mangling bugfixes appear to not have made it int

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. In D122663#3457130 , @hvdijk wrote: > In D122663#3456507 , @erichkeane > wrote: > >> I believe the answer here is 'yes'. We also likely need release notes. > > Thanks for the feedback

[PATCH] D123950: Look through calls to std::addressof to compute pointer alignment.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123950/new/ https://reviews.llvm.org/D123950 ___

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, kpn. Herald added subscribers: dexonsmith, martong. Herald added a reviewer: shafik. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. AST does not ha

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423428. python3kgae added a comment. Add more detail to the doc. Update the attribute name according to the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 F

[clang] e43c93d - Don't treat 'T &forward(T&&)' as builtin.

Author: Richard Smith Date: 2022-04-18T11:11:21-07:00 New Revision: e43c93dd63cca295ef26ab69cd305816a71d45fd URL: https://github.com/llvm/llvm-project/commit/e43c93dd63cca295ef26ab69cd305816a71d45fd DIFF: https://github.com/llvm/llvm-project/commit/e43c93dd63cca295ef26ab69cd305816a71d45fd.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3457109 , @rsmith wrote: > I'm working on a fix. I'll revert if it takes me more than a few minutes. If > you'd prefer to not wait, please feel free to revert it yourself. Thanks for your patience, should be fixed in

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423433. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D122831 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

bulbazord updated this revision to Diff 423437. bulbazord edited the summary of this revision. bulbazord added a comment. Herald added a subscriber: mgorny. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://reviews.llvm.org/D122691 Files: clang/include/cl

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman added a comment. Mostly looks good, just some nits with the documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:6388 +identify the shader type for the entry function. +The format is [shader("shadertype")]. +Normally the shader type is set by shader ta

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3457131 , @erichkeane wrote: > Our most recent direction is to document any non-NFC patches in the release > notes if at all sensible, so I think this meets those requirements. Thanks, I'm not finding documentation of

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:764 + int t30[F(__is_bounded_array(void*))]; + int t31[F(__is_bounded_array(cvoid*))]; +} cjdb wrote: > aaron.ballman wrote: > > cjdb wrote: > > > aaron.ballman wrote: > > > > A

[clang] 9ec501d - [OpenMP] Refactor OMPScheduleType enum.

Author: Michael Kruse Date: 2022-04-18T14:03:17-05:00 New Revision: 9ec501da76fc1559cadd6d6dac32766bf4376a3d URL: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d DIFF: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d.diff

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec501da76fc: [OpenMP] Refactor OMPScheduleType enum. (authored by Meinersbur). Changed prior to commit: https://reviews.llvm.org/D123403?vs=42286

[clang] ae23be8 - [OpenMP] Make the new offloading driver the default

Author: Joseph Huber Date: 2022-04-18T15:05:09-04:00 New Revision: ae23be84cb60357829078e832613660bfe98687f URL: https://github.com/llvm/llvm-project/commit/ae23be84cb60357829078e832613660bfe98687f DIFF: https://github.com/llvm/llvm-project/commit/ae23be84cb60357829078e832613660bfe98687f.diff

[clang] 15e6206 - [Clang][Docs] Update information on the new driver now that it's default

Author: Joseph Huber Date: 2022-04-18T15:05:09-04:00 New Revision: 15e62062c0c919ac1fa28d6f0c9f438063da2286 URL: https://github.com/llvm/llvm-project/commit/15e62062c0c919ac1fa28d6f0c9f438063da2286 DIFF: https://github.com/llvm/llvm-project/commit/15e62062c0c919ac1fa28d6f0c9f438063da2286.diff

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae23be84cb60: [OpenMP] Make the new offloading driver the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423445. hvdijk added a comment. Add to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. LGTM! I would like @rjmccall to take a pass if he ends up having time in the next day or two (perhaps tack on an extra day or two because of Easter), else I'll be willing to approve later in the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); ABataev wrote: > Why do we need to use `IgnoreImpCasts()` here and in other places? Clang usua

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, eli.friedman, hubert.reinterpretcast, erichkeane, clang-language-wg. Herald added subscribers: dexonsmith, jdoerfert, martong. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423448. python3kgae added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391 +Normally the shader type is set by shader target with the -T option like +-Tps_6_1. +When compiling to a library target like lib_6_3, the shader type attribute can aar

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes) How tough would it be to change this to represent

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes)

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman updated this revision to Diff 423451. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123955/new/ https://reviews.llvm.org/D123955 Files: clang/docs/ReleaseNote

[PATCH] D122663: Mark identifier prefixes as substitutable

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubstitution(reinterpret_cast(NNS));

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes) aaron.ballman wrote: > erichkeane wrote: > > How t

[clang] af02851 - Revert "[OpenMP] Refactor OMPScheduleType enum."

Author: Michael Kruse Date: 2022-04-18T14:38:31-05:00 New Revision: af0285122f306573d9bcc4c4ad7f904cfdd4d869 URL: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869 DIFF: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869.diff

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

cor3ntin added a comment. Thanks for working on this, Just a few comments Comment at: clang/lib/Basic/LangOptions.cpp:119 Opts.Digraphs = Std.hasDigraphs(); + Opts.StrictPrototypes = Std.isCPlusPlus() || Std.isC2x(); Stupid question, we probably don't wan

  1   2   >