aaron.ballman added a comment.
Mostly looks good, just some nits with the documentation.
================
Comment at: clang/include/clang/Basic/AttrDocs.td:6388
+identify the shader type for the entry function.
+The format is [shader("shadertype")].
+Normally the shader type is set by shader target with the -T option like
----------------
================
Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391
+Normally the shader type is set by shader target with the -T option like
+-Tps_6_1.
+When compiling to a library target like lib_6_3, the shader type attribute can
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123907/new/
https://reviews.llvm.org/D123907
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
