[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

2022-03-30 Thread Ben Barham via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham). Repository: rG LLVM Github Monorepo CHA

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2022-03-30 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
dhruvachak added a comment. Herald added a project: All. I added https://github.com/llvm/llvm-project/issues/54654 documenting what I found when testing this patch on amdgpu. @ggeorgakoudis Can you please rebase this patch on top of main? Thanks. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122756: [clang-format] Fix a crash in qualifier alignment

2022-03-30 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Related to #54

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

2022-03-30 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 419240. ymandel marked 5 inline comments as done. ymandel added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files: clang/lib/Analys

[clang] ff6696c - Expanding HLSL attribute diagnostics

2022-03-30 Thread Chris Bieneman via cfe-commits
Author: Chris Bieneman Date: 2022-03-30T14:15:01-05:00 New Revision: ff6696c842bac0b15fc04015b25ead721768eac9 URL: https://github.com/llvm/llvm-project/commit/ff6696c842bac0b15fc04015b25ead721768eac9 DIFF: https://github.com/llvm/llvm-project/commit/ff6696c842bac0b15fc04015b25ead721768eac9.diff

[PATCH] D122748: [Sema] Don't check bounds for function pointer

2022-03-30 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX updated this revision to Diff 419242. ArcsinX added a comment. Check for function type only if IsUnboundedArray is true Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122748/new/ https://reviews.llvm.org/D122748 Files: clang/lib/Sema/Sema

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

2022-03-30 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. @aaron.ballman I pushed updates in rGff6696c842ba . The one bit we discussed that I didn't do anything for is the template case. Neither clang or the HLSL compiler support parsing Microsoft attributes on

[PATCH] D122748: [Sema] Don't check bounds for function pointer

2022-03-30 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added a comment. In D122748#3417240 , @erichkeane wrote: > That said, we might not want to early-exist here, I think we can just skip > the `IsUnboundedArray` branch? It seems you are right, thanks, fixed. Repository: rG LLVM Github Monorep

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like either this or your other commit at the same time broke tests on windows: http://45.33.8.238/win/55345/step_7.txt Please take a look, and revert for now if it takes a while to fix. (Also, please add a "Differential Revision: https://reviews.llvm.org/D122611";

[PATCH] D122748: [Sema] Don't check bounds for function pointer

2022-03-30 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I think I'm generally in favor, would still like to see the feedback from the original submitter here to see if there is more work to do in here that would be valuable. Comment at: clang/lib/Sema/SemaChecking.cpp:15471 if (IsUnboundedArray) { +

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

2022-03-30 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 419243. ymandel added a comment. delete line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessM

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

2022-03-30 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:275 + State.Env.getValue(*ValueOrPredExpr, SkipPast::None)); + if (ExprValue == nullptr) { +auto &ExprLoc = State.Env.createStorageLocation(*ValueOrPredE

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 _

[clang] 985eaa1 - [clang][extract-api][NFC] Don't remap the generated input buffer in PPOpts

2022-03-30 Thread Daniel Grumberg via cfe-commits
Author: Daniel Grumberg Date: 2022-03-30T20:38:09+01:00 New Revision: 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e URL: https://github.com/llvm/llvm-project/commit/985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e DIFF: https://github.com/llvm/llvm-project/commit/985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e.dif

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

2022-03-30 Thread Alister Johnson via Phabricator via cfe-commits
ajohnson-uoregon updated this revision to Diff 419248. ajohnson-uoregon added a comment. Okay, I put the assert back in and made a thing similar to HasSizeMatcher that works and all the tests pass. What do you mean by a release note, in the commit message, in the docs...? Repository: rG LLVM

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. @thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me? Repository: rG LLVM Github Monorepo C

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

2022-03-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D120949#3417545 , @ajohnson-uoregon wrote: > Okay, I put the assert back in and made a thing similar to HasSizeMatcher > that works and all the tests pass. > > What do you mean by a release note, in the commit message,

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

2022-03-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D122627#3417495 , @beanz wrote: > @aaron.ballman I pushed updates in rGff6696c842ba > . > > The one bit we discussed that I didn't do anything for is t

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

2022-03-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6965-6966 // Parse GNU attributes, if present. MaybeParseGNUAttributes(ParmDeclarator); +MaybeParseHLSLSemantics(DS.getAttributes()); beanz wrote: > aaron.ballman wrote

[PATCH] D122759: [time-report] Add timers to codegen actions

2022-03-30 Thread Wei Wang via Phabricator via cfe-commits
weiwang created this revision. Herald added subscribers: ormris, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122759 File

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. My windows bot cycled green, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

2022-03-30 Thread Alister Johnson via Phabricator via cfe-commits
ajohnson-uoregon updated this revision to Diff 419252. ajohnson-uoregon added a comment. Removing specific argument matchers and leaving just hasKernelConfig() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120952/new/ https://reviews.llvm.org/D1209

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

2022-03-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang closed this revision. dang added a comment. a9909d23e9bb8c4649cba1c14d479c28df4ca185 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122648/new/ https://reviews.llvm.org/D122648 __

[PATCH] D122611: [clang][extract-api] Add support for macros

2022-03-30 Thread Daniel Grumberg via Phabricator via cfe-commits
dang closed this revision. dang added a comment. 529a0570f7e8c5144bd3ad057e43f00e3af58d1b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

2022-03-30 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: asavonic, dexonsmith, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D122760: [OpenMP] Add OpenMP variant extension to keep the unmangled name

2022-03-30 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. The test currently fails because we don't do the stripping when we emit the precompiled header, it will simply be imported using the mangled version and it will not have in the original input info associated with it. I will need to figure out where we emit the PCH defin

[PATCH] D115232: [clangd] Indexing of standard library

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 419259. sammccall marked 15 inline comments as done. sammccall added a comment. Herald added a project: All. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.l

[PATCH] D115232: [clangd] Indexing of standard library

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. (sorry about the long delay, would still love to merge this) Comment at: clang-tools-extra/clangd/index/StdLib.cpp:92 + // The umbrella header is the same for all versions of each language. + // Headers that are unsupported in old lang versions are

[PATCH] D122759: [time-report] Add timers to codegen actions

2022-03-30 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 419261. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122759/new/ https://reviews.llvm.org/D122759 Files: clang/include/clang/Frontend/FrontendAction.h clang/include/clang

[PATCH] D115232: [clangd] Indexing of standard library

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 419262. sammccall added a comment. Revert StdLibLocation to realpath, document why Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files: clang-tools-extra/clangd

[PATCH] D115232: [clangd] Indexing of standard library

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 419265. sammccall added a comment. revert to previous version of realpath code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files: clang-tools-extra/clangd/CMa

[PATCH] D115232: [clangd] Indexing of standard library

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:313 +llvm::StringRef DirPath = llvm::sys::path::parent_path(HeaderPath); +if (!HS.getFileMgr().getVirtualFileSystem().getRealPath(DirPath, Path)) + SearchPaths.emplace_back(Path);

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

2022-03-30 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson. Herald add

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

2022-03-30 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao updated this revision to Diff 419277. ayzhao added a comment. Remove errant diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/lib/AST/Expr.cpp clang/lib/Lex/PPMacroExpansion.cpp

[PATCH] D122768: [Clang] Support capturing structured bindings in lambdas

2022-03-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added subscribers: carlosgalvezp, martong, arphaman, zzheng. Herald added a reviewer: shafik. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald a

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

2022-03-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. This is not quite mature. I think it needs a few more tests, notably codegen tests which I'm not sure how to write properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

2022-03-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 419281. cor3ntin added a comment. Remote commented-out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConve

[PATCH] D121556: [randstruct] Add randomize structure layout support

2022-03-30 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 419282. void added a comment. Moved the randomization to a better spot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/include/clang/AST/Decl.h clang/i

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

2022-03-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9060 continue; - const VarDecl *VD = LC.getCapturedVar(); + const VarDecl *VD = cast(LC.getCapturedVar()); if (LC.getCaptureKind() != LCK_ByRef && !VD->getType()->isPointer

[PATCH] D122377: [PowerPC][Linux] Support 16-byte lock free atomics on pwr8 and up

2022-03-30 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:45 +// PPC64: @q = global %struct.Q zeroinitializer, align 16{{$}} +// AIX64: @q = global %struct.Q zeroinitializer, align 1{{$}} _Atomic(Q) q; // expected-no-diagnostics

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

2022-03-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. As said elsewhere, I think this is too simplistic. It's good to make this dependent on the triple, instead of on the host platform. But we should have a flag that controls which slash direction to use on windows triples, since different people will want different things.

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

2022-03-30 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. (I don't think the argument about '\' in include lines applies to this patch (?)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 ___ c

[clang] f6740fe - [clang-format] Indent import statements in JavaScript.

2022-03-30 Thread via cfe-commits
Author: sstwcw Date: 2022-03-30T23:17:27Z New Revision: f6740fe483e9fa0c76aa9f176ff68f51f47a1302 URL: https://github.com/llvm/llvm-project/commit/f6740fe483e9fa0c76aa9f176ff68f51f47a1302 DIFF: https://github.com/llvm/llvm-project/commit/f6740fe483e9fa0c76aa9f176ff68f51f47a1302.diff LOG: [clang

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

2022-03-30 Thread sstwcw via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6740fe483e9: [clang-format] Indent import statements in JavaScript. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

2022-03-30 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. Maybe it's because I removed the final empty line when I pasted the diff as I thought that LF was a line terminator instead of a line separator. I will try using arc from now on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

2022-03-30 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D122627#3417557 , @aaron.ballman wrote: > Are you sure that's what you want? This returns true for a static C++ member > function, false for a static free function, and false for within an unnamed > namespace, and true otherwi

[clang] 907d3ac - [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

2022-03-30 Thread via cfe-commits
Author: wangyihan Date: 2022-03-31T07:38:37+08:00 New Revision: 907d3acefc3bdd6eb83f21589c6473ca7e88b3eb URL: https://github.com/llvm/llvm-project/commit/907d3acefc3bdd6eb83f21589c6473ca7e88b3eb DIFF: https://github.com/llvm/llvm-project/commit/907d3acefc3bdd6eb83f21589c6473ca7e88b3eb.diff LOG

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

2022-03-30 Thread Wang Yihan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG907d3acefc3b: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct… (authored by yihanaa). Repository: rG LLVM Github Mon

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

2022-03-30 Thread Wang Yihan via Phabricator via cfe-commits
yihanaa added a comment. Thank you for the reviews @erichkeane. I've applied for commit access and commit in 907d3acefc3bdd6eb83f21589c6473ca7e88b3eb . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

2022-03-30 Thread Fabio R. Sluzala via Phabricator via cfe-commits
FabioRS updated this revision to Diff 419290. FabioRS marked 14 inline comments as done. FabioRS added a comment. I am not sure about the LangOptions object, the NestedNameSpecifier needs it to correctly print the nested classes-name and not sure about the getEnclosing() too. I can not run the

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

2022-03-30 Thread Fabio R. Sluzala via Phabricator via cfe-commits
FabioRS updated this revision to Diff 419296. FabioRS added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122698/new/ https://reviews.llvm.org/D122698 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/unittests/tweaks

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

2022-03-30 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add (partial) support for Objective-C category records in ExtractAPI. The current ExtractAPI coll

[PATCH] D122774: [clang][extract-api] Add Objective-C Category support

2022-03-30 Thread Zixu Wang via Phabricator via cfe-commits
zixuw updated this revision to Diff 419298. zixuw added a comment. Remove probably unnecessary includes added automatically by clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122774/new/ https://reviews.llvm.org/D122774 Files: clang/includ

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

2022-03-30 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks! I'll look at the changes in the morning, just wanted to mention one thing In D122698#3417946 , @FabioRS wrote: > I can not run the test the consteval, so it is not in the diff. > > TestTU failed to build (suppress wi

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2022-03-30 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
dhruvachak added a comment. As discussed in https://github.com/llvm/llvm-project/issues/54654, this needs to be added for SPMDization with this patch. Not sure whether further handling is required. diff --git a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp index

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

2022-03-30 Thread Fabio R. Sluzala via Phabricator via cfe-commits
FabioRS added a comment. In D122698#3418018 , @sammccall wrote: > Thanks! I'll look at the changes in the morning, just wanted to mention one > thing > > In D122698#3417946 , @FabioRS wrote: > >> I can not run th

[PATCH] D122713: [RISCV] [NFC] Add tests for vector load/store overloaded intrinsics of FP16

2022-03-30 Thread Chenbing.Zheng via Phabricator via cfe-commits
Chenbing.Zheng added a comment. In D122713#3417033 , @craig.topper wrote: > These tests files are already too long and have been timing out in > phabricator. @4vtomat has a patch D122370 > to split them up. OK, I wil

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

2022-03-30 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. In D121445#3416518 , @rengolin wrote: > There is also a test error: > > TEST 'Clang :: Driver/csky-toolchain.c' FAILED > > ... > /home/rengolin/devel/llvm-project/clang/test/Drive

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

2022-03-30 Thread Amit Kumar Pandey via Phabricator via cfe-commits
ampandey-AMD created this revision. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. ampandey-AMD requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay, wdng. Herald added a reviewer: j

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

2022-03-30 Thread Amit Kumar Pandey via Phabricator via cfe-commits
ampandey-AMD updated this revision to Diff 419317. ampandey-AMD added a comment. This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llv

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-30 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 419322. ChuanqiXu added a comment. Herald added a subscriber: dexonsmith. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/include/clang/Basic/Module.h clang/lib/Serialization/ASTW

[PATCH] D122781: This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain.

2022-03-30 Thread Amit Kumar Pandey via Phabricator via cfe-commits
ampandey-AMD updated this revision to Diff 419323. ampandey-AMD added a comment. This patch aims to conform AMDGPUOpenMP driver sanitizer changes w.r.t HIPAMD toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122781/new/ https://reviews.llv

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-30 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 419324. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/search-partitions.cpp Index: clang/test/Modules/se

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

2022-03-30 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 419325. ChuanqiXu added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 Files: clang/include/clang/Basic/Module.h clang/lib/Serialization/ASTWriterDecl.cpp clang/test/CodeGenCXX/p

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-30 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee572129ae15: [C++20] [Modules] Use '-' as the separator of partitions when searching (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] ee57212 - [C++20] [Modules] Use '-' as the separator of partitions when searching

2022-03-30 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-03-31T11:21:58+08:00 New Revision: ee572129ae15bc15e34fcae63643d6998352dab3 URL: https://github.com/llvm/llvm-project/commit/ee572129ae15bc15e34fcae63643d6998352dab3 DIFF: https://github.com/llvm/llvm-project/commit/ee572129ae15bc15e34fcae63643d6998352dab3.diff LO

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

2022-03-30 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: clang/test/Frontend/stack-usage-safestack.c:1 +/// Check that stack frame size warnings behave the same when safe stack is enabled + I think this should be a bitcode-level test à la test/CodeGen/X86/warn-stack

[clang] 85bd90c - [Driver] Move legacy -f[no-]unit-at-a-time to clang_ignored_gcc_optimization_f_Group

2022-03-30 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-03-30T23:20:49-07:00 New Revision: 85bd90cb71843d022f2c8413ee23683fe8e71241 URL: https://github.com/llvm/llvm-project/commit/85bd90cb71843d022f2c8413ee23683fe8e71241 DIFF: https://github.com/llvm/llvm-project/commit/85bd90cb71843d022f2c8413ee23683fe8e71241.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

2022-03-30 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Friendly ping for review. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

<    1   2