aaron.ballman added a comment. In D122627#3417495 <https://reviews.llvm.org/D122627#3417495>, @beanz wrote:
> @aaron.ballman I pushed updates in rGff6696c842ba > <https://reviews.llvm.org/rGff6696c842bac0b15fc04015b25ead721768eac9>. > > The one bit we discussed that I didn't do anything for is the template case. > Neither clang or the HLSL compiler support parsing Microsoft attributes on > templates right now, so the parser falls over and errors. It would be better > to have a nicer diagnostic, but since the current state matches our compiler > I left it as-is. That sounds reasonable to me. > Thank you! Thanks for the post-commit changes! One question on them: def GlobalFunction : SubsetSubject<Function, [{S->isGlobal()}], "global functions">; Are you sure that's what you want? This returns true for a static C++ member function, false for a static free function, and false for within an unnamed namespace, and true otherwise. Also, I didn't see any new test coverage for function merging behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122627/new/ https://reviews.llvm.org/D122627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
