sammccall added a comment. Thanks! I'll look at the changes in the morning, just wanted to mention one thing
In D122698#3417946 <https://reviews.llvm.org/D122698#3417946>, @FabioRS wrote: > I can not run the test the consteval, so it is not in the diff. > > TestTU failed to build (suppress with /*error-ok*/): > [1:4-1:13] unknown type name 'consteval'; did you mean 'constexpr'?, fixes: > {change 'consteval' to 'constexpr' {1:4-1:13 => "constexpr"}} It's a c++20 feature, so you'll need to add something like `ExtraArgs.push_back("-std=c++20");`. Though if there's no real difference between handling constexpr vs consteval, up to you whether it's worth a separate test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122698/new/ https://reviews.llvm.org/D122698 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
