aaron.ballman added a comment. In D120949#3417545 <https://reviews.llvm.org/D120949#3417545>, @ajohnson-uoregon wrote:
> Okay, I put the assert back in and made a thing similar to HasSizeMatcher > that works and all the tests pass. > > What do you mean by a release note, in the commit message, in the docs...? https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst has a section for AST Matchers, so you should add the notes there. Otherwise, the changes here all LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
