[clang] ef865d1 - [clang] AddObjCKeyValueCompletions - use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-03-17T16:16:01Z New Revision: ef865d16ec3b8ce636786ed472ac28c977f2f304 URL: https://github.com/llvm/llvm-project/commit/ef865d16ec3b8ce636786ed472ac28c977f2f304 DIFF: https://github.com/llvm/llvm-project/commit/ef865d16ec3b8ce636786ed472ac28c977f2f304.diff LOG:

[PATCH] D121829: [clang][AArc64][SVE] Implement vector-scalar operators

DavidTruby planned changes to this revision. DavidTruby added a comment. When updating the float tests it seems this is causing some issues with fp16 support, which I am investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121829/new/ http

[PATCH] D121792: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e08bc7c1e5: [AArch64][SVE] InstCombine llvm.aarch64.sve.sel to select (authored by MattDevereau). Changed prior to commit: https://reviews.llvm.

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

owenpan added a comment. In D121757#3389092 , @sstwcw wrote: > This patch is only intended to reduce the number of times the functionality > gets implemented separately. Any change in behavior would be unintended. > And we also use the `parseIndentedB

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. In D119479#3388498 , @uabelho wrote: > Hello, > > Did you see this sanitizer error when running global_record.c? > > https://lab.llvm.org/buildbot/#/builders/5/builds/20765/steps/13/logs/stdio Hi! Taking a look right now Reposito

[PATCH] D121915: [RISCV] CLZ Instruction

craig.topper added a comment. Rethinking that. Since __builtin_clz is undefined for 0, I think we should have clang builtins, but we should use llvm.ctlz with false for the second argument as their implementation. See X86::BI__builtin_ia32_lzcnt_u32 for example. Repository: rG LLVM Github Mo

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert updated this revision to Diff 416218. jdoerfert added a comment. Fix AS(0) -> AS(0) cast error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cl

[clang-tools-extra] 8522a01 - Attempt forward fix for Linux buildbots for D116385

Author: David Goldman Date: 2022-03-17T12:49:16-04:00 New Revision: 8522a01e842e6791545864f2d255dc48190a7e34 URL: https://github.com/llvm/llvm-project/commit/8522a01e842e6791545864f2d255dc48190a7e34 DIFF: https://github.com/llvm/llvm-project/commit/8522a01e842e6791545864f2d255dc48190a7e34.diff

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 ___ cfe-commits mailing list cf

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

ronlieb added a comment. i applied it locally and ran bot equiv, looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D121837 ___ cfe-commits mailing list c

[PATCH] D121863: [clang][dataflow] Model the behavior of non-standard optional assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb000b7705ad8: [clang][dataflow] Model the behavior of non-standard optional assignment (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[clang] b000b77 - [clang][dataflow] Model the behavior of non-standard optional assignment

Author: Stanislav Gatev Date: 2022-03-17T17:11:12Z New Revision: b000b7705ad86ff19bea950c913a2416247317d5 URL: https://github.com/llvm/llvm-project/commit/b000b7705ad86ff19bea950c913a2416247317d5 DIFF: https://github.com/llvm/llvm-project/commit/b000b7705ad86ff19bea950c913a2416247317d5.diff LO

[clang] 7e80976 - [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

Author: Yuanfang Chen Date: 2022-03-17T10:12:38-07:00 New Revision: 7e80976fdf3f0af87780f6490f39a1d500fc9886 URL: https://github.com/llvm/llvm-project/commit/7e80976fdf3f0af87780f6490f39a1d500fc9886 DIFF: https://github.com/llvm/llvm-project/commit/7e80976fdf3f0af87780f6490f39a1d500fc9886.diff

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e80976fdf3f: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 54b145d - [NFC] Disable clang/SymbolGraph test

Author: Zixu Wang Date: 2022-03-17T10:14:19-07:00 New Revision: 54b145d5cac2b008380828e8f67c439038ea370b URL: https://github.com/llvm/llvm-project/commit/54b145d5cac2b008380828e8f67c439038ea370b DIFF: https://github.com/llvm/llvm-project/commit/54b145d5cac2b008380828e8f67c439038ea370b.diff LOG

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. In D119479#3388498 , @uabelho wrote: > Hello, > > Did you see this sanitizer error when running global_record.c? > > https://lab.llvm.org/buildbot/#/builders/5/builds/20765/steps/13/logs/stdio Hi @uabelho, I've disabled the test fo

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

owenpan added subscribers: HazardyKnusperkeks, krasimir, MyDeveloperDay, curdeius, owenpan. owenpan added a comment. Please add @krasimir @MyDeveloperDay @curdeius @HazardyKnusperkeks to Reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1219

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: jamieschmeiser, aaron.ballman, chandlerc, cebowleratibm, w2yehia. Herald added a project: All. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. Update `WeakUndeclaredIdent

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. In D119792#3389126 , @erichkeane wrote: > So P2025 has not successfully made it > through EWG, so this would have to be under a 'flag'. Also, I believe this > will end up being applied to C++23,

[PATCH] D121907: [clang-format] Use an enum for context types.

owenpan added subscribers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. owenpan added a comment. If this patch is an NFC, please add `[NFC]` to the title. Please add @MyDeveloperDay @curdeius @HazardyKnusperkeks to Reviewers. Comment at: clang/lib/Format/TokenAnnota

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

owenpan added a subscriber: krasimir. owenpan added a comment. In D121890#3389171 , @sstwcw wrote: > The issue is #54418. > > Actually I don't know who I should add as reviewers. The patches for > clang-format don't always seem to have the same reviewer

[clang] 22570ba - Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Author: Julian Lettner Date: 2022-03-17T10:47:13-07:00 New Revision: 22570bac694396514fff18dec926558951643fa6 URL: https://github.com/llvm/llvm-project/commit/22570bac694396514fff18dec926558951643fa6 DIFF: https://github.com/llvm/llvm-project/commit/22570bac694396514fff18dec926558951643fa6.diff

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22570bac6943: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f02550b - Reapply "[OpenMP][FIX] Allow device constructors for AMD GPU"

Author: Johannes Doerfert Date: 2022-03-17T12:53:47-05:00 New Revision: f02550bdd9b7e4b442009edc02f9e3f78400ae30 URL: https://github.com/llvm/llvm-project/commit/f02550bdd9b7e4b442009edc02f9e3f78400ae30 DIFF: https://github.com/llvm/llvm-project/commit/f02550bdd9b7e4b442009edc02f9e3f78400ae30.d

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf02550bdd9b7: Reapply "[OpenMP][FIX] Allow device constructors for AMD GPU" (authored by jdoerfert). Changed prior to commit: https://reviews.llvm

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 416255. ppluzhnikov added a comment. Herald added a project: clang-tools-extra. Fix Win x64 failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 Files: cla

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang created this revision. dang added reviewers: ributzka, zixuw, QuietMisdreavus, arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang -extract-api should accept multiple headers and forward th

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416261. dang added a comment. Get rid of spurious clang-format changes due to reverted modifications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files: clang/inclu

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

ributzka added inline comments. Comment at: clang/include/clang/Driver/Phases.h:17 /// compilation process which interact with user options. - enum ID { -Preprocess, Is this an unrelated formatting change? Comment at: clang/lib/Driver/P

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

ributzka added a comment. Nice! Thank you for adding support for multiple headers. Is this a step towards the json input file list? Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:467 +def err_drv_extract_api_wrong_kind : Error< + "header file '%0' input '%1'

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

tra added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:105-107 +constexpr CudaArch DefaultCudaArch = CudaArch::SM_35; +constexpr CudaArch DefaultHIPArch = CudaArch::GFX803; + Nit: those could be just enum values. ``` ... LAST, DefaultCudaAr

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/71358/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121837/new/ https://reviews.llvm.org/D1

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/lib/SymbolGraph/ExtractAPIConsumer.cpp:197 + void recordEnumConstants(EnumRecord *EnumRecord, + const EnumDecl::enumerator_range Constants) { Should this be static or in an anonymous names

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf0d1932a3c: Currently the control of the eval-method is mixed with fast-math. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/

[clang] bbf0d19 - Currently the control of the eval-method is mixed with fast-math.

Author: Zahira Ammarguellat Date: 2022-03-17T11:48:03-07:00 New Revision: bbf0d1932a3c1be970ed8a580e51edf571b80fd5 URL: https://github.com/llvm/llvm-project/commit/bbf0d1932a3c1be970ed8a580e51edf571b80fd5 DIFF: https://github.com/llvm/llvm-project/commit/bbf0d1932a3c1be970ed8a580e51edf571b80fd5

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. If people thing it would be preferable to add a new phase and change phase scheduling a little I am happy to do that too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 ___

[clang] 052a6c7 - [OpenMP][FIX] Relax test check lines

Author: Johannes Doerfert Date: 2022-03-17T14:01:47-05:00 New Revision: 052a6c744af542bfd9d7faad5de72caf9f3eb6a7 URL: https://github.com/llvm/llvm-project/commit/052a6c744af542bfd9d7faad5de72caf9f3eb6a7 DIFF: https://github.com/llvm/llvm-project/commit/052a6c744af542bfd9d7faad5de72caf9f3eb6a7.d

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. I think I've got all the changes incorporated, but I'm getting a test failure so I haven't uploaded a new diff. Honestly, I don't understand the test failure output. On Windows, the test failure output is all mangled and difficult to interpret correctly as to

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert added a comment. In D121837#3390042 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/71358/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I relaxed the check line. Should resolve the pr

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 416279. egorzhdan added a comment. - Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule (`SubjectMatchRule_variable_not_is_parameter`) was not handled properly - Add a test for this Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. Herald added a project: All. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:105-107 +constexpr CudaArch DefaultCudaArch = CudaArch::SM_35; +constexpr CudaArch DefaultHIPArch = CudaArch::GFX803; + tra wrote: > Nit: those could be just enum values. > ``` > ... >

[PATCH] D121890: [clang-format] Copy help options to the doc directory.

MyDeveloperDay added a comment. In D121890#3389171 , @sstwcw wrote: > The issue is #54418. > > Actually I don't know who I should add as reviewers. The patches for > clang-format don't always seem to have the same reviewers. Who are the main > develop

[PATCH] D121907: [clang-format] Use an enum for context types.

MyDeveloperDay added a comment. So out of interest, what is the reason? my assumption is that you wanted to add more for Verilog and you felt adding the extra bools was the wrong design and its better an an enum bool InCpp11AttributeSpecifier = false; bool InCSharpAttributeSpecifier = false

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2138 + +// These keywords are deliberately not included here. They are either +// included in determineStarAmpUsage or determinePlusMinusCaretUsage. I'm not sure abo

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 416292. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h clang/include/clang/D

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

MyDeveloperDay added a subscriber: Eugene.Zelenko. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:361 - * ``bool AlignCompound`` Only for ``AlignConsecutiveAssignments``. Whether compound -assignments like ``+=`` are aligned alon

[clang] b4cc3b1 - [OpenMP][FIX] Make metadata and attribute check lines less detailed

Author: Johannes Doerfert Date: 2022-03-17T14:58:22-05:00 New Revision: b4cc3b1dd8d7200640210513263b28187f810703 URL: https://github.com/llvm/llvm-project/commit/b4cc3b1dd8d7200640210513263b28187f810703 DIFF: https://github.com/llvm/llvm-project/commit/b4cc3b1dd8d7200640210513263b28187f810703.d

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:992-999 + enum { +ATTR_JS_KEYWORD = 0x1, +ATTR_CSHARP_KEYWORD = 0x2, + }; + unsigned getAttrs(const FormatToken &Tok) const { +auto At = KeywordAttr.find(Tok.Tok.getIdentifierInfo(

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1431-1442 +TT_AttributeMacro, TT_BracedListLBrace, TT_ClassLBrace, +TT_Com

[PATCH] D121907: [clang-format] Use an enum for context types.

HazardyKnusperkeks added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the wrong design > and its bett

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

HazardyKnusperkeks added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:105 +SortIncludes("sort-includes", + cl::desc("If set, overrides the include sorting behavior\n" + "determined by the SortIncludes style fla

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. Let me explain a bit more =) The optimizations from this patch are allowed by the Standard (always have been allowed). So there is no need to restrict it under a flag or C++ version. @erichkeane your comment indeed would be applicable if I allowed NRVO for non-movable t

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder created this revision. Herald added subscribers: foad, kerbowa, hiraditya, t-tye, Anastasia, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. scott.linder requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, w

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added reviewers: sameerds, arsenm, rampitec, b-sumner, kzhuravl, yaxunl. scott.linder added a comment. For reference, the error I'm changing to a warning was added as part of https://reviews.llvm.org/D70038, and the issue that made me consider this approach appears when building OC

[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd5895cc3986: AMDGPU: Use the implicit kernargs for code object version 5 (authored by cfang). Herald added a project: clang. Herald added a subscrib

[clang] dd5895c - AMDGPU: Use the implicit kernargs for code object version 5

Author: Changpeng Fang Date: 2022-03-17T14:12:36-07:00 New Revision: dd5895cc39864393f8ca357bc4e23e8d7b5b9723 URL: https://github.com/llvm/llvm-project/commit/dd5895cc39864393f8ca357bc4e23e8d7b5b9723 DIFF: https://github.com/llvm/llvm-project/commit/dd5895cc39864393f8ca357bc4e23e8d7b5b9723.diff

[PATCH] D120857: WIP [randstruct] Add randomize structure layout support

void abandoned this revision. void added a comment. In D120857#3389022 , @aaron.ballman wrote: > This seems like a duplicate of https://reviews.llvm.org/D121556 -- should > this review be abandoned? Yes. Thanks :-) Repository: rG LLVM Github Monore

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:567 - if (auto HostcallFunction = M.getFunction("__ockl_hostcall_internal")) { + if (auto *HostcallFunction = M.getFunction("__ockl_hostcall_internal")) { for (auto &U :

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. A spurious warning still isn't ideal but this is an improvement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.o

[PATCH] D121954: [clang] Add test cases for multiversion function overload scenarios in C.

tahonermann created this revision. Herald added a project: All. tahonermann added reviewers: erichkeane, aaron.ballman. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D121955: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction().

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 416330. ppluzhnikov added a comment. Use single quotes in sed -- don't want shell expansion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 Files: clang-

[PATCH] D121957: [clang] NFC: Redundant code removal in SemaDecl.cpp, CheckTargetCausesMultiVersioning().

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commen

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Checking of multiversion function declarations performed by

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains updated this revision to Diff 416332. iains added a comment. adress review comments, adjust test case for windows compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121588/new/ https://reviews.llvm.org/D121588 Files: clang/includ

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. tahonermann added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change resolves both LLVM

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds a "multiversion" annotation to textual AST

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tahonermann published this revision for review. tahonermann added inline comments. Herald added a reviewer: jdoerfert. Herald added sub

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tahonermann published this revision for review. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. He

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Just some minor cleanup before submitting as noted below. Comment at: clang/test/Profile/misexpect-branch.c:3 + +// test likely branch +// RUN: llvm-profdata merg

[PATCH] D121965: Add validation for number of arguments of __builtin_memcpy_inline

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. __builtin_memcpy_inline doesn't use the usual builtin argument validation code, so it crashed when receiving wrong n

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

xbolva00 added a comment. Add Clang release note as well please. Comment at: clang/docs/MisExpect.rst:58 + Relaxes misexpect checking to tolerate profiling values within N% of the + expected branch weight. e.g., a vlaue of ``N=5`` allows misexpect to check against + ``0

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121962/new/ https://reviews.llvm.org/D121962 ___

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121963/new/ https://reviews.llvm.org/D121963 ___

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 416347. Izaron marked 7 inline comments as done. Izaron added a comment. Herald added a project: All. Fix issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 Files:

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.cpp:64-68 + unless(hasType(isVolatileQualified())), // non-volatile + unless(isTemplateVariable()), // non-template

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd created this revision. Herald added a subscriber: inglorion. Herald added a project: All. junfd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121969 Files: clang/li

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. In D118743#3290591 , @LegalizeAdulthood wrote: > You've probably had this check in development for some time, but > we just updated the documentation for contributing to clang-tidy > and it might help to go over it for your new ch

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. @hubert.reinterpretcast I added the tests, please let me know what you think. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 ___

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. In D121736#3389251 , @RKSimon wrote: > LGTM - but please hang around after you commit Thanks! Looks like this it worked out. Let me know if there is any other problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D121556: [randstruct] Add randomize structure layout support

void marked 7 inline comments as done. void added inline comments. Comment at: clang/include/clang/AST/Decl.h:4067 + + void setIsRandomized(bool V) const { RecordDeclBits.IsRandomized = V; } + aaron.ballman wrote: > A setter that is marked `const` does not spark

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 416354. void marked 3 inline comments as done. void added a comment. General cleanup of code. Removing unneeded headers and comments. Removing a "const" from a setter. Not defining this for MS's declspecs or making the attributes keywords. Repository: rG LL

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added inline comments. Comment at: clang/include/clang/Driver/Phases.h:17 /// compilation process which interact with user options. - enum ID { -Preprocess, ributzka wrote: > Is this an unrelated formatting change? Fixed it in the latest diff. I had

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3389991 , @ributzka wrote: > Nice! Thank you for adding support for multiple headers. Is this a step > towards the json input file list? My understanding was that for this iteration at least we were going with just feed

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 416356. paulkirth marked 4 inline comments as done. paulkirth added a comment. Fixup remaining outstanding issues - fix typos - add misexpect to clang release notes - restore new pm style opt invocations in llvm tests - move single header function into impl

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth marked 5 inline comments as done. paulkirth added inline comments. Comment at: llvm/docs/MisExpect.rst:54 + +.. option:: -pgo-warn-misexpect + tejohnson wrote: > paulkirth wrote: > > tejohnson wrote: > > > Looking at the code, the -pgo-warn-misexpect se

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416359. dang added a comment. Add test to check that command line with different header kinds gets diagnosed appropriately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D12193

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

vsapsai added a comment. Thanks for explaining the desired interplay between PCH and PCM. The problem I'm seeing is that it can be hard to find correct compiler flags to achieve the desired result (what is enabled and what is disabled). But that is out of scope for this change. =

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7749d4713a5: [misexpect] Re-implement MisExpect Diagnostics (authored by paulkirth). Changed prior to commit: https://reviews.llvm.org/D115907?vs

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw added inline comments. Comment at: clang/lib/SymbolGraph/Serialization.cpp:321 + case RelationshipKind::MemberOf: +Relationship["kind"] = "memberOf"; +break; dang wrote: > Since we are going to add more cases to this switch, would you mind doing >

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

zixuw added a comment. In D121936#3390920 , @dang wrote: > In D121936#3389991 , @ributzka > wrote: > >> Nice! Thank you for adding support for multiple headers. Is this a step >> towards the json input file list

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/71396/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. These pass for me locally, so I'm reverting for now and will dig into this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3391001 , @zixuw wrote: > In D121936#3390920 , @dang wrote: > >> In D121936#3389991 , @ributzka >> wrote: >> >>> Nice! Thank you for addi

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 416363. junfd added a comment. Follow clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Dri

[clang] 5d2ce76 - Use llvm::append_range instead of push_back loops where applicable. NFCI.

Author: Benjamin Kramer Date: 2022-03-18T01:25:34+01:00 New Revision: 5d2ce7663b10c107328a4ae0c678165209e64619 URL: https://github.com/llvm/llvm-project/commit/5d2ce7663b10c107328a4ae0c678165209e64619 DIFF: https://github.com/llvm/llvm-project/commit/5d2ce7663b10c107328a4ae0c678165209e64619.dif

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

arphaman added a comment. I see, thanks! Let me think a bit more about this change and test it on our codebase to see if this is a viable Sema change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121748/new/ https://reviews.llvm.org/D121748

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains updated this revision to Diff 416364. iains added a comment. adjust testcase path separators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121588/new/ https://reviews.llvm.org/D121588 Files: clang/include/clang/Driver/Types.def clang/lib

<    1   2   3   >