MyDeveloperDay added a comment.

In D121890#3389171 <https://reviews.llvm.org/D121890#3389171>, @sstwcw wrote:

> The issue is #54418.
>
> Actually I don't know who I should add as reviewers.  The patches for 
> clang-format don't always seem to have the same reviewers.  Who are the main 
> developers and how do you decide who you add each time?
>
> I give up making the doc generated.  It would require either integrating into 
> the build process or writing a parser script like for the style options.  
> Besides, that file is not entirely generated.

ok neither is ClangFormatStyleOptions.rts, but also the 
doc/tools/dump_format_style.py is also something thats not part of the build, 
but just a tool we can run to ensure the Format.h and 
ClangFormatStryleOptions.rst stay in lock step.

So actually I think that's a good task for someone to do, but its not necessary 
to do it here, but actually I think I'd prefer to see that than having to keep 
this the same by hand. I clearly missed that step. (so I appreciate you adding 
it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121890/new/

https://reviews.llvm.org/D121890

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to