[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

wenlei updated this revision to Diff 414606. wenlei added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D120610 Files: llvm/lib/CodeGen/AsmPrinter/DIE.cpp llvm/test/DebugInfo/X86

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

wenlei added a comment. In D120610#3373042 , @dblaikie wrote: > Fixes in LLVM require tests in LLVM - probably taking the clang test and > compiling that to llvm IR (include the original C++ source in a comment in > the IR test case) and then testing it

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

pengfei added a comment. Typos in `wiht different feature lists` and `In the even that`. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2067 + // favor this processor. + TuneCPU = SD->getCPUName(GD.getMultiVersionIndex())->getName(); +} erichkean

[PATCH] D121450: [clang-format] Handle attributes before case label.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[clang] 788e0f7 - [clang-repl] Add an accessor to our underlying execution engine

Author: Vassil Vassilev Date: 2022-03-11T09:24:47Z New Revision: 788e0f7f3e96a9d61c2412e452c4589e2693b79a URL: https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a DIFF: https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a.diff LO

[PATCH] D120465: [clang][deps] Disable implicit module maps

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273 + // However, some module maps loaded implicitly during the dependency scan can + // describe anti-dependencies. That happens when the current module is marked +

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/3

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. I'm not sure whether we should consider this a breaking change, there were no tests at all verifying this behaviour. I think that not adding a space in comments starting with a punctuation is a mistake unless for some special comments like `///`, `//!` etc. (which are

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

rengolin added a comment. I don't know enough about your toolchain requirements, but this looks good to me. Please check the clang-format warnings. If you did pass clang-format, perhaps you need to upgrade to a newer one? I won't approve just yet, to let other people review it also. ===

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

ftynse accepted this revision. ftynse added a comment. Thanks! Let me know if you need help landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cf

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 414614. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:622 +if (InTy->isIntegerType() || InTy->isPointerType() || +InTy->isStructureType() || InTy->isConstantArrayType()) InputDomain = AD_Int; jyu2 wrote: > Are you sure you w

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:27 -static std::string getPackageFullName(const Record *R); +static std::string getPackageFullName(c

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + Any need to handle when ABI is not avbiv2

[clang] 6c5da88 - [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

Author: Matt Devereau Date: 2022-03-11T11:19:53Z New Revision: 6c5da880e03cafc49008612eb687910f3f805057 URL: https://github.com/llvm/llvm-project/commit/6c5da880e03cafc49008612eb687910f3f805057 DIFF: https://github.com/llvm/llvm-project/commit/6c5da880e03cafc49008612eb687910f3f805057.diff LOG:

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c5da880e03c: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters (authored by MattDevereau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow ana

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { zahiraam wrote: > aaron.ballman wrote: > > What should happen in a case like this? > > ``` > > int whatever(float

[clang] b44eb20 - [clang-format] Refactor condition in AnnotatingParser::modifyContext(). NFC.

Author: Marek Kurdej Date: 2022-03-11T13:12:43+01:00 New Revision: b44eb207e96a5e20aecbb6084147ae97e3eabd22 URL: https://github.com/llvm/llvm-project/commit/b44eb207e96a5e20aecbb6084147ae97e3eabd22 DIFF: https://github.com/llvm/llvm-project/commit/b44eb207e96a5e20aecbb6084147ae97e3eabd22.diff

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

aaron.ballman added a reviewer: arsenm. aaron.ballman added a subscriber: arsenm. aaron.ballman added a comment. Herald added a subscriber: wdng. Adding @arsenm because of this bit: > Note that the 'valid' list of processors for x86 is in > llvm/include/llvm/Support/X86TargetParser.def. At the m

[PATCH] D121456: [clang-format] Correctly format variable templates.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan, cjdb. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/is

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

stuij updated this revision to Diff 414635. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121206/new/ https://reviews.llvm.org/D121206 Files: clang/test/Driver/aarch64-ssbs.c clang/test/Preproce

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:288 // CHECK-MCPU-CORTEX-A73: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+fp-armv8" "-target-feature" "+ne

[PATCH] D121457: Clamp negative coverage counters to zero.

Hiralo created this revision. Hiralo added a reviewer: vsk. Hiralo added projects: clang, LLVM. Herald added subscribers: dexonsmith, wenlei, dang, kbarton, nemanjai. Herald added a project: All. Hiralo requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. commit

[PATCH] D121457: Clamp negative coverage counters to zero.

lebedev.ri added a comment. Wouldn't it be best to instead fix the non-thread-safety of the coverage counters? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121457/new/ https://reviews.llvm.org/D121457

[PATCH] D121457: Clamp negative coverage counters to zero.

Hiralo added a comment. In D121457#3375039 , @lebedev.ri wrote: > Wouldn't it be best to instead fix the non-thread-safety of the coverage > counters? Can you please elaborate or point me to code? Thanks Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121459: [analyzer] Remove HasAlphaDocumentation tablegen enum value

steakhal created this revision. steakhal added reviewers: aaron.ballman, NoQ, Szelethus, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane added a comment. Thanks all! I'll do some work on populating a list of 'converted names', but I'll definitely need @pengfei and @andrew.w.kaylor help checking the list/filling in what I miss. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.or

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske updated this revision to Diff 414642. balazske added a comment. Added unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120824/new/ https://reviews.llvm.org/D120824 Files: clang/lib/AST/ASTImporter.cpp clang/test/Analysis/Inpu

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske added a comment. The last unit test is not much different from the lit test, I could not find more simple code to get the wanted result. Is it still good to have the lit test too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120824/new/

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski updated this revision to Diff 414648. awarzynski added a comment. Fix option spelling in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane updated this revision to Diff 414650. erichkeane added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. add a 'translation' feature to the x86 target so that we can get the 'tune cpu' name from the list. Note that there are 9 with blanks that I was una

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:230 +CPU_SPECIFIC("pentium_m", "pentium-m", 'K', "+cmov,+mmx,+sse,+sse2") +CPU_SPECIFIC("pentium_4_sse3", "", 'L', "+cmov,+mmx,+sse,+sse2,+sse3") +CPU_SPECIFIC("core_2_duo_ssse3", "", 'M',

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman added a comment. Oh wow, GCC has supported this for a long time; I wasn't aware of that. Thanks for this patch! Comment at: clang/lib/Parse/ParseDeclCXX.cpp:79 + + auto ReadLabelAttrubutes = [&] { +// Read label attributes, if present. Howev

[clang] 3aca0ff - [clang][SVE] Add support for arithmetic operators on SVE types

Author: David Truby Date: 2022-03-11T15:39:44Z New Revision: 3aca0ffd5092e37590bbee7e0fcd2b1b5780024c URL: https://github.com/llvm/llvm-project/commit/3aca0ffd5092e37590bbee7e0fcd2b1b5780024c DIFF: https://github.com/llvm/llvm-project/commit/3aca0ffd5092e37590bbee7e0fcd2b1b5780024c.diff LOG: [

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

This revision was automatically updated to reflect the committed changes. Closed by commit rG3aca0ffd5092: [clang][SVE] Add support for arithmetic operators on SVE types (authored by DavidTruby). Changed prior to commit: https://reviews.llvm.org/D120323?vs=413470&id=414656#toc Repository: rG

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

MyDeveloperDay added a comment. Is this conforming to `SpacesInLineCommentPrefix` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/ https://reviews.llvm.org/D121451 ___ cfe-commits mailing list c

[PATCH] D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When finalizing the result of name lookup that encountered ambig

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tianshilei1992, jdoerfert, ggeorgakoudis. Herald added subscribers: asavonic, dang, guansong, yaxunl, mgorny. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sste

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tianshilei1992, jdoerfert, ggeorgakoudis. Herald added subscribers: asavonic, dang, kerbowa, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-com

[clang] 058c92f - [clang][SVE] Add aarch64-registered-target to sve vector op tests

Author: David Truby Date: 2022-03-11T16:01:00Z New Revision: 058c92f2a4e865d478b29035c207ec0744229d6a URL: https://github.com/llvm/llvm-project/commit/058c92f2a4e865d478b29035c207ec0744229d6a DIFF: https://github.com/llvm/llvm-project/commit/058c92f2a4e865d478b29035c207ec0744229d6a.diff LOG: [

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

erichkeane added a comment. Just a couple of questions/comments. Otherwise this seems pretty ok. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:745 - ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, &endLoc, + ParseGNUAttributeArgs(&LA.AttrName, LA

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

erichkeane added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:920 void clearListOnly() { AttrList.clear(); } Also, this function is now strange/likely needs a rename, since it likely needs to reset the range as well. I believe the p

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. > I wasn't 100% whether to add the range to ParsedAttributes or even > ParsedAttributesView. I think `ParsedAttributesView` is the correct level for this -- I want to see us tracking the source range for all the parsed a

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:1105 void clearListOnly() { ParsedAttributesView::clearListOnly(); Range = SourceRange(); erichkeane wrote: > This is... oh boy. I'm hopeful you can remove this t

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius updated this revision to Diff 414669. curdeius added a comment. Add tests for SpacesInLineCommentPrefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121451/new/ https://reviews.llvm.org/D121451 Files: clang/lib/Format/BreakableToken.c

[PATCH] D121451: [clang-format] Add space to comments starting with '#'.

curdeius added a comment. In D121451#3375229 , @MyDeveloperDay wrote: > Is this conforming to `SpacesInLineCommentPrefix` Yes it is, nothing changed in this regard, I added tests anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM. Support the header file is actually generated automatically. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121466/new/

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. Herald added a project: All. In D111400#985 , @cor3ntin wrote: > @hubert.reinterpretcast Gentle ping in case you didn't see Aaron's message - > there isn't too much urgency though Another ping on this since a few weeks

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

JonChesterfield added a comment. We've got quite a lot of debt in this area and seem at risk of taking on more. Ideally the cuda and hip and openmp headers would be closer to a single header containing: double acosh(double); INSTANTIATE(acosh, cuda_acosh, amdgpu_acosh, intel_acosh);

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(&SubExpr); +if (auto *Val = dyn_cast_or_null( Could you elaborate on when would this happen? I'd expect the traversal to always

[clang] aa4ea0e - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple

Author: Akira Hatanaka Date: 2022-03-11T09:30:31-08:00 New Revision: aa4ea0ee54411d12d17dd6261f64726913f15e16 URL: https://github.com/llvm/llvm-project/commit/aa4ea0ee54411d12d17dd6261f64726913f15e16 DIFF: https://github.com/llvm/llvm-project/commit/aa4ea0ee54411d12d17dd6261f64726913f15e16.diff

[PATCH] D121135: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple more files

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4ea0ee5441: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTContext &Context, SourceLocation loc) {} + + QualType getInnerType() const { return getTypePtr()->getWrappedType(); } Do we also need something like

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

egorzhdan created this revision. egorzhdan added a reviewer: gchatelet. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change teaches the Sema logic for `__builtin_memcpy_inline` to implicitly c

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a day or two before landing in case @njames93 has further concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

jdoerfert added a comment. We want one copy of this, yes. s/omp/llvm_gpu/, sure, though gpu might also not the best name. Generators, macros, etc. I'm not sold. Even if we want to do this, let's not conflate that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

jdoerfert added inline comments. Comment at: clang/include/clang/Driver/Options.td:1056 +def libomptarget_nvptx_math_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-math-bc-path=">, + Group, HelpText<"Path to libomptarget-nvptx math bitcode library">; def dD : Flag<["-"], "dD"

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:1056 +def libomptarget_nvptx_math_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-math-bc-path=">, + Group, HelpText<"Path to libomptarget-nvptx math bitcode library">; def dD : Flag<["-"]

[PATCH] D121468: [OpenMP] Add linking of OpenMP math library

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1056 +def libomptarget_nvptx_math_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-math-bc-path=">, + Group, HelpText<"Path to libomptarget-nvptx math bitcode library">; def dD : Flag<["-"], "dD">,

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. In D88905#3362347 , @kaz7 wrote: > At the beginning, this implementation extends `vector_type` attribute which > is GCC's attribute. So, this may cause future conflicts with GCC when they > extend it. But, now this patch

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane updated this revision to Diff 414699. erichkeane added a comment. Corrected the last few processor names thanks to @andrew.w.kaylor and @pengfei CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410 Files: clang/include/clang/Basic/Tar

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:236 +CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") +CPU_SPECIFIC("core_aes_pclmulqdq", "icelake-client", 'Q', "+cmov,+mmx

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane updated this revision to Diff 414709. erichkeane added a comment. Update the `core_aes_pclmulqdq` to be `westmere` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Tar

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane marked 4 inline comments as done. erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:236 +CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") +CPU_SPECIFIC("core_aes_pclm

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I'm not qualified to review the CPU specific bits in the .def file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410 _

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3373560 , @aaron.ballman wrote: > why do we support multiple attribute *specifiers* in the same pragma? I would > not expect to be able to mix attribute styles in the same pragma given that > all of the individual

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham updated this revision to Diff 414718. bnbarham added a comment. Handle empty overlay file in clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426 Files: clang-tools-extra/clang-tidy/tool/

[PATCH] D121373: [clang-tidy][docs] Fix wrong url in DontModifyStdNamespaceCheck

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121373/new/ https://reviews.llvm.org/D121373

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai updated this revision to Diff 414724. vsapsai added a comment. Fix clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 Files: clang/include/clang/Testing/CommandLineArgs.h clan

[PATCH] D120465: [clang][deps] Disable implicit module maps

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with a suggested change for the text of the comment. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:269-273 + // However, some module

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121372/new/ https://reviews.llvm.org/D121372

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414729. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

chhzh123 added a comment. @ftynse Thanks for reviewing! Could you help land the PR? Seems I do not have access rights to push to the main repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 _

[PATCH] D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I think this is a good incremental improvement until the check covers more of MEM51-CPP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121214/new/ https://reviews

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

dblaikie added a comment. It'd be good to include some testing beyond "does not crash" - like what was the specific debug info we were trying to create when the crash was hit? Perhaps we should be testing that (since the crash demonstrates we weren't testing that anywhere else) Repository:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

aaron.ballman added a comment. In D117522#3364387 , @LegalizeAdulthood wrote: > Ping. Another week waiting for reviews... Thanks for the ping! FWIW, it's also not uncommon for there to be week delays (reviewers go on vacation, have other obligations,

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added a comment. It looks like there are some clang-format issues to handle as well. Comment at: clang/test/CodeGen/eval-method-fast-math.c:113-116 +#pragma float_control(precise, on) +int val2 = __FLT_EVAL_METHOD__; + } + return __FLT_EVAL_METHOD__; ---

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

wenlei updated this revision to Diff 414737. wenlei added a comment. Add test check for template type parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D120610 Files: llvm/lib/CodeGen/AsmPrinter/DIE.cp

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

wenlei added a comment. In D120610#3376002 , @dblaikie wrote: > It'd be good to include some testing beyond "does not crash" - like what was > the specific debug info we were trying to create when the crash was hit? > Perhaps we should be testing that (

[PATCH] D121076: [MLIR][Python] Add SCFIfOp Python binding

mehdi_amini added a comment. Can you rebase? Your patch does not apply apparently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121076/new/ https://reviews.llvm.org/D121076 ___ cfe-commits mailing list c

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:113-116 +#pragma float_control(precise, on) +int val2 = __FLT_EVAL_METHOD__; + } + return __FLT_EVAL_METHOD__; aaron.ballman wrote: > Shouldn't there be CHECK lines for t

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. @aaron.ballman, I haven't had a chance to look at the code in detail yet, but I would like to get on the same page about the error/warning behaviour. In the older modes, we stay conforming either - by producing the warning (when we know the user said they

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414739. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/t

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. In D111400#3376070 , @hubert.reinterpretcast wrote: > In C++2b, the `-Wc++20-compat` warning is produced for the places where we > warn above and is not produced for the places where we don't warn above. I'm not

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 414743. vaibhav.y marked 15 inline comments as done. vaibhav.y added a comment. Herald added a project: All. Fixup comments Mark clang::FullSourceRange as returning const & to its locs rebase on upstream main Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. Hi, Apologies for the long delay! I was on a short break to focus to other projects. I have some changes in mind such as: - Creating the `SarifLog` object to represent the top-level document. Currently we store this as a JSON object which ends up rather mucky. Having

[clang-tools-extra] 602ea53 - [clang-tidy] Refactor: Prefer single quoted strings over double quoted strings [NFC]

Author: Richard Date: 2022-03-11T15:08:24-07:00 New Revision: 602ea53cb7e7119f7ba33239ca8ead377f2fcbd4 URL: https://github.com/llvm/llvm-project/commit/602ea53cb7e7119f7ba33239ca8ead377f2fcbd4 DIFF: https://github.com/llvm/llvm-project/commit/602ea53cb7e7119f7ba33239ca8ead377f2fcbd4.diff LOG:

[clang] 9f616a4 - [clang-format][NFC] Group QualifierAlignment with other C++ passes

Author: owenca Date: 2022-03-11T14:18:00-08:00 New Revision: 9f616a467fc710f084b7e57812a2ed64c214c2c6 URL: https://github.com/llvm/llvm-project/commit/9f616a467fc710f084b7e57812a2ed64c214c2c6 DIFF: https://github.com/llvm/llvm-project/commit/9f616a467fc710f084b7e57812a2ed64c214c2c6.diff LOG: [

[PATCH] D121434: [clang-format][NFC] Group QualifierAlignment with other C++ passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f616a467fc7: [clang-format][NFC] Group QualifierAlignment with other C++ passes (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121434/

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham updated this revision to Diff 414751. bnbarham edited the summary of this revision. bnbarham added a comment. Update to single review dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426 Fi

[PATCH] D121450: [clang-format] Handle attributes before case label.

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:578 +break; + LLVM_FALLTHROUGH; Can we remove this empty line? Comment at: clang/lib/Format/UnwrappedLineParser.h

[clang] 46626bc - [NFC] Improve comment and rename test file

Author: Julian Lettner Date: 2022-03-11T14:47:54-08:00 New Revision: 46626bc87382cad7a0c5ba497b3454337c45faa8 URL: https://github.com/llvm/llvm-project/commit/46626bc87382cad7a0c5ba497b3454337c45faa8 DIFF: https://github.com/llvm/llvm-project/commit/46626bc87382cad7a0c5ba497b3454337c45faa8.diff

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Herald added a subscriber: cfe-commits. The Windows SDK has occurrences of the `i128` and `ui128` suffix (at least in

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou created this revision. zhouyizhou added reviewers: rsmith, erichkeane, CornedBee. Herald added a project: All. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compile following code without -std=c++17, clang will

[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0f6cfb7b9f: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang-tools-extra] 0c0f6cf - [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Author: Petr Hosek Date: 2022-03-11T15:43:01-08:00 New Revision: 0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 URL: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 DIFF: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794.diff LO

[clang] 0c0f6cf - [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Author: Petr Hosek Date: 2022-03-11T15:43:01-08:00 New Revision: 0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 URL: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 DIFF: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794.diff LO

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

hiraditya added a comment. Herald added a project: All. Is there a plan to revive this? this is quite necessary for one of my use cases. can we at least have '-fno-instrument-functions'? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624 __

  1   2   >