dblaikie added a comment.

It'd be good to include some testing beyond "does not crash" - like what was 
the specific debug info we were trying to create when the crash was hit? 
Perhaps we should be testing that (since the crash demonstrates we weren't 
testing that anywhere else)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120610/new/

https://reviews.llvm.org/D120610

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to