Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land.
Nice! ================ Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:27 -static std::string getPackageFullName(const Record *R); +static std::string getPackageFullName(const Record *R, StringRef Sep = "."); ---------------- ~~Do you foresee a change in the default separator? I think an eventual shift away from packages is more likely (see https://discourse.llvm.org/t/analyzer-refactoring-analyzeroptions/50160/5). ~~ ~~I this an unnecessary complexity, but its not a hill I will die on.~~ edit: I just realized that you need this for the url, so never mind. I grave dug a 3 yr old topic on discourse because of it :^) Oops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
