DavidSpickett added inline comments.
================
Comment at: clang/lib/Basic/Targets/CSKY.cpp:43
+ Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1");
+ Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1");
+
----------------
Any need to handle when ABI is not avbiv2 or abiv1 or will it always be one of
the two?
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:373
+
+ std::string Path = (GCCInstallation.getInstallPath() + "/../../../../" +
+ GCCInstallation.getTriple().str() + "/libc").str();
----------------
Can you comment what all the `..` are going to/from. I assume from some deep
folder back up, down into the sysroot but an example in a comment would be good
to document it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121445/new/
https://reviews.llvm.org/D121445
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
